mirror of
https://github.com/we-promise/sure.git
synced 2026-07-13 21:35:20 +00:00
* feat(up): add Up Bank (AU) provider integration Adds Up Bank as a per-family, token-based bank sync provider, modelled on the existing Akahu integration. Up uses a JSON:API REST API with a personal access token (Bearer), cursor pagination via links.next, and returns both HELD (pending) and SETTLED transactions from one endpoint. New: - Provider::Up client (JSON:API unwrap, links.next pagination, retries, typed errors, /util/ping) + Provider::UpAdapter (Factory-registered, Depository + Loan). - UpItem / UpAccount models with Provided, Unlinking, Syncer, SyncCompleteEvent, Importer, Processor, Transactions::Processor, and UpEntry::Processor (amount sign flip, HELD->pending, foreignAmount FX, merchant from description, stale-pending pruning). - Family::UpConnectable, UpItemsController, routes, settings panel + connect flow views, accounts index wiring, initializer, en locale, and model tests. Core wiring: - "up" added to Transaction::PENDING_PROVIDERS, the three pending-match SQL blocks in Account::ProviderImportAdapter, Provider::Metadata::REGISTRY, ProviderMerchant/DataEnrichment source enums, ProviderConnectionStatus, settings provider panels, and financial data reset. Migration create_up_items_and_accounts must be run before use. No external API endpoints added (no OpenAPI changes). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(up): dump up tables to schema and make since filter TZ-safe The feature commit added the up_items/up_accounts migration but never re-dumped db/schema.rb, leaving the schema version and tables stale. Add the two table definitions and foreign keys and bump the schema version so a fresh DB load matches the migration. Also format a bare Date `since` as UTC midnight instead of the server's local zone, so `filter[since]` is deterministic regardless of where the app runs (previously shifted by the local UTC offset). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(up): address code review feedback Behavior/correctness: - Persist skipped accounts via a new up_accounts.ignored flag and a needs_setup scope, so skipped accounts stop resurfacing as "needs setup" on every sync. Linking clears the flag. - destroy now checks unlink_all! per-account results and aborts deletion (alert) if any unlink failed, instead of swallowing failures. - render_provider_panel_error redirect uses :see_other (was an invalid 4xx redirect status). - Up provider adapter falls back to item institution name/url when institution_metadata is absent (early return previously blocked it). Resilience/security: - fetch_all_resources guards against an API repeating the same links.next cursor (Set#add?), preventing infinite pagination. - HTTP client validates absolute URLs (from links.next) against Up's HTTPS host before sending the bearer token, preventing credential leakage to untrusted hosts. Diagnostics: - Route provider sync/import failures through DebugLogEntry.capture (controller, UpItem, syncer, unlinking) with family/account context. Low-level HTTP client and currency-normalization warnings keep Rails.logger to match existing provider conventions. Data integrity: - up_accounts.name and currency are NOT NULL (align with model presence validations); account_id stays nullable (allow_nil uniqueness). Forms: - select_existing_account radio is required; controller guards a blank/ unknown up_account_id with a friendly alert instead of RecordNotFound. Tests: - Add UpAccount needs_setup scope test, pagination loop guard test, untrusted-host rejection test; tighten filter[since] assertion to the exact UTC timestamp. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(up): address second-round review feedback - Capture sync/import failures via DebugLogEntry so swallowed errors in account/transaction fetching and transaction processing surface in /settings/debug instead of only Rails.logger. - Gate UP_DEBUG_RAW raw payload dump to local envs to avoid leaking PII (merchant names, amounts, account IDs) in managed/production logs. - Collapse linked/unlinked/total account counts into one memoized query instead of 3 separate COUNTs per rendered item. - Rename "Set Up Up Accounts" locale title to "Link Up Accounts". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs(up): add method docstrings and align failed_result keys Add docstrings to all Up provider source files (controller, models, providers, concerns) to satisfy the 80% docstring coverage threshold. Third-round review: failed_result now mirrors import's result shape (accounts_updated/created/failed, transactions_imported/failed) instead of the stale accounts_imported key, so failure results stay consistent. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
92 lines
3.6 KiB
Ruby
92 lines
3.6 KiB
Ruby
class UpAccount::Transactions::Processor
|
|
attr_reader :up_account
|
|
|
|
# Build a transactions processor for the given +up_account+.
|
|
def initialize(up_account)
|
|
@up_account = up_account
|
|
end
|
|
|
|
# Process each stored raw transaction into a Sure entry, prune stale pending
|
|
# entries, and return a stats hash (total/imported/failed/pruned/errors).
|
|
def process
|
|
unless up_account.raw_transactions_payload.present?
|
|
Rails.logger.info "UpAccount::Transactions::Processor - No Up transactions available to process"
|
|
pruned_count = prune_stale_pending_entries([])
|
|
return { success: true, total: 0, imported: 0, failed: 0, pruned_pending: pruned_count, errors: [] }
|
|
end
|
|
|
|
total_count = up_account.raw_transactions_payload.count
|
|
imported_count = 0
|
|
failed_count = 0
|
|
errors = []
|
|
current_pending_external_ids = pending_external_ids
|
|
|
|
up_account.raw_transactions_payload.each_with_index do |transaction_data, index|
|
|
result = UpEntry::Processor.new(
|
|
transaction_data,
|
|
up_account: up_account
|
|
).process
|
|
|
|
if result.nil?
|
|
failed_count += 1
|
|
errors << { index: index, transaction_id: transaction_id(transaction_data), error: "No linked account" }
|
|
else
|
|
imported_count += 1
|
|
end
|
|
rescue ArgumentError => e
|
|
failed_count += 1
|
|
errors << { index: index, transaction_id: transaction_id(transaction_data), error: "Validation error: #{e.message}" }
|
|
Rails.logger.error "UpAccount::Transactions::Processor - Validation error processing transaction #{transaction_id(transaction_data)}: #{e.message}"
|
|
rescue => e
|
|
failed_count += 1
|
|
errors << { index: index, transaction_id: transaction_id(transaction_data), error: "#{e.class}: #{e.message}" }
|
|
Rails.logger.error "UpAccount::Transactions::Processor - Error processing transaction #{transaction_id(transaction_data)}: #{e.class} - #{e.message}"
|
|
Rails.logger.error e.backtrace.join("\n")
|
|
end
|
|
pruned_count = prune_stale_pending_entries(current_pending_external_ids)
|
|
|
|
{
|
|
success: failed_count.zero?,
|
|
total: total_count,
|
|
imported: imported_count,
|
|
failed: failed_count,
|
|
pruned_pending: pruned_count,
|
|
errors: errors
|
|
}
|
|
end
|
|
|
|
private
|
|
|
|
# Extract the Up transaction id from raw data, or "unknown".
|
|
def transaction_id(transaction_data)
|
|
transaction_data.try(:[], :id) || transaction_data.try(:[], "id") || "unknown"
|
|
end
|
|
|
|
# Canonical external ids of the currently-HELD (pending) transactions.
|
|
def pending_external_ids
|
|
up_account.raw_transactions_payload.filter_map do |transaction_data|
|
|
next unless transaction_data.is_a?(Hash)
|
|
next unless UpEntry::Processor.pending?(transaction_data)
|
|
|
|
UpEntry::Processor.canonical_external_id(transaction_data)
|
|
end
|
|
end
|
|
|
|
# Delete previously-imported pending entries no longer present in the latest
|
|
# fetch (cancelled/settled holds), returning how many were removed.
|
|
def prune_stale_pending_entries(current_pending_external_ids)
|
|
account = up_account.current_account
|
|
return 0 unless account.present?
|
|
|
|
stale_pending_entries = account.entries
|
|
.joins("INNER JOIN transactions ON transactions.id = entries.entryable_id AND entries.entryable_type = 'Transaction'")
|
|
.where(source: "up")
|
|
.where("(transactions.extra -> 'up' ->> 'pending')::boolean = true")
|
|
stale_pending_entries = stale_pending_entries.where.not(external_id: current_pending_external_ids) if current_pending_external_ids.any?
|
|
|
|
count = stale_pending_entries.count
|
|
stale_pending_entries.find_each(&:destroy!) if count.positive?
|
|
count
|
|
end
|
|
end
|