mirror of
https://github.com/we-promise/sure.git
synced 2026-04-08 06:44:52 +00:00
* Add pending transaction handling and duplicate reconciliation logic - Implemented logic to exclude pending transactions from budgets and analytics calculations. - Introduced mechanisms for reconciling pending transactions with posted versions. - Added duplicate detection with support for merging or dismissing matches. - Updated transaction search filters to include a `status_filter` for pending/confirmed transactions. - Introduced UI elements for reviewing and resolving duplicates. - Enhanced `ProviderSyncSummary` with stats for reconciled and stale pending transactions. * Refactor translation handling and enhance transaction and sync logic - Moved hardcoded strings to locale files for improved translation support. - Refined styling for duplicate transaction indicators and sync summaries. - Improved logic for excluding stale pending transactions and updating timestamps on batch exclusion. - Added unique IDs to status filters for better element targeting in UI. - Optimized database queries to avoid N+1 issues in stale pending calculations. * Add sync settings and enhance pending transaction handling - Introduced a new "Sync Settings" section in hosting settings with UI to toggle inclusion of pending transactions. - Updated handling of pending transactions with improved inference logic for `posted=0` and `transacted_at` in processors. - Added priority order for pending transaction inclusion: explicit argument > environment variable > runtime configurable setting. - Refactored settings and controllers to store updated sync preferences. * Refactor sync settings and pending transaction reconciliation - Extracted logic for pending transaction reconciliation, stale exclusion, and unmatched tracking into dedicated methods for better maintainability. - Updated sync settings to infer defaults from multiple provider environment variables (`SIMPLEFIN_INCLUDE_PENDING`, `PLAID_INCLUDE_PENDING`). - Refined UI and messaging to handle multi-provider configurations in sync settings. # Conflicts: # app/models/simplefin_item/importer.rb * Debounce transaction reconciliation during imports - Added per-run reconciliation debouncing to prevent repeated scans for the same account during chunked history imports. - Trimmed size of reconciliation stats to retain recent details only. - Introduced error tracking for reconciliation steps to improve UI visibility of issues. * Apply ABS() in pending transaction queries and improve error handling - Updated pending transaction logic to use ABS() for consistent handling of negative amounts. - Adjusted amount bounds calculations to ensure accuracy for both positive and negative values. - Refined exception handling in `merge_duplicate` to log failures and update user alert. - Replaced `Date.today` with `Date.current` in tests to ensure timezone consistency. - Minor optimization to avoid COUNT queries by loading limited records directly. * Improve error handling in duplicate suggestion and dismissal logic - Added exception handling for `store_duplicate_suggestion` to log failures and prevent crashes during fuzzy/low-confidence matches. - Enhanced `dismiss_duplicate` action to handle `ActiveRecord::RecordInvalid` and display appropriate user alerts. --------- Co-authored-by: Josh Waldrep <joshua.waldrep5+github@gmail.com>
210 lines
4.6 KiB
Ruby
210 lines
4.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
# Reusable sync summary component for provider items.
|
|
#
|
|
# This component displays sync statistics in a collapsible panel that can be used
|
|
# by any provider (SimpleFIN, Plaid, Lunchflow, etc.) to show their sync results.
|
|
#
|
|
# @example Basic usage
|
|
# <%= render ProviderSyncSummary.new(
|
|
# stats: @sync_stats,
|
|
# provider_item: @plaid_item
|
|
# ) %>
|
|
#
|
|
# @example With custom institution count
|
|
# <%= render ProviderSyncSummary.new(
|
|
# stats: @sync_stats,
|
|
# provider_item: @simplefin_item,
|
|
# institutions_count: @simplefin_item.connected_institutions.size
|
|
# ) %>
|
|
#
|
|
class ProviderSyncSummary < ViewComponent::Base
|
|
attr_reader :stats, :provider_item, :institutions_count
|
|
|
|
# @param stats [Hash] The sync statistics hash from sync.sync_stats
|
|
# @param provider_item [Object] The provider item (must respond to last_synced_at)
|
|
# @param institutions_count [Integer, nil] Optional count of connected institutions
|
|
def initialize(stats:, provider_item:, institutions_count: nil)
|
|
@stats = stats || {}
|
|
@provider_item = provider_item
|
|
@institutions_count = institutions_count
|
|
end
|
|
|
|
def render?
|
|
stats.present?
|
|
end
|
|
|
|
# Account statistics
|
|
def total_accounts
|
|
stats["total_accounts"].to_i
|
|
end
|
|
|
|
def linked_accounts
|
|
stats["linked_accounts"].to_i
|
|
end
|
|
|
|
def unlinked_accounts
|
|
stats["unlinked_accounts"].to_i
|
|
end
|
|
|
|
# Transaction statistics
|
|
def tx_seen
|
|
stats["tx_seen"].to_i
|
|
end
|
|
|
|
def tx_imported
|
|
stats["tx_imported"].to_i
|
|
end
|
|
|
|
def tx_updated
|
|
stats["tx_updated"].to_i
|
|
end
|
|
|
|
def tx_skipped
|
|
stats["tx_skipped"].to_i
|
|
end
|
|
|
|
def has_transaction_stats?
|
|
stats.key?("tx_seen") || stats.key?("tx_imported") || stats.key?("tx_updated")
|
|
end
|
|
|
|
# Holdings statistics
|
|
def holdings_found
|
|
stats["holdings_found"].to_i
|
|
end
|
|
|
|
def holdings_processed
|
|
stats["holdings_processed"].to_i
|
|
end
|
|
|
|
def has_holdings_stats?
|
|
stats.key?("holdings_found") || stats.key?("holdings_processed")
|
|
end
|
|
|
|
def holdings_label_key
|
|
stats.key?("holdings_processed") ? "processed" : "found"
|
|
end
|
|
|
|
def holdings_count
|
|
stats.key?("holdings_processed") ? holdings_processed : holdings_found
|
|
end
|
|
|
|
# Returns the CSS color class for a data quality detail severity
|
|
# @param severity [String] The severity level ("warning", "error", or other)
|
|
# @return [String] The Tailwind CSS class for the color
|
|
def severity_color_class(severity)
|
|
case severity
|
|
when "warning" then "text-warning"
|
|
when "error" then "text-destructive"
|
|
else "text-secondary"
|
|
end
|
|
end
|
|
|
|
# Health statistics
|
|
def rate_limited?
|
|
stats["rate_limited"].present? || stats["rate_limited_at"].present?
|
|
end
|
|
|
|
def rate_limited_ago
|
|
return nil unless stats["rate_limited_at"].present?
|
|
|
|
begin
|
|
helpers.time_ago_in_words(Time.parse(stats["rate_limited_at"]))
|
|
rescue StandardError
|
|
nil
|
|
end
|
|
end
|
|
|
|
def total_errors
|
|
stats["total_errors"].to_i
|
|
end
|
|
|
|
def import_started?
|
|
stats["import_started"].present?
|
|
end
|
|
|
|
def has_errors?
|
|
total_errors > 0
|
|
end
|
|
|
|
# Stale pending transactions (auto-excluded)
|
|
def stale_pending_excluded
|
|
stats["stale_pending_excluded"].to_i
|
|
end
|
|
|
|
def has_stale_pending?
|
|
stale_pending_excluded > 0
|
|
end
|
|
|
|
def stale_pending_details
|
|
stats["stale_pending_details"] || []
|
|
end
|
|
|
|
# Stale unmatched pending (need manual review - couldn't be automatically matched)
|
|
def stale_unmatched_pending
|
|
stats["stale_unmatched_pending"].to_i
|
|
end
|
|
|
|
def has_stale_unmatched_pending?
|
|
stale_unmatched_pending > 0
|
|
end
|
|
|
|
def stale_unmatched_details
|
|
stats["stale_unmatched_details"] || []
|
|
end
|
|
|
|
# Pending→posted reconciliation stats
|
|
def pending_reconciled
|
|
stats["pending_reconciled"].to_i
|
|
end
|
|
|
|
def has_pending_reconciled?
|
|
pending_reconciled > 0
|
|
end
|
|
|
|
def pending_reconciled_details
|
|
stats["pending_reconciled_details"] || []
|
|
end
|
|
|
|
# Duplicate suggestions needing user review
|
|
def duplicate_suggestions_created
|
|
stats["duplicate_suggestions_created"].to_i
|
|
end
|
|
|
|
def has_duplicate_suggestions_created?
|
|
duplicate_suggestions_created > 0
|
|
end
|
|
|
|
def duplicate_suggestions_details
|
|
stats["duplicate_suggestions_details"] || []
|
|
end
|
|
|
|
# Data quality / warnings
|
|
def data_warnings
|
|
stats["data_warnings"].to_i
|
|
end
|
|
|
|
def notices
|
|
stats["notices"].to_i
|
|
end
|
|
|
|
def data_quality_details
|
|
stats["data_quality_details"] || []
|
|
end
|
|
|
|
def has_data_quality_issues?
|
|
data_warnings > 0 || notices > 0 || data_quality_details.any?
|
|
end
|
|
|
|
# Last sync time
|
|
def last_synced_at
|
|
provider_item.last_synced_at
|
|
end
|
|
|
|
def last_synced_ago
|
|
return nil unless last_synced_at
|
|
|
|
helpers.time_ago_in_words(last_synced_at)
|
|
end
|
|
end
|