mirror of
https://github.com/we-promise/sure.git
synced 2026-04-08 06:44:52 +00:00
* Add pending transaction handling and duplicate reconciliation logic - Implemented logic to exclude pending transactions from budgets and analytics calculations. - Introduced mechanisms for reconciling pending transactions with posted versions. - Added duplicate detection with support for merging or dismissing matches. - Updated transaction search filters to include a `status_filter` for pending/confirmed transactions. - Introduced UI elements for reviewing and resolving duplicates. - Enhanced `ProviderSyncSummary` with stats for reconciled and stale pending transactions. * Refactor translation handling and enhance transaction and sync logic - Moved hardcoded strings to locale files for improved translation support. - Refined styling for duplicate transaction indicators and sync summaries. - Improved logic for excluding stale pending transactions and updating timestamps on batch exclusion. - Added unique IDs to status filters for better element targeting in UI. - Optimized database queries to avoid N+1 issues in stale pending calculations. * Add sync settings and enhance pending transaction handling - Introduced a new "Sync Settings" section in hosting settings with UI to toggle inclusion of pending transactions. - Updated handling of pending transactions with improved inference logic for `posted=0` and `transacted_at` in processors. - Added priority order for pending transaction inclusion: explicit argument > environment variable > runtime configurable setting. - Refactored settings and controllers to store updated sync preferences. * Refactor sync settings and pending transaction reconciliation - Extracted logic for pending transaction reconciliation, stale exclusion, and unmatched tracking into dedicated methods for better maintainability. - Updated sync settings to infer defaults from multiple provider environment variables (`SIMPLEFIN_INCLUDE_PENDING`, `PLAID_INCLUDE_PENDING`). - Refined UI and messaging to handle multi-provider configurations in sync settings. # Conflicts: # app/models/simplefin_item/importer.rb * Debounce transaction reconciliation during imports - Added per-run reconciliation debouncing to prevent repeated scans for the same account during chunked history imports. - Trimmed size of reconciliation stats to retain recent details only. - Introduced error tracking for reconciliation steps to improve UI visibility of issues. * Apply ABS() in pending transaction queries and improve error handling - Updated pending transaction logic to use ABS() for consistent handling of negative amounts. - Adjusted amount bounds calculations to ensure accuracy for both positive and negative values. - Refined exception handling in `merge_duplicate` to log failures and update user alert. - Replaced `Date.today` with `Date.current` in tests to ensure timezone consistency. - Minor optimization to avoid COUNT queries by loading limited records directly. * Improve error handling in duplicate suggestion and dismissal logic - Added exception handling for `store_duplicate_suggestion` to log failures and prevent crashes during fuzzy/low-confidence matches. - Enhanced `dismiss_duplicate` action to handle `ActiveRecord::RecordInvalid` and display appropriate user alerts. --------- Co-authored-by: Josh Waldrep <joshua.waldrep5+github@gmail.com>
66 lines
2.1 KiB
Ruby
66 lines
2.1 KiB
Ruby
class IncomeStatement::CategoryStats
|
|
def initialize(family, interval: "month")
|
|
@family = family
|
|
@interval = interval
|
|
end
|
|
|
|
def call
|
|
ActiveRecord::Base.connection.select_all(sanitized_query_sql).map do |row|
|
|
StatRow.new(
|
|
category_id: row["category_id"],
|
|
classification: row["classification"],
|
|
median: row["median"],
|
|
avg: row["avg"]
|
|
)
|
|
end
|
|
end
|
|
|
|
private
|
|
StatRow = Data.define(:category_id, :classification, :median, :avg)
|
|
|
|
def sanitized_query_sql
|
|
ActiveRecord::Base.sanitize_sql_array([
|
|
query_sql,
|
|
{
|
|
target_currency: @family.currency,
|
|
interval: @interval,
|
|
family_id: @family.id
|
|
}
|
|
])
|
|
end
|
|
|
|
def query_sql
|
|
<<~SQL
|
|
WITH period_totals AS (
|
|
SELECT
|
|
c.id as category_id,
|
|
date_trunc(:interval, ae.date) as period,
|
|
CASE WHEN ae.amount < 0 THEN 'income' ELSE 'expense' END as classification,
|
|
SUM(ae.amount * COALESCE(er.rate, 1)) as total
|
|
FROM transactions t
|
|
JOIN entries ae ON ae.entryable_id = t.id AND ae.entryable_type = 'Transaction'
|
|
JOIN accounts a ON a.id = ae.account_id
|
|
LEFT JOIN categories c ON c.id = t.category_id
|
|
LEFT JOIN exchange_rates er ON (
|
|
er.date = ae.date AND
|
|
er.from_currency = ae.currency AND
|
|
er.to_currency = :target_currency
|
|
)
|
|
WHERE a.family_id = :family_id
|
|
AND t.kind NOT IN ('funds_movement', 'one_time', 'cc_payment')
|
|
AND ae.excluded = false
|
|
AND (t.extra -> 'simplefin' ->> 'pending')::boolean IS DISTINCT FROM true
|
|
AND (t.extra -> 'plaid' ->> 'pending')::boolean IS DISTINCT FROM true
|
|
GROUP BY c.id, period, CASE WHEN ae.amount < 0 THEN 'income' ELSE 'expense' END
|
|
)
|
|
SELECT
|
|
category_id,
|
|
classification,
|
|
ABS(PERCENTILE_CONT(0.5) WITHIN GROUP (ORDER BY total)) as median,
|
|
ABS(AVG(total)) as avg
|
|
FROM period_totals
|
|
GROUP BY category_id, classification;
|
|
SQL
|
|
end
|
|
end
|