mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 22:34:47 +00:00
4fb0a3856e
* Implement providers factory * Multiple providers sync support - Proper Multi-Provider Syncing: When you click sync on an account with multiple providers (e.g., both Plaid and SimpleFin), all provider items are synced - Better API: The existing account.providers method already returns all providers, and account.provider returns the first one for backward compatibility - Correct Holdings Deletion Logic: Holdings can only be deleted if ALL providers allow it, preventing accidental deletions that would be recreated on next sync TODO: validate this is the way we want to go? We would need to check holdings belong to which account, and then check provider allows deletion. More complex - Database Constraints: The existing validations ensure an account can have at most one provider of each type (one PlaidAccount, one SimplefinAccount, etc.) * Add generic provider_import_adapter * Finish unified import strategy * Update app/models/plaid_account.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <sokysrm@gmail.com> * Update app/models/provider/factory.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <sokysrm@gmail.com> * Fix account linked by plaid_id instead of external_id * Parse numerics to BigDecimal Parse numerics to BigDecimal before computing amount; guard nils. Avoid String * String and float drift; also normalize date. * Fix incorrect usage of assert_raises. * Fix linter * Fix processor test. * Update current_balance_manager.rb * Test fixes * Fix plaid linked account test * Add support for holding per account_provider * Fix proper account access Also fix account deletion for simpefin too * FIX match tests for consistency * Some more factory updates * Fix account schema for multipe providers Can do: - Account #1 → PlaidAccount + SimplefinAccount (multiple different providers) - Account #2 → PlaidAccount only - Account #3 → SimplefinAccount only Cannot do: - Account #1 → PlaidAccount + PlaidAccount (duplicate provider type) - PlaidAccount #123 → Account #1 + Account #2 (provider linked to multiple accounts) * Fix account setup - An account CAN have multiple providers (the schema shows account_providers with unique index on [account_id, provider_type]) - Each provider should maintain its own separate entries - We should NOT update one provider's entry when another provider syncs * Fix linter and guard migration * FIX linter issues. * Fixes - Remove duplicated index - Pass account_provider_id - Guard holdings call to avoid NoMethodError * Update schema and provider import fix * Plaid doesn't allow holdings deletion * Use ClimateControl for proper env setup * No need for this in .git --------- Signed-off-by: soky srm <sokysrm@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
64 lines
1.8 KiB
Ruby
64 lines
1.8 KiB
Ruby
class PlaidAccount < ApplicationRecord
|
|
belongs_to :plaid_item
|
|
|
|
# Legacy association via foreign key (will be removed after migration)
|
|
has_one :account, dependent: :nullify, foreign_key: :plaid_account_id
|
|
# New association through account_providers
|
|
has_one :account_provider, as: :provider, dependent: :destroy
|
|
has_one :linked_account, through: :account_provider, source: :account
|
|
|
|
validates :name, :plaid_type, :currency, presence: true
|
|
validate :has_balance
|
|
|
|
# Helper to get account using new system first, falling back to legacy
|
|
def current_account
|
|
linked_account || account
|
|
end
|
|
|
|
def upsert_plaid_snapshot!(account_snapshot)
|
|
assign_attributes(
|
|
current_balance: account_snapshot.balances.current,
|
|
available_balance: account_snapshot.balances.available,
|
|
currency: account_snapshot.balances.iso_currency_code,
|
|
plaid_type: account_snapshot.type,
|
|
plaid_subtype: account_snapshot.subtype,
|
|
name: account_snapshot.name,
|
|
mask: account_snapshot.mask,
|
|
raw_payload: account_snapshot
|
|
)
|
|
|
|
save!
|
|
end
|
|
|
|
def upsert_plaid_transactions_snapshot!(transactions_snapshot)
|
|
assign_attributes(
|
|
raw_transactions_payload: transactions_snapshot
|
|
)
|
|
|
|
save!
|
|
end
|
|
|
|
def upsert_plaid_investments_snapshot!(investments_snapshot)
|
|
assign_attributes(
|
|
raw_investments_payload: investments_snapshot
|
|
)
|
|
|
|
save!
|
|
end
|
|
|
|
def upsert_plaid_liabilities_snapshot!(liabilities_snapshot)
|
|
assign_attributes(
|
|
raw_liabilities_payload: liabilities_snapshot
|
|
)
|
|
|
|
save!
|
|
end
|
|
|
|
private
|
|
# Plaid guarantees at least one of these. This validation is a sanity check for that guarantee.
|
|
def has_balance
|
|
return if current_balance.present? || available_balance.present?
|
|
errors.add(:base, "Plaid account must have either current or available balance")
|
|
end
|
|
end
|