mirror of
https://github.com/we-promise/sure.git
synced 2026-07-20 08:45:22 +00:00
* Implement providers factory * Multiple providers sync support - Proper Multi-Provider Syncing: When you click sync on an account with multiple providers (e.g., both Plaid and SimpleFin), all provider items are synced - Better API: The existing account.providers method already returns all providers, and account.provider returns the first one for backward compatibility - Correct Holdings Deletion Logic: Holdings can only be deleted if ALL providers allow it, preventing accidental deletions that would be recreated on next sync TODO: validate this is the way we want to go? We would need to check holdings belong to which account, and then check provider allows deletion. More complex - Database Constraints: The existing validations ensure an account can have at most one provider of each type (one PlaidAccount, one SimplefinAccount, etc.) * Add generic provider_import_adapter * Finish unified import strategy * Update app/models/plaid_account.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <sokysrm@gmail.com> * Update app/models/provider/factory.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: soky srm <sokysrm@gmail.com> * Fix account linked by plaid_id instead of external_id * Parse numerics to BigDecimal Parse numerics to BigDecimal before computing amount; guard nils. Avoid String * String and float drift; also normalize date. * Fix incorrect usage of assert_raises. * Fix linter * Fix processor test. * Update current_balance_manager.rb * Test fixes * Fix plaid linked account test * Add support for holding per account_provider * Fix proper account access Also fix account deletion for simpefin too * FIX match tests for consistency * Some more factory updates * Fix account schema for multipe providers Can do: - Account #1 → PlaidAccount + SimplefinAccount (multiple different providers) - Account #2 → PlaidAccount only - Account #3 → SimplefinAccount only Cannot do: - Account #1 → PlaidAccount + PlaidAccount (duplicate provider type) - PlaidAccount #123 → Account #1 + Account #2 (provider linked to multiple accounts) * Fix account setup - An account CAN have multiple providers (the schema shows account_providers with unique index on [account_id, provider_type]) - Each provider should maintain its own separate entries - We should NOT update one provider's entry when another provider syncs * Fix linter and guard migration * FIX linter issues. * Fixes - Remove duplicated index - Pass account_provider_id - Guard holdings call to avoid NoMethodError * Update schema and provider import fix * Plaid doesn't allow holdings deletion * Use ClimateControl for proper env setup * No need for this in .git --------- Signed-off-by: soky srm <sokysrm@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
93 lines
2.5 KiB
Ruby
93 lines
2.5 KiB
Ruby
class PlaidAccount::Investments::HoldingsProcessor
|
|
def initialize(plaid_account, security_resolver:)
|
|
@plaid_account = plaid_account
|
|
@security_resolver = security_resolver
|
|
end
|
|
|
|
def process
|
|
holdings.each do |plaid_holding|
|
|
resolved_security_result = security_resolver.resolve(plaid_security_id: plaid_holding["security_id"])
|
|
|
|
next unless resolved_security_result.security.present?
|
|
|
|
security = resolved_security_result.security
|
|
|
|
# Parse quantity and price into BigDecimal for proper arithmetic
|
|
quantity_bd = parse_decimal(plaid_holding["quantity"])
|
|
price_bd = parse_decimal(plaid_holding["institution_price"])
|
|
|
|
# Skip if essential values are missing
|
|
next if quantity_bd.nil? || price_bd.nil?
|
|
|
|
# Compute amount using BigDecimal arithmetic to avoid floating point drift
|
|
amount_bd = quantity_bd * price_bd
|
|
|
|
# Normalize date - handle string, Date, or nil
|
|
holding_date = parse_date(plaid_holding["institution_price_as_of"]) || Date.current
|
|
|
|
import_adapter.import_holding(
|
|
security: security,
|
|
quantity: quantity_bd,
|
|
amount: amount_bd,
|
|
currency: plaid_holding["iso_currency_code"] || account.currency,
|
|
date: holding_date,
|
|
price: price_bd,
|
|
account_provider_id: plaid_account.account_provider&.id,
|
|
source: "plaid",
|
|
delete_future_holdings: false # Plaid doesn't allow holdings deletion
|
|
)
|
|
end
|
|
end
|
|
|
|
private
|
|
attr_reader :plaid_account, :security_resolver
|
|
|
|
def import_adapter
|
|
@import_adapter ||= Account::ProviderImportAdapter.new(account)
|
|
end
|
|
|
|
def account
|
|
plaid_account.current_account
|
|
end
|
|
|
|
def holdings
|
|
plaid_account.raw_investments_payload&.[]("holdings") || []
|
|
end
|
|
|
|
def parse_decimal(value)
|
|
return nil if value.nil?
|
|
|
|
case value
|
|
when BigDecimal
|
|
value
|
|
when String
|
|
BigDecimal(value)
|
|
when Numeric
|
|
BigDecimal(value.to_s)
|
|
else
|
|
nil
|
|
end
|
|
rescue ArgumentError => e
|
|
Rails.logger.error("Failed to parse Plaid holding decimal value: #{value.inspect} - #{e.message}")
|
|
nil
|
|
end
|
|
|
|
def parse_date(date_value)
|
|
return nil if date_value.nil?
|
|
|
|
case date_value
|
|
when Date
|
|
date_value
|
|
when String
|
|
Date.parse(date_value)
|
|
when Time, DateTime
|
|
date_value.to_date
|
|
else
|
|
nil
|
|
end
|
|
rescue ArgumentError, TypeError => e
|
|
Rails.logger.error("Failed to parse Plaid holding date: #{date_value.inspect} - #{e.message}")
|
|
nil
|
|
end
|
|
end
|