mirror of
https://github.com/we-promise/sure.git
synced 2026-04-08 23:04:49 +00:00
10b15061b8
* Initial plan * Fix transaction name rule rendering and add tests Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com> * Remove redundant integration tests for set_transaction_name The functionality is already covered by existing unit tests in test/models/rule/action_test.rb. The core fix for this PR is the view rendering logic, not the action functionality. Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com> * Localize placeholder text for rule action value input Replace hardcoded "Enter a value" placeholder with localized t() lookup at lines 22 and 41 in app/views/rule/actions/_action.html.erb. Add corresponding translation key to config/locales/views/rules/en.yml under rules.actions.value_placeholder. Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com>
46 lines
2.0 KiB
Plaintext
46 lines
2.0 KiB
Plaintext
<%# locals: (form:) %>
|
|
|
|
<% action = form.object %>
|
|
<% rule = action.rule %>
|
|
|
|
<li data-controller="rule--actions" data-rule--actions-action-executors-value="<%= rule.action_executors.to_json %>" class="flex items-center gap-3">
|
|
<%= form.hidden_field :_destroy, value: false, data: { rule__actions_target: "destroyField" } %>
|
|
|
|
<div class="grow flex gap-2 items-center h-full">
|
|
<div class="grow">
|
|
<%= form.select :action_type, rule.action_executors.map { |executor| [ executor.label, executor.key ] }, {}, data: { action: "rule--actions#handleActionTypeChange" } %>
|
|
</div>
|
|
|
|
<%= tag.div class: class_names("min-w-1/2 flex items-center gap-2", { "hidden": action.executor.type == "function" }),
|
|
data: { rule__actions_target: "actionValue" } do %>
|
|
<%# Initial rendering based on the action executor type. %>
|
|
<%# Subsequent renders are injected by the Stimulus controller, which uses the templates from below. %>
|
|
<span class="font-medium text-primary uppercase text-xs">to</span>
|
|
<% if action.executor.type == "select" %>
|
|
<%= form.select :value, action.options || [], {} %>
|
|
<% elsif action.executor.type == "text" %>
|
|
<%= form.text_field :value, placeholder: t("rules.actions.value_placeholder") %>
|
|
<% end %>
|
|
<% end %>
|
|
</div>
|
|
|
|
<%= icon(
|
|
"trash-2",
|
|
size: "sm",
|
|
as_button: true,
|
|
data: { action: "rule--actions#remove", rule__actions_destroy_param: action.persisted? }) %>
|
|
|
|
<%# Templates for different input types - these will be cloned and used by the Stimulus controller %>
|
|
<template data-rule--actions-target="selectTemplate">
|
|
<span class="font-medium text-primary uppercase text-xs">to</span>
|
|
<%= form.select :value, [], {} %>
|
|
</template>
|
|
|
|
<template data-rule--actions-target="textTemplate">
|
|
<span class="font-medium text-primary uppercase text-xs">to</span>
|
|
<%= form.text_field :value, placeholder: t("rules.actions.value_placeholder") %>
|
|
</template>
|
|
|
|
<%# The function type doesn't need an input, so no template is required.%>
|
|
</li>
|