Files
sure/test/models/family/syncer_test.rb
Copilot b6d67b5348 Fix disabled rules executing during automatic sync (#552)
* Initial plan

* Fix: Only apply active rules during sync

Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com>

* FIX test

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com>
Co-authored-by: sokie <sokysrm@gmail.com>
2026-01-07 20:18:17 +01:00

67 lines
2.0 KiB
Ruby

require "test_helper"
class Family::SyncerTest < ActiveSupport::TestCase
setup do
@family = families(:dylan_family)
end
test "syncs plaid items and manual accounts" do
family_sync = syncs(:family)
manual_accounts_count = @family.accounts.manual.count
items_count = @family.plaid_items.count
syncer = Family::Syncer.new(@family)
Account.any_instance
.expects(:sync_later)
.with(parent_sync: family_sync, window_start_date: nil, window_end_date: nil)
.times(manual_accounts_count)
PlaidItem.any_instance
.expects(:sync_later)
.with(parent_sync: family_sync, window_start_date: nil, window_end_date: nil)
.times(items_count)
syncer.perform_sync(family_sync)
assert_equal "completed", family_sync.reload.status
end
test "only applies active rules during sync" do
family_sync = syncs(:family)
# Create an active rule
active_rule = @family.rules.create!(
resource_type: "transaction",
active: true,
actions: [ Rule::Action.new(action_type: "exclude_transaction") ]
)
# Create a disabled rule
disabled_rule = @family.rules.create!(
resource_type: "transaction",
active: false,
actions: [ Rule::Action.new(action_type: "exclude_transaction") ]
)
syncer = Family::Syncer.new(@family)
# Stub the relation to return our specific instances so expectations work
@family.rules.stubs(:where).with(active: true).returns([ active_rule ])
# Expect apply_later to be called only for the active rule
active_rule.expects(:apply_later).once
disabled_rule.expects(:apply_later).never
# Mock the account and plaid item syncs to avoid side effects
Account.any_instance.stubs(:sync_later)
PlaidItem.any_instance.stubs(:sync_later)
SimplefinItem.any_instance.stubs(:sync_later)
LunchflowItem.any_instance.stubs(:sync_later)
EnableBankingItem.any_instance.stubs(:sync_later)
syncer.perform_sync(family_sync)
end
end