mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 14:31:25 +00:00
* Add `investment_activity_label` to trades and enhance activity label handling - Introduced `investment_activity_label` column to the `trades` table with a migration. - Backfilled existing `trades` with activity labels based on quantity (`Buy`, `Sell`, or `Other`). - Replaced `category_id` in trades with `investment_activity_label` for better alignment with transaction labels. - Updated views and controllers to display and manage activity labels for trades. - Added localized badge components for displaying and editing labels dynamically. - Enhanced `PlaidAccount::Investments::TransactionsProcessor` to assign and process activity labels automatically. - Added investment flows section to reports for tracking contributions and withdrawals. - Refactored related tests and models for consistency and to ensure proper validation and filtering. * Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions - Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature. - Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers. - Streamlined UI for trade and transaction forms by updating dropdown options and label text. - Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility. - Adjusted tests and views to align with updated workflows and ensure consistent behavior. * Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions - Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature. - Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers. - Streamlined UI for trade and transaction forms by updating dropdown options and label text. - Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility. - Adjusted tests and views to align with updated workflows and ensure consistent behavior. * Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions - Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature. - Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers. - Streamlined UI for trade and transaction forms by updating dropdown options and label text. - Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility. - Adjusted tests and views to align with updated workflows and ensure consistent behavior. * Add safeguard for `dropdownTarget` existence in quick edit controller - Prevent errors by ensuring `dropdownTarget` is present before toggling its visibility. * Fix undefined method 'category' for Trade on mobile view Trade model uses investment_activity_label, not category. The upstream merge introduced a call to trade.category which doesn't exist. Use the activity label badge on mobile instead. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Fix activity label logic for zero/blank quantity and sell inference - Return `nil` for blank or zero quantity in `investment_activity_label_for`. - Correct `is_sell` logic to use the amount’s sign properly in `transactions_controller`. * Fix i18n key paths in transactions controller for convert_to_trade - Update flash message translations to use full i18n paths. - Use `BigDecimal` for quantity and price calculations to improve precision. --------- Co-authored-by: Josh Waldrep <joshua.waldrep5+github@gmail.com> Co-authored-by: luckyPipewrench <luckypipewrench@proton.me> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
60 lines
1.6 KiB
Ruby
60 lines
1.6 KiB
Ruby
require "test_helper"
|
|
|
|
class TradeTest < ActiveSupport::TestCase
|
|
test "build_name generates buy trade name" do
|
|
name = Trade.build_name("buy", 10, "AAPL")
|
|
assert_equal "Buy 10.0 shares of AAPL", name
|
|
end
|
|
|
|
test "build_name generates sell trade name" do
|
|
name = Trade.build_name("sell", 5, "MSFT")
|
|
assert_equal "Sell 5.0 shares of MSFT", name
|
|
end
|
|
|
|
test "build_name handles absolute value for negative quantities" do
|
|
name = Trade.build_name("sell", -5, "GOOGL")
|
|
assert_equal "Sell 5.0 shares of GOOGL", name
|
|
end
|
|
|
|
test "build_name handles decimal quantities" do
|
|
name = Trade.build_name("buy", 0.25, "BTC")
|
|
assert_equal "Buy 0.25 shares of BTC", name
|
|
end
|
|
|
|
test "price scale is preserved at 10 decimal places" do
|
|
security = Security.create!(ticker: "TEST", exchange_operating_mic: "XNAS")
|
|
|
|
# up to 10 decimal places — should persist exactly
|
|
precise_price = BigDecimal("12.3456789012")
|
|
trade = Trade.create!(
|
|
security: security,
|
|
price: precise_price,
|
|
qty: 10000,
|
|
currency: "USD",
|
|
investment_activity_label: "Buy"
|
|
)
|
|
|
|
trade.reload
|
|
|
|
assert_equal precise_price, trade.price
|
|
end
|
|
|
|
test "price is rounded to 10 decimal places" do
|
|
security = Security.create!(ticker: "TEST", exchange_operating_mic: "XNAS")
|
|
|
|
# over 10 decimal places — will be rounded
|
|
price_with_too_many_decimals = BigDecimal("1.123456789012345")
|
|
trade = Trade.create!(
|
|
security: security,
|
|
price: price_with_too_many_decimals,
|
|
qty: 1,
|
|
currency: "USD",
|
|
investment_activity_label: "Buy"
|
|
)
|
|
|
|
trade.reload
|
|
|
|
assert_equal BigDecimal("1.1234567890"), trade.price
|
|
end
|
|
end
|