mirror of
https://github.com/we-promise/sure.git
synced 2026-07-20 08:45:22 +00:00
* Add native Questrade brokerage provider integration Adds a per-family Questrade provider so users can sync their Questrade investment accounts (TFSA, FHSA, RRSP, margin, etc.) directly via Questrade's free personal API, with no paid aggregator. - OAuth2 refresh-token flow with single-use token rotation, persisted under a row lock. Tokens self-renew on each sync; the connected panel lets users paste a fresh token if a connection goes stale (no need to disconnect and re-link). - Imports accounts, balances, positions and activities; multi-currency holdings with per-currency cash holdings; Norbert's Gambit journals. - New-account and link-existing-account flows, settings card with desktop-only setup steps, and connect/update/disconnect. - Restricted to Investment account types. Registered in the provider connection-status registry with a syncable scope so it participates in nightly family sync. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix: linting error * fix: refresh token encrypted The OAuth token exchange passed the single-use refresh token as a GET query parameter, so it could leak into URL-based logs (Sentry breadcrumbs, APM spans, debug output). Switch to POST with a form-encoded body (RFC 6749 3.2) so the credential stays out of URLs. Verified Questrade's token endpoint accepts POST (returns 400 for a bad token, not 405). Adds a test asserting the token travels in the body. * Address PR review: authz, data integrity, retries, logging Batch of fixes from the automated PR review: - Require admin for all mutating/linking Questrade actions, and gate existing-account linking through accessible_accounts + write permission (was only Current.family scoped). - Clear requires_update when a fresh token is accepted; use a real 302 redirect (not 422) on full-page failures. - Require refresh_token on all saves (not just create) unless the item is scheduled for deletion. - Migrations target Rails 7.2; questrade_items state columns are NOT NULL. - Background activity dedup keys on Questrade fields (matches the importer) so multiple activities no longer collapse to one. - Persist the normalized account payload; date-scope synthetic cash holdings so daily history is not overwritten. - Retry 429/5xx via a RetryableResponseError instead of hard-failing. - Route provider error bodies to DebugLogEntry instead of Rails.logger / exception messages, so payloads do not leak into application logs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Address PR review: atomic linking, sync health, retry loop, USD cash - Wrap account creation + provider linking (+ sync_start_date) in a transaction in both link paths so a link failure rolls back the orphan account. - Surface per-account process/schedule failures in the item sync health instead of always reporting healthy. - Always stamp last_activities_sync once the background fetch completes, so legitimately empty accounts stop being re-queued every sync. - Treat only the account-currency (CAD) balance as primary cash; other currencies (e.g. USD) now surface as separate cash holdings instead of being hidden as primary. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Address PR review: serialize token exchange, real processor tests - Single-use token race: the SDK now wraps every token exchange (initial and 401 re-auth) in a model-supplied lock that reloads and spends the freshest persisted token (provided.rb#synchronize_exchange). Two concurrent syncs/jobs can no longer double-spend the same refresh token. Adds a test asserting the exchange runs inside the lock with the fresh token. - Replace the all-skipped QuestradeAccount processor test stubs with real fixture-backed tests covering balance anchoring, holdings import, and Buy-trade import (plus blank-symbol / blank-type guards). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Fix indentation of spliced Questrade schema blocks The manually added questrade_accounts/questrade_items create_table blocks sat at column 0 instead of the file 2-space indent, so rubocop flagged them as inconsistent. Re-indent to match the rest of the schema. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Include currency and type in the Questrade activity merge key Two activities that differ only by currency or type could collapse to a single row in merge_activities. Add both fields to activity_key in the importer and the background fetch job so multi-currency imports dedup correctly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Address review: infer account currency, Encryptable, safer flag clear From @jjmata's review: - Currency: QuestradeAccount#upsert_from_questrade! no longer hardcodes CAD for every account. upsert_balances! now infers the home currency from the per-currency balances (the currency holding the cash wins, ties broken by total equity, default CAD) so USD-denominated accounts are labelled USD and match the right combinedBalances anchor. Adds tests for USD and CAD cases. - QuestradeItem now includes the shared Encryptable concern instead of reimplementing encryption_ready? inline. - QuestradeActivitiesFetchJob#clear_pending_flag is now best-effort so it can never mask (and swallow) the original error in perform's rescue. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Fix review issues: safe_return_to_path, DebugLogEntry, financial reset, turbo_prefetch, N+1 counts - Add safe_return_to_path to QuestradeItemsController (blocks //evil.com protocol-relative open redirect; same 3-check guard as PR #2591 Wise provider) - Pass return_to through select_accounts and complete_account_setup so users land back on the account they were linking from - Replace Rails.logger.error/warn with DebugLogEntry.capture in controller and unlinking concern (surface errors in the app debug log UI) - Add questrade_items to Family::FinancialDataReset::PROVIDER_ITEM_ASSOCIATIONS so Reset Financial Data actually removes Questrade data - Add when "questrade" case to load_provider_items in providers_controller so the settings panel lazy-load refresh works - Fix turbo_prefetch: false on non-lunchflow provider links in _method_selector.html.erb and select_provider.html.erb (prevents prefetch-cache blank-modal bug for all generic sync providers) - Preload questrade_accounts: :account_provider and build @questrade_account_counts_map in AccountsController; read from map in partial instead of calling .count on associations (eliminates N+1) - Localize default connection name via I18n.t(questrade_items.default_name) - Add default_name key to questrade_items locale Patterns and bugs surfaced during review of PR #2591 (Wise provider). * Cross-apply Wise learnings to Questrade provider Encryption (matched convention from Wise/jjmata review): - Add deterministic: true to QuestradeItem#refresh_token - Add encrypts :raw_payload + :raw_institution_payload to QuestradeItem - Add Encryptable + encrypts :raw_payload, :raw_holdings_payload, :raw_activities_payload, :raw_balances_payload to QuestradeAccount (brokerage-specific columns; matches MercuryAccount/UpAccount pattern) Bug fix: - Add missing RetryableResponseError class to Provider::Questrade (used in with_retries rescue clause but never defined — would cause NameError on any rate-limited or 5xx response) Logging: - Replace Rails.logger.error with DebugLogEntry.capture in QuestradeItem#import_latest_questrade_data, #process_accounts, and #schedule_account_syncs to surface errors in the support UI Consistency: - Extract update_sync_status(sync, key, **i18n_options) helper in QuestradeItem::Syncer, replacing 5 inline sync.update! guard calls - Use blank? instead of ||= for default name fallback in create action Tests: - Add QuestradeItemsControllerTest (18 tests: CRUD, sync, account linking/setup flows, admin guard enforcement) - Add questrade fixtures: questrade_items.yml, questrade_accounts.yml - Add retry/backoff tests to Provider::QuestradeTest (network error, 429, 5xx — all verify MAX_RETRIES exhaustion raises Error) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Signed-off-by: Jestin Palamuttam <34907800+jestinjoshi@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
109 lines
4.5 KiB
Ruby
109 lines
4.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "test_helper"
|
|
require "ostruct"
|
|
|
|
class Provider::QuestradeTest < ActiveSupport::TestCase
|
|
# Security: the single-use refresh token must travel in the POST body so it
|
|
# can't leak into URLs / access logs / error-tracking breadcrumbs.
|
|
test "authenticate! sends the refresh token in the POST body, not the URL" do
|
|
token_payload = {
|
|
access_token: "access-123",
|
|
api_server: "https://api01.example.com/",
|
|
refresh_token: "rotated-456",
|
|
expires_in: 1800
|
|
}.to_json
|
|
|
|
Provider::Questrade.expects(:post)
|
|
.with(Provider::Questrade::LOGIN_URL, body: { grant_type: "refresh_token", refresh_token: "secret-rt" })
|
|
.returns(OpenStruct.new(code: 200, body: token_payload))
|
|
# Guard against regressing to a GET that carries the token in the query string.
|
|
Provider::Questrade.expects(:get).never
|
|
|
|
provider = Provider::Questrade.new(refresh_token: "secret-rt")
|
|
provider.send(:authenticate!)
|
|
|
|
assert_equal "rotated-456", provider.refresh_token, "rotated token should be surfaced for persistence"
|
|
end
|
|
# Security/correctness: the single-use token exchange must be serialized and
|
|
# must spend the freshest persisted token (see provided.rb#synchronize_exchange).
|
|
test "authenticate! spends the freshest token inside synchronize_exchange" do
|
|
token_payload = {
|
|
access_token: "at", api_server: "https://api01.example.com/",
|
|
refresh_token: "rotated", expires_in: 1800
|
|
}.to_json
|
|
|
|
lock_calls = 0
|
|
# The lock yields a token newer than the one the provider was built with.
|
|
sync = ->(&blk) { lock_calls += 1; blk.call("fresh-from-lock") }
|
|
|
|
# The exchange must use the locked/fresh token, not the stale initial one.
|
|
Provider::Questrade.expects(:post)
|
|
.with(Provider::Questrade::LOGIN_URL, body: { grant_type: "refresh_token", refresh_token: "fresh-from-lock" })
|
|
.returns(OpenStruct.new(code: 200, body: token_payload))
|
|
|
|
provider = Provider::Questrade.new(refresh_token: "stale-initial", synchronize_exchange: sync)
|
|
provider.send(:authenticate!)
|
|
|
|
assert_equal 1, lock_calls, "exchange must run inside the synchronize_exchange lock"
|
|
assert_equal "rotated", provider.refresh_token
|
|
end
|
|
|
|
test "retries network errors and raises Error after max retries exhausted" do
|
|
provider = Provider::Questrade.new(refresh_token: "test-rt")
|
|
# Authenticate first to set api_server and access_token
|
|
auth_payload = { access_token: "at", api_server: "https://api01.example.com/", refresh_token: "rt2", expires_in: 1800 }.to_json
|
|
Provider::Questrade.stubs(:post).returns(OpenStruct.new(code: 200, body: auth_payload))
|
|
provider.send(:authenticate!)
|
|
|
|
provider.stubs(:sleep)
|
|
DebugLogEntry.stubs(:capture)
|
|
|
|
attempt_count = 0
|
|
Provider::Questrade.stubs(:get).with { |*| attempt_count += 1; true }.raises(SocketError, "connection failed")
|
|
|
|
error = assert_raises(Provider::Questrade::Error) do
|
|
provider.list_accounts
|
|
end
|
|
|
|
assert_equal Provider::Questrade::MAX_RETRIES + 1, attempt_count
|
|
assert_match "Network error after #{Provider::Questrade::MAX_RETRIES} retries", error.message
|
|
end
|
|
|
|
test "retries on 429 rate limit and raises Error after max retries exhausted" do
|
|
provider = Provider::Questrade.new(refresh_token: "test-rt")
|
|
auth_payload = { access_token: "at", api_server: "https://api01.example.com/", refresh_token: "rt2", expires_in: 1800 }.to_json
|
|
Provider::Questrade.stubs(:post).returns(OpenStruct.new(code: 200, body: auth_payload))
|
|
provider.send(:authenticate!)
|
|
|
|
provider.stubs(:sleep)
|
|
DebugLogEntry.stubs(:capture)
|
|
|
|
stub_429 = OpenStruct.new(code: 429, body: "{}")
|
|
Provider::Questrade.stubs(:get).returns(stub_429)
|
|
|
|
error = assert_raises(Provider::Questrade::Error) do
|
|
provider.list_accounts
|
|
end
|
|
|
|
assert_match "Network error after #{Provider::Questrade::MAX_RETRIES} retries", error.message
|
|
end
|
|
|
|
test "retries on 5xx server error and raises Error after max retries exhausted" do
|
|
provider = Provider::Questrade.new(refresh_token: "test-rt")
|
|
auth_payload = { access_token: "at", api_server: "https://api01.example.com/", refresh_token: "rt2", expires_in: 1800 }.to_json
|
|
Provider::Questrade.stubs(:post).returns(OpenStruct.new(code: 200, body: auth_payload))
|
|
provider.send(:authenticate!)
|
|
|
|
provider.stubs(:sleep)
|
|
DebugLogEntry.stubs(:capture)
|
|
|
|
stub_503 = OpenStruct.new(code: 503, body: "{}")
|
|
Provider::Questrade.stubs(:get).returns(stub_503)
|
|
|
|
assert_raises(Provider::Questrade::Error) do
|
|
provider.list_accounts
|
|
end
|
|
end
|
|
end
|