Files
sure/app/models/indexa_capital_account/holdings_processor.rb
David Gil ba442d5f26 Implement Indexa Capital provider with real API integration (#933)
* Add Indexa Capital provider scaffold

Generate Indexa Capital provider scaffolding and align credential fields with the API authentication requirements.

* Fix PR 926 lint and schema CI failures

* Implement Indexa Capital provider with real API integration

- Rewrite all broken view templates (were meta-ERB from code generator)
- Create missing select_accounts.html.erb template
- Implement real API calls: list_accounts via /users/me, get_holdings
  via /accounts/{number}/fiscal-results, get_account_balance via
  /accounts/{number}/performance
- Add API token auth support (stored token > env token > credentials)
- Add api_token column with encryption support
- Redesign settings panel: API token prominent, credentials collapsible
- Fix account balances display using performance endpoint portfolios
- Fix accounts index empty-state guard missing indexa_capital_items
- Simplify activities fetch job (no activities API endpoint exists)
- Fix i18n interpolation (%%{ -> %{) throughout locale file

* Add tests for Indexa Capital provider integration

- IndexaCapitalItemTest: validations, credentials, scopes, sync status
- IndexaCapitalAccountTest: upsert, holdings, account provider linking
- Provider::IndexaCapitalTest: auth modes, API stubs, error handling
- IndexaCapitalItemsControllerTest: CRUD, setup, linking, authorization
- Fixtures for items (token + credentials) and accounts (mutual + pension)

52 tests, 98 assertions, 0 failures

* Address code review feedback from PR #933

- Fix zero balance bug: use `nil?` instead of `present?` so 0 is stored
- Fix has_indexa_capital_credentials? to check api_token (was ignored)
- Fix build_provider to delegate to Provided concern (was ignoring token)
- Fix IndexaCapital section outside encryption_error guard in settings
- Add account_number sanitization to prevent path traversal in API URLs
- Replace all skipped processor tests with real working tests
- Add zero-balance and path-traversal test coverage

61 tests, 107 assertions, 0 failures

* Address code review round 2: credentials validation, RuboCop, test quality

- Fix RuboCop SpaceInsideArrayLiteralBrackets in credentials check
- Chain where.not calls so all three username/document/password must be present
- Require all three credentials (||) instead of any one (&&) in validate_configuration!
- Move attr_reader to private to avoid exposing credentials publicly
- Parse dates with Date.parse in extract_balance for robustness
- Remove stale TODO and Crypto from supported_account_types
- Order build_provider query deterministically by created_at
- Replace no-op holdings assertion with meaningful assert_difference

* Address code review round 3: JSON parse safety and test precision

- Rescue JSON::ParserError on 2xx responses for clearer error messages
- Fix weak balance assertion: set balance to 0 before processing, assert
  expected value (27093.01 = sum of holdings amounts)

* Include Indexa Capital in automatic family sync

Add indexa_capital_items to Family::Syncer#child_syncables so balances
and holdings refresh on daily auto-sync and login sync, not only on
manual sync button clicks.

---------

Signed-off-by: Juan José Mata <juanjo.mata@gmail.com>
Co-authored-by: Juan José Mata <jjmata@jjmata.com>
Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
2026-02-08 18:19:37 +01:00

131 lines
4.4 KiB
Ruby

# frozen_string_literal: true
class IndexaCapitalAccount::HoldingsProcessor
include IndexaCapitalAccount::DataHelpers
def initialize(indexa_capital_account)
@indexa_capital_account = indexa_capital_account
end
def process
return unless account.present?
holdings_data = @indexa_capital_account.raw_holdings_payload
return if holdings_data.blank?
Rails.logger.info "IndexaCapitalAccount::HoldingsProcessor - Processing #{holdings_data.size} holdings"
holdings_data.each_with_index do |holding_data, idx|
Rails.logger.info "IndexaCapitalAccount::HoldingsProcessor - Processing holding #{idx + 1}/#{holdings_data.size}"
process_holding(holding_data.with_indifferent_access)
rescue => e
Rails.logger.error "IndexaCapitalAccount::HoldingsProcessor - Failed to process holding #{idx + 1}: #{e.class} - #{e.message}"
Rails.logger.error e.backtrace.first(5).join("\n") if e.backtrace
end
end
private
def account
@indexa_capital_account.current_account
end
def import_adapter
@import_adapter ||= Account::ProviderImportAdapter.new(account)
end
# Indexa Capital fiscal-results field mapping:
# instrument.identifier (ISIN) → ticker
# instrument.name → security name
# titles → quantity (number of shares/units)
# price → current price per unit
# amount → total market value
# cost_price → average purchase price (cost basis per unit)
# cost_amount → total cost basis
# profit_loss → unrealized P&L
# subscription_date → purchase date
def process_holding(data)
ticker = extract_ticker(data)
return if ticker.blank?
Rails.logger.info "IndexaCapitalAccount::HoldingsProcessor - Processing holding for ticker: #{ticker}"
security = resolve_security(ticker, data)
return unless security
quantity = parse_decimal(data[:titles]) || parse_decimal(data[:quantity]) || parse_decimal(data[:units])
price = parse_decimal(data[:price])
return if quantity.nil? || price.nil?
amount = parse_decimal(data[:amount]) || (quantity * price)
currency = "EUR" # Indexa Capital is EUR-only
holding_date = Date.current
Rails.logger.info "IndexaCapitalAccount::HoldingsProcessor - Importing holding: #{ticker} qty=#{quantity} price=#{price} currency=#{currency}"
import_adapter.import_holding(
security: security,
quantity: quantity,
amount: amount,
currency: currency,
date: holding_date,
price: price,
account_provider_id: @indexa_capital_account.account_provider&.id,
source: "indexa_capital",
delete_future_holdings: false
)
# Store cost basis from cost_price (average purchase price per unit)
cost_price = parse_decimal(data[:cost_price])
update_holding_cost_basis(security, cost_price) if cost_price.present?
end
# Extract ISIN from instrument data as ticker
def extract_ticker(data)
# Indexa Capital uses ISIN codes nested under instrument
instrument = data[:instrument]
if instrument.is_a?(Hash)
instrument = instrument.with_indifferent_access
return instrument[:identifier] || instrument[:isin]
end
# Fallback to flat fields
data[:isin] || data[:identifier] || data[:symbol] || data[:ticker]
end
# Override security name extraction for Indexa Capital
def extract_security_name(symbol_data, fallback_ticker)
symbol_data = symbol_data.with_indifferent_access if symbol_data.respond_to?(:with_indifferent_access)
instrument = symbol_data[:instrument]
if instrument.is_a?(Hash)
instrument = instrument.with_indifferent_access
name = instrument[:name] || instrument[:description]
return name if name.present?
end
name = symbol_data[:name] || symbol_data[:description]
return fallback_ticker if name.blank? || name.is_a?(Hash)
name
end
def update_holding_cost_basis(security, cost_price)
holding = account.holdings
.where(security: security)
.where("cost_basis_source != 'manual' OR cost_basis_source IS NULL")
.order(date: :desc)
.first
return unless holding
cost_basis = parse_decimal(cost_price)
return if cost_basis.nil?
holding.update!(
cost_basis: cost_basis,
cost_basis_source: "provider"
)
end
end