mirror of
https://github.com/we-promise/sure.git
synced 2026-04-14 09:34:05 +00:00
ba442d5f26
* Add Indexa Capital provider scaffold
Generate Indexa Capital provider scaffolding and align credential fields with the API authentication requirements.
* Fix PR 926 lint and schema CI failures
* Implement Indexa Capital provider with real API integration
- Rewrite all broken view templates (were meta-ERB from code generator)
- Create missing select_accounts.html.erb template
- Implement real API calls: list_accounts via /users/me, get_holdings
via /accounts/{number}/fiscal-results, get_account_balance via
/accounts/{number}/performance
- Add API token auth support (stored token > env token > credentials)
- Add api_token column with encryption support
- Redesign settings panel: API token prominent, credentials collapsible
- Fix account balances display using performance endpoint portfolios
- Fix accounts index empty-state guard missing indexa_capital_items
- Simplify activities fetch job (no activities API endpoint exists)
- Fix i18n interpolation (%%{ -> %{) throughout locale file
* Add tests for Indexa Capital provider integration
- IndexaCapitalItemTest: validations, credentials, scopes, sync status
- IndexaCapitalAccountTest: upsert, holdings, account provider linking
- Provider::IndexaCapitalTest: auth modes, API stubs, error handling
- IndexaCapitalItemsControllerTest: CRUD, setup, linking, authorization
- Fixtures for items (token + credentials) and accounts (mutual + pension)
52 tests, 98 assertions, 0 failures
* Address code review feedback from PR #933
- Fix zero balance bug: use `nil?` instead of `present?` so 0 is stored
- Fix has_indexa_capital_credentials? to check api_token (was ignored)
- Fix build_provider to delegate to Provided concern (was ignoring token)
- Fix IndexaCapital section outside encryption_error guard in settings
- Add account_number sanitization to prevent path traversal in API URLs
- Replace all skipped processor tests with real working tests
- Add zero-balance and path-traversal test coverage
61 tests, 107 assertions, 0 failures
* Address code review round 2: credentials validation, RuboCop, test quality
- Fix RuboCop SpaceInsideArrayLiteralBrackets in credentials check
- Chain where.not calls so all three username/document/password must be present
- Require all three credentials (||) instead of any one (&&) in validate_configuration!
- Move attr_reader to private to avoid exposing credentials publicly
- Parse dates with Date.parse in extract_balance for robustness
- Remove stale TODO and Crypto from supported_account_types
- Order build_provider query deterministically by created_at
- Replace no-op holdings assertion with meaningful assert_difference
* Address code review round 3: JSON parse safety and test precision
- Rescue JSON::ParserError on 2xx responses for clearer error messages
- Fix weak balance assertion: set balance to 0 before processing, assert
expected value (27093.01 = sum of holdings amounts)
* Include Indexa Capital in automatic family sync
Add indexa_capital_items to Family::Syncer#child_syncables so balances
and holdings refresh on daily auto-sync and login sync, not only on
manual sync button clicks.
---------
Signed-off-by: Juan José Mata <juanjo.mata@gmail.com>
Co-authored-by: Juan José Mata <jjmata@jjmata.com>
Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
87 lines
3.3 KiB
Ruby
87 lines
3.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class IndexaCapitalItem::Syncer
|
|
include SyncStats::Collector
|
|
|
|
attr_reader :indexa_capital_item
|
|
|
|
def initialize(indexa_capital_item)
|
|
@indexa_capital_item = indexa_capital_item
|
|
end
|
|
|
|
def perform_sync(sync)
|
|
Rails.logger.info "IndexaCapitalItem::Syncer - Starting sync for item #{indexa_capital_item.id}"
|
|
|
|
# Phase 1: Import data from provider API
|
|
sync.update!(status_text: I18n.t("indexa_capital_items.sync.status.importing")) if sync.respond_to?(:status_text)
|
|
indexa_capital_item.import_latest_indexa_capital_data(sync: sync)
|
|
|
|
# Phase 2: Collect setup statistics
|
|
finalize_setup_counts(sync)
|
|
|
|
# Phase 3: Process data for linked accounts
|
|
linked_indexa_capital_accounts = indexa_capital_item.linked_indexa_capital_accounts.includes(account_provider: :account)
|
|
if linked_indexa_capital_accounts.any?
|
|
sync.update!(status_text: I18n.t("indexa_capital_items.sync.status.processing")) if sync.respond_to?(:status_text)
|
|
mark_import_started(sync)
|
|
indexa_capital_item.process_accounts
|
|
|
|
# Phase 4: Schedule balance calculations
|
|
sync.update!(status_text: I18n.t("indexa_capital_items.sync.status.calculating")) if sync.respond_to?(:status_text)
|
|
indexa_capital_item.schedule_account_syncs(
|
|
parent_sync: sync,
|
|
window_start_date: sync.window_start_date,
|
|
window_end_date: sync.window_end_date
|
|
)
|
|
|
|
# Phase 5: Collect statistics
|
|
account_ids = linked_indexa_capital_accounts.filter_map { |pa| pa.current_account&.id }
|
|
collect_transaction_stats(sync, account_ids: account_ids, source: "indexa_capital")
|
|
collect_trades_stats(sync, account_ids: account_ids, source: "indexa_capital")
|
|
collect_holdings_stats(sync, holdings_count: count_holdings, label: "processed")
|
|
end
|
|
|
|
# Mark sync health
|
|
collect_health_stats(sync, errors: nil)
|
|
rescue Provider::IndexaCapital::AuthenticationError => e
|
|
indexa_capital_item.update!(status: :requires_update)
|
|
collect_health_stats(sync, errors: [ { message: e.message, category: "auth_error" } ])
|
|
raise
|
|
rescue => e
|
|
collect_health_stats(sync, errors: [ { message: e.message, category: "sync_error" } ])
|
|
raise
|
|
end
|
|
|
|
# Public: called by Sync after finalization
|
|
def perform_post_sync
|
|
# Override for post-sync cleanup if needed
|
|
end
|
|
|
|
private
|
|
|
|
def count_holdings
|
|
indexa_capital_item.linked_indexa_capital_accounts.sum { |pa| Array(pa.raw_holdings_payload).size }
|
|
end
|
|
|
|
def mark_import_started(sync)
|
|
# Mark that we're now processing imported data
|
|
sync.update!(status_text: I18n.t("indexa_capital_items.sync.status.importing_data")) if sync.respond_to?(:status_text)
|
|
end
|
|
|
|
def finalize_setup_counts(sync)
|
|
sync.update!(status_text: I18n.t("indexa_capital_items.sync.status.checking_setup")) if sync.respond_to?(:status_text)
|
|
|
|
unlinked_count = indexa_capital_item.unlinked_accounts_count
|
|
|
|
if unlinked_count > 0
|
|
indexa_capital_item.update!(pending_account_setup: true)
|
|
sync.update!(status_text: I18n.t("indexa_capital_items.sync.status.needs_setup", count: unlinked_count)) if sync.respond_to?(:status_text)
|
|
else
|
|
indexa_capital_item.update!(pending_account_setup: false)
|
|
end
|
|
|
|
# Collect setup stats
|
|
collect_setup_stats(sync, provider_accounts: indexa_capital_item.indexa_capital_accounts)
|
|
end
|
|
end
|