mirror of
https://github.com/we-promise/sure.git
synced 2026-04-08 14:54:49 +00:00
* Introduce SnapTrade integration with models, migrations, views, and activity processing logic. * Refactor SnapTrade activities processing: improve activity fetching flow, handle pending states, and update UI elements for enhanced user feedback. * Update Brakeman ignore file to include intentional redirect for SnapTrade OAuth portal. * Refactor SnapTrade models, views, and processing logic: add currency extraction helper, improve pending state handling, optimize migration checks, and enhance user feedback in UI. * Remove encryption for SnapTrade `snaptrade_user_id`, as it is an identifier, not a secret. * Introduce `SnaptradeConnectionCleanupJob` to asynchronously handle SnapTrade connection cleanup and improve i18n for SnapTrade item status messages. * Update SnapTrade encryption: make `snaptrade_user_secret` non-deterministic to enhance security. --------- Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: luckyPipewrench <luckypipewrench@proton.me> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
136 lines
4.8 KiB
Ruby
136 lines
4.8 KiB
Ruby
class SnaptradeAccount::HoldingsProcessor
|
|
include SnaptradeAccount::DataHelpers
|
|
|
|
def initialize(snaptrade_account)
|
|
@snaptrade_account = snaptrade_account
|
|
end
|
|
|
|
def process
|
|
return unless account.present?
|
|
|
|
holdings_data = @snaptrade_account.raw_holdings_payload
|
|
return if holdings_data.blank?
|
|
|
|
Rails.logger.info "SnaptradeAccount::HoldingsProcessor - Processing #{holdings_data.size} holdings"
|
|
|
|
# Log sample of first holding to understand structure
|
|
if holdings_data.first
|
|
sample = holdings_data.first
|
|
Rails.logger.info "SnaptradeAccount::HoldingsProcessor - Sample holding keys: #{sample.keys.first(10).join(', ')}"
|
|
if sample["symbol"] || sample[:symbol]
|
|
symbol_sample = sample["symbol"] || sample[:symbol]
|
|
Rails.logger.info "SnaptradeAccount::HoldingsProcessor - Symbol data keys: #{symbol_sample.keys.first(10).join(', ')}" if symbol_sample.is_a?(Hash)
|
|
end
|
|
end
|
|
|
|
holdings_data.each_with_index do |holding_data, idx|
|
|
Rails.logger.info "SnaptradeAccount::HoldingsProcessor - Processing holding #{idx + 1}/#{holdings_data.size}"
|
|
process_holding(holding_data.with_indifferent_access)
|
|
rescue => e
|
|
Rails.logger.error "SnaptradeAccount::HoldingsProcessor - Failed to process holding #{idx + 1}: #{e.class} - #{e.message}"
|
|
Rails.logger.error e.backtrace.first(5).join("\n") if e.backtrace
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def account
|
|
@snaptrade_account.current_account
|
|
end
|
|
|
|
def import_adapter
|
|
@import_adapter ||= Account::ProviderImportAdapter.new(account)
|
|
end
|
|
|
|
def process_holding(data)
|
|
# Extract security info from the holding
|
|
# SnapTrade has DEEPLY NESTED structure:
|
|
# holding.symbol.symbol.symbol = ticker (e.g., "TSLA")
|
|
# holding.symbol.symbol.description = name (e.g., "Tesla Inc")
|
|
raw_symbol_wrapper = data["symbol"] || data[:symbol] || {}
|
|
symbol_wrapper = raw_symbol_wrapper.is_a?(Hash) ? raw_symbol_wrapper.with_indifferent_access : {}
|
|
|
|
# The actual security data is nested inside symbol.symbol
|
|
raw_symbol_data = symbol_wrapper["symbol"] || symbol_wrapper[:symbol] || {}
|
|
symbol_data = raw_symbol_data.is_a?(Hash) ? raw_symbol_data.with_indifferent_access : {}
|
|
|
|
# Get the ticker - it's at symbol.symbol.symbol
|
|
ticker = symbol_data["symbol"] || symbol_data[:symbol]
|
|
|
|
# If that's still a hash, we need to go deeper or use raw_symbol
|
|
if ticker.is_a?(Hash)
|
|
ticker = symbol_data["raw_symbol"] || symbol_data[:raw_symbol]
|
|
end
|
|
|
|
return if ticker.blank?
|
|
|
|
Rails.logger.info "SnaptradeAccount::HoldingsProcessor - Processing holding for ticker: #{ticker}"
|
|
|
|
# Resolve or create the security
|
|
security = resolve_security(ticker, symbol_data)
|
|
return unless security
|
|
|
|
# Parse values
|
|
quantity = parse_decimal(data["units"] || data[:units])
|
|
price = parse_decimal(data["price"] || data[:price])
|
|
return if quantity.nil? || price.nil?
|
|
|
|
# Calculate amount
|
|
amount = quantity * price
|
|
|
|
# Get the holding date (use current date if not provided)
|
|
holding_date = Date.current
|
|
|
|
# Extract currency - it can be at the holding level or in symbol_data
|
|
currency_data = data["currency"] || data[:currency] || symbol_data["currency"] || symbol_data[:currency]
|
|
currency = if currency_data.is_a?(Hash)
|
|
currency_data.with_indifferent_access["code"]
|
|
elsif currency_data.is_a?(String)
|
|
currency_data
|
|
else
|
|
account.currency
|
|
end
|
|
|
|
Rails.logger.info "SnaptradeAccount::HoldingsProcessor - Importing holding: #{ticker} qty=#{quantity} price=#{price} currency=#{currency}"
|
|
|
|
# Import the holding via the adapter
|
|
import_adapter.import_holding(
|
|
security: security,
|
|
quantity: quantity,
|
|
amount: amount,
|
|
currency: currency,
|
|
date: holding_date,
|
|
price: price,
|
|
account_provider_id: @snaptrade_account.account_provider&.id,
|
|
source: "snaptrade",
|
|
delete_future_holdings: false
|
|
)
|
|
|
|
# Store cost basis if available
|
|
avg_price = data["average_purchase_price"] || data[:average_purchase_price]
|
|
if avg_price.present?
|
|
update_holding_cost_basis(security, avg_price)
|
|
end
|
|
end
|
|
|
|
def update_holding_cost_basis(security, avg_cost)
|
|
# Find the most recent holding and update cost basis if not locked
|
|
holding = account.holdings
|
|
.where(security: security)
|
|
.where("cost_basis_source != 'manual' OR cost_basis_source IS NULL")
|
|
.order(date: :desc)
|
|
.first
|
|
|
|
return unless holding
|
|
|
|
# Store per-share cost, not total cost (cost_basis is per-share across the codebase)
|
|
cost_basis = parse_decimal(avg_cost)
|
|
return if cost_basis.nil?
|
|
|
|
holding.update!(
|
|
cost_basis: cost_basis,
|
|
cost_basis_source: "provider"
|
|
)
|
|
end
|
|
end
|