mirror of
https://github.com/we-promise/sure.git
synced 2026-04-13 00:57:22 +00:00
ba442d5f26
* Add Indexa Capital provider scaffold
Generate Indexa Capital provider scaffolding and align credential fields with the API authentication requirements.
* Fix PR 926 lint and schema CI failures
* Implement Indexa Capital provider with real API integration
- Rewrite all broken view templates (were meta-ERB from code generator)
- Create missing select_accounts.html.erb template
- Implement real API calls: list_accounts via /users/me, get_holdings
via /accounts/{number}/fiscal-results, get_account_balance via
/accounts/{number}/performance
- Add API token auth support (stored token > env token > credentials)
- Add api_token column with encryption support
- Redesign settings panel: API token prominent, credentials collapsible
- Fix account balances display using performance endpoint portfolios
- Fix accounts index empty-state guard missing indexa_capital_items
- Simplify activities fetch job (no activities API endpoint exists)
- Fix i18n interpolation (%%{ -> %{) throughout locale file
* Add tests for Indexa Capital provider integration
- IndexaCapitalItemTest: validations, credentials, scopes, sync status
- IndexaCapitalAccountTest: upsert, holdings, account provider linking
- Provider::IndexaCapitalTest: auth modes, API stubs, error handling
- IndexaCapitalItemsControllerTest: CRUD, setup, linking, authorization
- Fixtures for items (token + credentials) and accounts (mutual + pension)
52 tests, 98 assertions, 0 failures
* Address code review feedback from PR #933
- Fix zero balance bug: use `nil?` instead of `present?` so 0 is stored
- Fix has_indexa_capital_credentials? to check api_token (was ignored)
- Fix build_provider to delegate to Provided concern (was ignoring token)
- Fix IndexaCapital section outside encryption_error guard in settings
- Add account_number sanitization to prevent path traversal in API URLs
- Replace all skipped processor tests with real working tests
- Add zero-balance and path-traversal test coverage
61 tests, 107 assertions, 0 failures
* Address code review round 2: credentials validation, RuboCop, test quality
- Fix RuboCop SpaceInsideArrayLiteralBrackets in credentials check
- Chain where.not calls so all three username/document/password must be present
- Require all three credentials (||) instead of any one (&&) in validate_configuration!
- Move attr_reader to private to avoid exposing credentials publicly
- Parse dates with Date.parse in extract_balance for robustness
- Remove stale TODO and Crypto from supported_account_types
- Order build_provider query deterministically by created_at
- Replace no-op holdings assertion with meaningful assert_difference
* Address code review round 3: JSON parse safety and test precision
- Rescue JSON::ParserError on 2xx responses for clearer error messages
- Fix weak balance assertion: set balance to 0 before processing, assert
expected value (27093.01 = sum of holdings amounts)
* Include Indexa Capital in automatic family sync
Add indexa_capital_items to Family::Syncer#child_syncables so balances
and holdings refresh on daily auto-sync and login sync, not only on
manual sync button clicks.
---------
Signed-off-by: Juan José Mata <juanjo.mata@gmail.com>
Co-authored-by: Juan José Mata <jjmata@jjmata.com>
Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
81 lines
3.5 KiB
Plaintext
81 lines
3.5 KiB
Plaintext
<% content_for :title, t("indexa_capital_items.select_accounts.title") %>
|
|
|
|
<%= render DS::Dialog.new do |dialog| %>
|
|
<% dialog.with_header(title: t("indexa_capital_items.select_accounts.title")) do %>
|
|
<div class="flex items-center gap-2">
|
|
<%= icon "trending-up", class: "text-primary" %>
|
|
<span class="text-primary"><%= t("indexa_capital_items.select_accounts.description", product_name: "Maybe") %></span>
|
|
</div>
|
|
<% end %>
|
|
|
|
<% dialog.with_body do %>
|
|
<% if @indexa_capital_accounts.blank? %>
|
|
<div class="text-center py-8">
|
|
<%= icon "alert-circle", class: "text-warning mx-auto mb-4", size: "lg" %>
|
|
<p class="text-secondary"><%= t("indexa_capital_items.select_accounts.no_accounts_found") %></p>
|
|
</div>
|
|
<div class="flex gap-3 justify-center">
|
|
<%= render DS::Link.new(
|
|
text: t("indexa_capital_items.select_accounts.cancel"),
|
|
variant: "secondary",
|
|
href: accounts_path,
|
|
frame: "_top"
|
|
) %>
|
|
</div>
|
|
<% else %>
|
|
<%= form_with url: link_accounts_indexa_capital_items_path,
|
|
method: :post,
|
|
data: {
|
|
controller: "loading-button",
|
|
action: "submit->loading-button#showLoading",
|
|
loading_button_loading_text_value: t("indexa_capital_items.loading.loading_message"),
|
|
turbo_frame: "_top"
|
|
} do |form| %>
|
|
<%= hidden_field_tag :accountable_type, @accountable_type %>
|
|
<%= hidden_field_tag :return_to, @return_to %>
|
|
|
|
<div class="space-y-4">
|
|
<% @indexa_capital_accounts.each do |indexa_capital_account| %>
|
|
<div class="border border-primary rounded-lg p-4 hover:bg-surface transition-colors">
|
|
<div class="flex items-center gap-3">
|
|
<input type="checkbox"
|
|
id="account_<%= indexa_capital_account.id %>"
|
|
name="selected_account_ids[]"
|
|
value="<%= indexa_capital_account.id %>"
|
|
checked
|
|
class="cursor-pointer">
|
|
<label for="account_<%= indexa_capital_account.id %>" class="flex-1 cursor-pointer">
|
|
<h4 class="font-medium text-primary"><%= indexa_capital_account.name.presence || t("indexa_capital_items.select_accounts.no_name_placeholder") %></h4>
|
|
<p class="text-sm text-secondary">
|
|
<% if indexa_capital_account.account_type.present? %>
|
|
<%= indexa_capital_account.account_type.titleize %> ·
|
|
<% end %>
|
|
<%= number_to_currency(indexa_capital_account.current_balance || 0, unit: Money::Currency.new(indexa_capital_account.currency || "EUR").symbol) %>
|
|
</p>
|
|
</label>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
</div>
|
|
|
|
<div class="flex gap-3 mt-6">
|
|
<%= render DS::Button.new(
|
|
text: t("indexa_capital_items.select_accounts.link_accounts"),
|
|
variant: "primary",
|
|
icon: "plus",
|
|
type: "submit",
|
|
class: "flex-1",
|
|
data: { loading_button_target: "button" }
|
|
) %>
|
|
<%= render DS::Link.new(
|
|
text: t("indexa_capital_items.select_accounts.cancel"),
|
|
variant: "secondary",
|
|
href: accounts_path,
|
|
frame: "_top"
|
|
) %>
|
|
</div>
|
|
<% end %>
|
|
<% end %>
|
|
<% end %>
|
|
<% end %>
|