mirror of
https://github.com/we-promise/sure.git
synced 2026-04-09 23:34:50 +00:00
ba442d5f26
* Add Indexa Capital provider scaffold
Generate Indexa Capital provider scaffolding and align credential fields with the API authentication requirements.
* Fix PR 926 lint and schema CI failures
* Implement Indexa Capital provider with real API integration
- Rewrite all broken view templates (were meta-ERB from code generator)
- Create missing select_accounts.html.erb template
- Implement real API calls: list_accounts via /users/me, get_holdings
via /accounts/{number}/fiscal-results, get_account_balance via
/accounts/{number}/performance
- Add API token auth support (stored token > env token > credentials)
- Add api_token column with encryption support
- Redesign settings panel: API token prominent, credentials collapsible
- Fix account balances display using performance endpoint portfolios
- Fix accounts index empty-state guard missing indexa_capital_items
- Simplify activities fetch job (no activities API endpoint exists)
- Fix i18n interpolation (%%{ -> %{) throughout locale file
* Add tests for Indexa Capital provider integration
- IndexaCapitalItemTest: validations, credentials, scopes, sync status
- IndexaCapitalAccountTest: upsert, holdings, account provider linking
- Provider::IndexaCapitalTest: auth modes, API stubs, error handling
- IndexaCapitalItemsControllerTest: CRUD, setup, linking, authorization
- Fixtures for items (token + credentials) and accounts (mutual + pension)
52 tests, 98 assertions, 0 failures
* Address code review feedback from PR #933
- Fix zero balance bug: use `nil?` instead of `present?` so 0 is stored
- Fix has_indexa_capital_credentials? to check api_token (was ignored)
- Fix build_provider to delegate to Provided concern (was ignoring token)
- Fix IndexaCapital section outside encryption_error guard in settings
- Add account_number sanitization to prevent path traversal in API URLs
- Replace all skipped processor tests with real working tests
- Add zero-balance and path-traversal test coverage
61 tests, 107 assertions, 0 failures
* Address code review round 2: credentials validation, RuboCop, test quality
- Fix RuboCop SpaceInsideArrayLiteralBrackets in credentials check
- Chain where.not calls so all three username/document/password must be present
- Require all three credentials (||) instead of any one (&&) in validate_configuration!
- Move attr_reader to private to avoid exposing credentials publicly
- Parse dates with Date.parse in extract_balance for robustness
- Remove stale TODO and Crypto from supported_account_types
- Order build_provider query deterministically by created_at
- Replace no-op holdings assertion with meaningful assert_difference
* Address code review round 3: JSON parse safety and test precision
- Rescue JSON::ParserError on 2xx responses for clearer error messages
- Fix weak balance assertion: set balance to 0 before processing, assert
expected value (27093.01 = sum of holdings amounts)
* Include Indexa Capital in automatic family sync
Add indexa_capital_items to Family::Syncer#child_syncables so balances
and holdings refresh on daily auto-sync and login sync, not only on
manual sync button clicks.
---------
Signed-off-by: Juan José Mata <juanjo.mata@gmail.com>
Co-authored-by: Juan José Mata <jjmata@jjmata.com>
Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
68 lines
3.1 KiB
Plaintext
68 lines
3.1 KiB
Plaintext
<% content_for :title, t("indexa_capital_items.select_existing_account.title", account_name: @account.name) %>
|
|
|
|
<%= render DS::Dialog.new do |dialog| %>
|
|
<% dialog.with_header(title: t("indexa_capital_items.select_existing_account.header")) do %>
|
|
<div class="flex items-center gap-2">
|
|
<%= icon "link", class: "text-primary" %>
|
|
<span class="text-primary"><%= t("indexa_capital_items.select_existing_account.subtitle", account_name: @account.name) %></span>
|
|
</div>
|
|
<% end %>
|
|
|
|
<% dialog.with_body do %>
|
|
<% if @indexa_capital_accounts.blank? %>
|
|
<div class="text-center py-8">
|
|
<%= icon "alert-circle", class: "text-warning mx-auto mb-4", size: "lg" %>
|
|
<p class="text-secondary"><%= t("indexa_capital_items.select_existing_account.no_accounts") %></p>
|
|
<p class="text-sm text-secondary mt-2"><%= t("indexa_capital_items.select_existing_account.connect_hint") %></p>
|
|
<%= link_to t("indexa_capital_items.select_existing_account.settings_link"), settings_providers_path, class: "btn btn--primary btn--sm mt-4" %>
|
|
</div>
|
|
<% else %>
|
|
<div class="space-y-4">
|
|
<div class="bg-surface border border-primary p-4 rounded-lg mb-4">
|
|
<p class="text-sm text-primary">
|
|
<strong><%= t("indexa_capital_items.select_existing_account.linking_to") %></strong>
|
|
<%= @account.name %>
|
|
</p>
|
|
</div>
|
|
|
|
<% @indexa_capital_accounts.each do |indexa_capital_account| %>
|
|
<%= form_with url: link_existing_account_indexa_capital_items_path,
|
|
method: :post,
|
|
local: true,
|
|
class: "border border-primary rounded-lg p-4 hover:bg-surface transition-colors" do |form| %>
|
|
<%= hidden_field_tag :account_id, @account.id %>
|
|
<%= hidden_field_tag :indexa_capital_account_id, indexa_capital_account.id %>
|
|
|
|
<div class="flex items-center justify-between">
|
|
<div>
|
|
<h4 class="font-medium text-primary"><%= indexa_capital_account.name %></h4>
|
|
<p class="text-sm text-secondary">
|
|
<% if indexa_capital_account.account_type.present? %>
|
|
<%= indexa_capital_account.account_type.titleize %> ·
|
|
<% end %>
|
|
<%= t("indexa_capital_items.select_existing_account.balance_label") %>
|
|
<%= number_to_currency(indexa_capital_account.current_balance || 0, unit: Money::Currency.new(indexa_capital_account.currency || "EUR").symbol) %>
|
|
</p>
|
|
</div>
|
|
<%= render DS::Button.new(
|
|
text: t("indexa_capital_items.select_existing_account.link_button"),
|
|
variant: "primary",
|
|
size: "sm",
|
|
type: "submit"
|
|
) %>
|
|
</div>
|
|
<% end %>
|
|
<% end %>
|
|
</div>
|
|
|
|
<div class="mt-6">
|
|
<%= render DS::Link.new(
|
|
text: t("indexa_capital_items.select_existing_account.cancel_button"),
|
|
variant: "secondary",
|
|
href: account_path(@account)
|
|
) %>
|
|
</div>
|
|
<% end %>
|
|
<% end %>
|
|
<% end %>
|