Files
sure/app/views/reports/_investment_flows.html.erb
LPW 0c2026680c Improve investment activity labels UX and add convert-to-trade feature (#649)
* Add `investment_activity_label` to trades and enhance activity label handling

- Introduced `investment_activity_label` column to the `trades` table with a migration.
- Backfilled existing `trades` with activity labels based on quantity (`Buy`, `Sell`, or `Other`).
- Replaced `category_id` in trades with `investment_activity_label` for better alignment with transaction labels.
- Updated views and controllers to display and manage activity labels for trades.
- Added localized badge components for displaying and editing labels dynamically.
- Enhanced `PlaidAccount::Investments::TransactionsProcessor` to assign and process activity labels automatically.
- Added investment flows section to reports for tracking contributions and withdrawals.
- Refactored related tests and models for consistency and to ensure proper validation and filtering.

* Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions

- Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature.
- Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers.
- Streamlined UI for trade and transaction forms by updating dropdown options and label text.
- Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility.
- Adjusted tests and views to align with updated workflows and ensure consistent behavior.

* Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions

- Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature.
- Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers.
- Streamlined UI for trade and transaction forms by updating dropdown options and label text.
- Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility.
- Adjusted tests and views to align with updated workflows and ensure consistent behavior.

* Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions

- Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature.
- Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers.
- Streamlined UI for trade and transaction forms by updating dropdown options and label text.
- Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility.
- Adjusted tests and views to align with updated workflows and ensure consistent behavior.

* Add safeguard for `dropdownTarget` existence in quick edit controller

- Prevent errors by ensuring `dropdownTarget` is present before toggling its visibility.

* Fix undefined method 'category' for Trade on mobile view

Trade model uses investment_activity_label, not category. The upstream
merge introduced a call to trade.category which doesn't exist. Use the
activity label badge on mobile instead.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Fix activity label logic for zero/blank quantity and sell inference

- Return `nil` for blank or zero quantity in `investment_activity_label_for`.
- Correct `is_sell` logic to use the amount’s sign properly in `transactions_controller`.

* Fix i18n key paths in transactions controller for convert_to_trade

- Update flash message translations to use full i18n paths.
- Use `BigDecimal` for quantity and price calculations to improve precision.

---------

Co-authored-by: Josh Waldrep <joshua.waldrep5+github@gmail.com>
Co-authored-by: luckyPipewrench <luckypipewrench@proton.me>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-16 21:04:10 +01:00

45 lines
1.8 KiB
Plaintext

<%# locals: (investment_flows:) %>
<div class="space-y-4">
<p class="text-sm text-secondary">
Track money flowing into and out of your investment accounts through contributions and withdrawals.
</p>
<div class="grid grid-cols-1 md:grid-cols-3 gap-4">
<!-- Contributions -->
<div class="bg-container border border-primary rounded-lg p-4">
<div class="flex items-center gap-2 mb-2">
<%= icon("trending-up", size: "sm", class: "text-green-600") %>
<h3 class="text-sm font-medium text-secondary">Contributions</h3>
</div>
<div class="text-2xl font-semibold" style="color: rgb(34 197 94);">
<%= format_money(investment_flows.contributions) %>
</div>
<p class="text-xs text-secondary mt-1">Money added to investments</p>
</div>
<!-- Withdrawals -->
<div class="bg-container border border-primary rounded-lg p-4">
<div class="flex items-center gap-2 mb-2">
<%= icon("trending-down", size: "sm", class: "text-orange-600") %>
<h3 class="text-sm font-medium text-secondary">Withdrawals</h3>
</div>
<div class="text-2xl font-semibold" style="color: rgb(249 115 22);">
<%= format_money(investment_flows.withdrawals) %>
</div>
<p class="text-xs text-secondary mt-1">Money withdrawn from investments</p>
</div>
<!-- Net Flow -->
<div class="bg-container border border-primary rounded-lg p-4">
<div class="flex items-center gap-2 mb-2">
<%= icon("arrow-right-left", size: "sm", class: "text-primary") %>
<h3 class="text-sm font-medium text-secondary">Net Flow</h3>
</div>
<div class="text-2xl font-semibold text-primary">
<%= format_money(investment_flows.net_flow) %>
</div>
<p class="text-xs text-secondary mt-1">Total net change</p>
</div>
</div>
</div>