mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 22:34:47 +00:00
* Add Polish locale support for money formatting
The Money::Formatting module handles locale-specific currency formatting
for French, German, Spanish, Italian, and Portuguese (Brazil), but was
missing support for Polish locale. This caused formatting issues when
users with Polish locale viewed account valuations.
- Add Polish locale handling to locale_options method
- Polish formatting uses: space as thousands delimiter, comma as
decimal separator, symbol after number ("%n %u" format)
- Add test coverage for Polish locale formatting
* Add locale support for all supported locales in Money::Formatting
Extend the Money::Formatting module to handle all locales from
SUPPORTED_LOCALES to prevent template errors when users select
different languages.
Added locale-specific formatting for:
- Turkish (tr): dot delimiter, comma separator, symbol after number
- Norwegian Bokmål (nb): space delimiter, comma separator, symbol after
- Catalan (ca): dot delimiter, comma separator, symbol after number
- Romanian (ro): dot delimiter, comma separator, symbol after number
- Dutch (nl): dot delimiter, comma separator, symbol before number
Also improved Dutch handling to work with all currencies (not just EUR).
Added comprehensive tests for:
- All newly supported locales
- Chinese (zh-CN, zh-TW) which use default English-style formatting
- A test that verifies all SUPPORTED_LOCALES can format without errors
* Fix broken money formatting tests
- Fix Chinese Traditional locale test: TWD currency uses "TW$" symbol
(prefixed with first 2 chars of ISO code to distinguish from USD)
- Fix all supported locales test: replace assert_nothing_raised (which
doesn't accept message argument in Minitest) with explicit assertions
* Refactor Money::Formatting to consolidate locale patterns
Group locales by their formatting patterns into constants to reduce
repetition and make it easier to add new locales:
- EUROPEAN_SYMBOL_AFTER: de, es, it, tr, ca, ro
(dot delimiter, comma separator, symbol after)
- SPACE_DELIMITER_SYMBOL_AFTER: pl, nb
(space delimiter, comma separator, symbol after)
- EUROPEAN_SYMBOL_BEFORE: nl, pt-BR
(dot delimiter, comma separator, symbol before)
French locale remains separate due to its unique non-breaking space usage.
---------
Co-authored-by: Claude <noreply@anthropic.com>
198 lines
7.5 KiB
Ruby
198 lines
7.5 KiB
Ruby
require "test_helper"
|
|
require "ostruct"
|
|
|
|
class MoneyTest < ActiveSupport::TestCase
|
|
test "can create with default currency" do
|
|
value = Money.new(1000)
|
|
assert_equal 1000, value.amount
|
|
end
|
|
|
|
test "can create with custom currency" do
|
|
value1 = Money.new(1000, :EUR)
|
|
value2 = Money.new(1000, :eur)
|
|
value3 = Money.new(1000, "eur")
|
|
value4 = Money.new(1000, "EUR")
|
|
|
|
assert_equal value1.currency.iso_code, value2.currency.iso_code
|
|
assert_equal value2.currency.iso_code, value3.currency.iso_code
|
|
assert_equal value3.currency.iso_code, value4.currency.iso_code
|
|
end
|
|
|
|
test "equality tests amount and currency" do
|
|
assert_equal Money.new(1000), Money.new(1000)
|
|
assert_not_equal Money.new(1000), Money.new(1001)
|
|
assert_not_equal Money.new(1000, :usd), Money.new(1000, :eur)
|
|
end
|
|
|
|
test "can compare with zero Numeric" do
|
|
assert_equal Money.new(0), 0
|
|
assert_raises(TypeError) { Money.new(1) == 1 }
|
|
end
|
|
|
|
test "can negate" do
|
|
assert_equal (-Money.new(1000)), Money.new(-1000)
|
|
end
|
|
|
|
test "can use comparison operators" do
|
|
assert_operator Money.new(1000), :>, Money.new(999)
|
|
assert_operator Money.new(1000), :>=, Money.new(1000)
|
|
assert_operator Money.new(1000), :<, Money.new(1001)
|
|
assert_operator Money.new(1000), :<=, Money.new(1000)
|
|
end
|
|
|
|
test "can add and subtract" do
|
|
assert_equal Money.new(1000) + Money.new(1000), Money.new(2000)
|
|
assert_equal Money.new(1000) + 1000, Money.new(2000)
|
|
assert_equal Money.new(1000) - Money.new(1000), Money.new(0)
|
|
assert_equal Money.new(1000) - 1000, Money.new(0)
|
|
end
|
|
|
|
test "can multiply" do
|
|
assert_equal Money.new(1000) * 2, Money.new(2000)
|
|
assert_raises(TypeError) { Money.new(1000) * Money.new(2) }
|
|
end
|
|
|
|
test "can divide" do
|
|
assert_equal Money.new(1000) / 2, Money.new(500)
|
|
assert_equal Money.new(1000) / Money.new(500), 2
|
|
assert_raise(TypeError) { 1000 / Money.new(2) }
|
|
end
|
|
|
|
test "operator order does not matter" do
|
|
assert_equal Money.new(1000) + 1000, 1000 + Money.new(1000)
|
|
assert_equal Money.new(1000) - 1000, 1000 - Money.new(1000)
|
|
assert_equal Money.new(1000) * 2, 2 * Money.new(1000)
|
|
end
|
|
|
|
test "can get absolute value" do
|
|
assert_equal Money.new(1000).abs, Money.new(1000)
|
|
assert_equal Money.new(-1000).abs, Money.new(1000)
|
|
end
|
|
|
|
test "can test if zero" do
|
|
assert Money.new(0).zero?
|
|
assert_not Money.new(1000).zero?
|
|
end
|
|
|
|
test "can test if negative" do
|
|
assert Money.new(-1000).negative?
|
|
assert_not Money.new(1000).negative?
|
|
end
|
|
|
|
test "can test if positive" do
|
|
assert Money.new(1000).positive?
|
|
assert_not Money.new(-1000).positive?
|
|
end
|
|
|
|
test "can format" do
|
|
assert_equal "$1,000.90", Money.new(1000.899).to_s
|
|
assert_equal "€1,000.12", Money.new(1000.12, :eur).to_s
|
|
assert_equal "€ 1.000,12", Money.new(1000.12, :eur).format(locale: :nl)
|
|
end
|
|
|
|
test "formats correctly for French locale" do
|
|
# French uses non-breaking spaces (NBSP = \u00A0) between thousands and before currency symbol
|
|
assert_equal "1\u00A0000,12\u00A0€", Money.new(1000.12, :eur).format(locale: :fr)
|
|
assert_equal "1\u00A0000,12\u00A0$", Money.new(1000.12, :usd).format(locale: :fr)
|
|
end
|
|
|
|
test "formats correctly for German locale" do
|
|
assert_equal "1.000,12 €", Money.new(1000.12, :eur).format(locale: :de)
|
|
assert_equal "1.000,12 $", Money.new(1000.12, :usd).format(locale: :de)
|
|
end
|
|
|
|
test "formats correctly for Spanish locale" do
|
|
assert_equal "1.000,12 €", Money.new(1000.12, :eur).format(locale: :es)
|
|
end
|
|
|
|
test "formats correctly for Italian locale" do
|
|
assert_equal "1.000,12 €", Money.new(1000.12, :eur).format(locale: :it)
|
|
end
|
|
|
|
test "formats correctly for Portuguese (Brazil) locale" do
|
|
assert_equal "R$ 1.000,12", Money.new(1000.12, :brl).format(locale: :"pt-BR")
|
|
end
|
|
|
|
test "formats correctly for Polish locale" do
|
|
# Polish uses space as thousands delimiter, comma as decimal separator, symbol after number
|
|
assert_equal "1 000,12 zł", Money.new(1000.12, :pln).format(locale: :pl)
|
|
assert_equal "1 000,12 €", Money.new(1000.12, :eur).format(locale: :pl)
|
|
end
|
|
|
|
test "formats correctly for Turkish locale" do
|
|
# Turkish uses dot as thousands delimiter, comma as decimal separator, symbol after number
|
|
assert_equal "1.000,12 ₺", Money.new(1000.12, :try).format(locale: :tr)
|
|
assert_equal "1.000,12 €", Money.new(1000.12, :eur).format(locale: :tr)
|
|
end
|
|
|
|
test "formats correctly for Norwegian Bokmål locale" do
|
|
# Norwegian uses space as thousands delimiter, comma as decimal separator, symbol after number
|
|
assert_equal "1 000,12 kr", Money.new(1000.12, :nok).format(locale: :nb)
|
|
assert_equal "1 000,12 €", Money.new(1000.12, :eur).format(locale: :nb)
|
|
end
|
|
|
|
test "formats correctly for Catalan locale" do
|
|
# Catalan uses dot as thousands delimiter, comma as decimal separator, symbol after number
|
|
assert_equal "1.000,12 €", Money.new(1000.12, :eur).format(locale: :ca)
|
|
end
|
|
|
|
test "formats correctly for Romanian locale" do
|
|
# Romanian uses dot as thousands delimiter, comma as decimal separator, symbol after number
|
|
assert_equal "1.000,12 Lei", Money.new(1000.12, :ron).format(locale: :ro)
|
|
assert_equal "1.000,12 €", Money.new(1000.12, :eur).format(locale: :ro)
|
|
end
|
|
|
|
test "formats correctly for Dutch locale" do
|
|
# Dutch uses dot as thousands delimiter, comma as decimal separator, symbol before number
|
|
assert_equal "€ 1.000,12", Money.new(1000.12, :eur).format(locale: :nl)
|
|
assert_equal "$ 1.000,12", Money.new(1000.12, :usd).format(locale: :nl)
|
|
end
|
|
|
|
test "formats correctly for Chinese Simplified locale" do
|
|
# Chinese Simplified uses English-style formatting (comma as thousands delimiter, dot as decimal separator)
|
|
assert_equal "¥1,000.12", Money.new(1000.12, :cny).format(locale: :"zh-CN")
|
|
end
|
|
|
|
test "formats correctly for Chinese Traditional locale" do
|
|
# Chinese Traditional uses English-style formatting (comma as thousands delimiter, dot as decimal separator)
|
|
# TWD symbol is prefixed with "TW" to distinguish from other dollar currencies
|
|
assert_equal "TW$1,000.12", Money.new(1000.12, :twd).format(locale: :"zh-TW")
|
|
end
|
|
|
|
test "all supported locales can format money without errors" do
|
|
# Ensure all supported locales from LanguagesHelper::SUPPORTED_LOCALES work
|
|
supported_locales = %w[en fr de es tr nb ca ro pt-BR zh-CN zh-TW nl]
|
|
|
|
supported_locales.each do |locale|
|
|
locale_sym = locale.to_sym
|
|
# Format with USD and EUR to ensure locale handling works for different currencies
|
|
result_usd = Money.new(1000.12, :usd).format(locale: locale_sym)
|
|
result_eur = Money.new(1000.12, :eur).format(locale: locale_sym)
|
|
|
|
assert result_usd.present?, "Locale #{locale} should format USD without errors"
|
|
assert result_eur.present?, "Locale #{locale} should format EUR without errors"
|
|
end
|
|
end
|
|
|
|
test "converts currency when rate available" do
|
|
ExchangeRate.expects(:find_or_fetch_rate).returns(OpenStruct.new(rate: 1.2))
|
|
|
|
assert_equal Money.new(1000).exchange_to(:eur), Money.new(1000 * 1.2, :eur)
|
|
end
|
|
|
|
test "raises when no conversion rate available and no fallback rate provided" do
|
|
ExchangeRate.expects(:find_or_fetch_rate).returns(nil)
|
|
|
|
assert_raises Money::ConversionError do
|
|
Money.new(1000).exchange_to(:jpy)
|
|
end
|
|
end
|
|
|
|
test "converts currency with a fallback rate" do
|
|
ExchangeRate.expects(:find_or_fetch_rate).returns(nil).twice
|
|
|
|
assert_equal 0, Money.new(1000).exchange_to(:jpy, fallback_rate: 0)
|
|
assert_equal Money.new(1000, :jpy), Money.new(1000, :usd).exchange_to(:jpy, fallback_rate: 1)
|
|
end
|
|
end
|