mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 22:34:47 +00:00
9e57954a99
* Add SearchFamilyImportedFiles assistant function with vector store support Implement per-Family document search using OpenAI vector stores, allowing the AI assistant to search through uploaded financial documents (tax returns, statements, contracts, etc.). The architecture is modular with a provider- agnostic VectorStoreConcept interface so other RAG backends can be added. Key components: - Assistant::Function::SearchFamilyImportedFiles - tool callable from any LLM - Provider::VectorStoreConcept - abstract vector store interface - Provider::Openai vector store methods (create, upload, search, delete) - Family::VectorSearchable concern with document management - FamilyDocument model for tracking uploaded files - Migration adding vector_store_id to families and family_documents table https://claude.ai/code/session_01TSkKc7a9Yu2ugm1RvSf4dh * Extract VectorStore adapter layer for swappable backends Replace the Provider::VectorStoreConcept mixin with a standalone adapter architecture under VectorStore::. This cleanly separates vector store concerns from the LLM provider and makes it trivial to swap backends. Components: - VectorStore::Base — abstract interface (create/delete/upload/remove/search) - VectorStore::Openai — uses ruby-openai gem's native vector_stores.search - VectorStore::Pgvector — skeleton for local pgvector + embedding model - VectorStore::Qdrant — skeleton for Qdrant vector DB - VectorStore::Registry — resolves adapter from VECTOR_STORE_PROVIDER env - VectorStore::Response — success/failure wrapper (like Provider::Response) Consumers updated to go through VectorStore.adapter: - Family::VectorSearchable - Assistant::Function::SearchFamilyImportedFiles - FamilyDocument Removed: Provider::VectorStoreConcept, vector store methods from Provider::Openai https://claude.ai/code/session_01TSkKc7a9Yu2ugm1RvSf4dh * Add Vector Store configuration docs to ai.md Documents how to configure the document search feature, covering all three supported backends (OpenAI, pgvector, Qdrant), environment variables, Docker Compose examples, supported file types, and privacy considerations. https://claude.ai/code/session_01TSkKc7a9Yu2ugm1RvSf4dh * No need to specify `imported` in code * Missed a couple more places * Tiny reordering for the human OCD * Update app/models/assistant/function/search_family_files.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Juan José Mata <jjmata@jjmata.com> * PR comments * More PR comments --------- Signed-off-by: Juan José Mata <jjmata@jjmata.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
54 lines
1.9 KiB
Ruby
54 lines
1.9 KiB
Ruby
require "test_helper"
|
|
|
|
class VectorStore::RegistryTest < ActiveSupport::TestCase
|
|
test "adapter_name defaults to openai when access token present" do
|
|
VectorStore::Registry.stubs(:openai_access_token).returns("sk-test")
|
|
ClimateControl.modify(VECTOR_STORE_PROVIDER: nil) do
|
|
assert_equal :openai, VectorStore::Registry.adapter_name
|
|
end
|
|
end
|
|
|
|
test "adapter_name returns nil when no credentials configured" do
|
|
VectorStore::Registry.stubs(:openai_access_token).returns(nil)
|
|
ClimateControl.modify(VECTOR_STORE_PROVIDER: nil) do
|
|
assert_nil VectorStore::Registry.adapter_name
|
|
end
|
|
end
|
|
|
|
test "adapter_name respects explicit VECTOR_STORE_PROVIDER" do
|
|
ClimateControl.modify(VECTOR_STORE_PROVIDER: "qdrant") do
|
|
assert_equal :qdrant, VectorStore::Registry.adapter_name
|
|
end
|
|
end
|
|
|
|
test "adapter_name falls back to openai for unknown provider" do
|
|
VectorStore::Registry.stubs(:openai_access_token).returns("sk-test")
|
|
ClimateControl.modify(VECTOR_STORE_PROVIDER: "unknown_store") do
|
|
assert_equal :openai, VectorStore::Registry.adapter_name
|
|
end
|
|
end
|
|
|
|
test "adapter returns VectorStore::Openai instance when openai configured" do
|
|
VectorStore::Registry.stubs(:openai_access_token).returns("sk-test")
|
|
ClimateControl.modify(VECTOR_STORE_PROVIDER: nil) do
|
|
adapter = VectorStore::Registry.adapter
|
|
assert_instance_of VectorStore::Openai, adapter
|
|
end
|
|
end
|
|
|
|
test "adapter returns nil when nothing configured" do
|
|
VectorStore::Registry.stubs(:openai_access_token).returns(nil)
|
|
ClimateControl.modify(VECTOR_STORE_PROVIDER: nil) do
|
|
assert_nil VectorStore::Registry.adapter
|
|
end
|
|
end
|
|
|
|
test "configured? delegates to adapter presence" do
|
|
VectorStore::Registry.stubs(:adapter).returns(nil)
|
|
assert_not VectorStore.configured?
|
|
|
|
VectorStore::Registry.stubs(:adapter).returns(VectorStore::Openai.new(access_token: "sk-test"))
|
|
assert VectorStore.configured?
|
|
end
|
|
end
|