mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 22:34:47 +00:00
* Add `investment_activity_label` to trades and enhance activity label handling - Introduced `investment_activity_label` column to the `trades` table with a migration. - Backfilled existing `trades` with activity labels based on quantity (`Buy`, `Sell`, or `Other`). - Replaced `category_id` in trades with `investment_activity_label` for better alignment with transaction labels. - Updated views and controllers to display and manage activity labels for trades. - Added localized badge components for displaying and editing labels dynamically. - Enhanced `PlaidAccount::Investments::TransactionsProcessor` to assign and process activity labels automatically. - Added investment flows section to reports for tracking contributions and withdrawals. - Refactored related tests and models for consistency and to ensure proper validation and filtering. * Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions - Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature. - Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers. - Streamlined UI for trade and transaction forms by updating dropdown options and label text. - Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility. - Adjusted tests and views to align with updated workflows and ensure consistent behavior. * Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions - Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature. - Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers. - Streamlined UI for trade and transaction forms by updating dropdown options and label text. - Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility. - Adjusted tests and views to align with updated workflows and ensure consistent behavior. * Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions - Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature. - Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers. - Streamlined UI for trade and transaction forms by updating dropdown options and label text. - Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility. - Adjusted tests and views to align with updated workflows and ensure consistent behavior. * Add safeguard for `dropdownTarget` existence in quick edit controller - Prevent errors by ensuring `dropdownTarget` is present before toggling its visibility. * Fix undefined method 'category' for Trade on mobile view Trade model uses investment_activity_label, not category. The upstream merge introduced a call to trade.category which doesn't exist. Use the activity label badge on mobile instead. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Fix activity label logic for zero/blank quantity and sell inference - Return `nil` for blank or zero quantity in `investment_activity_label_for`. - Correct `is_sell` logic to use the amount’s sign properly in `transactions_controller`. * Fix i18n key paths in transactions controller for convert_to_trade - Update flash message translations to use full i18n paths. - Use `BigDecimal` for quantity and price calculations to improve precision. --------- Co-authored-by: Josh Waldrep <joshua.waldrep5+github@gmail.com> Co-authored-by: luckyPipewrench <luckypipewrench@proton.me> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
84 lines
2.3 KiB
Ruby
84 lines
2.3 KiB
Ruby
module EntriesTestHelper
|
|
def create_transaction(attributes = {})
|
|
entry_attributes = attributes.except(:category, :tags, :merchant, :kind)
|
|
transaction_attributes = attributes.slice(:category, :tags, :merchant, :kind)
|
|
|
|
entry_defaults = {
|
|
account: accounts(:depository),
|
|
name: "Transaction",
|
|
date: Date.current,
|
|
currency: "USD",
|
|
amount: 100,
|
|
entryable: Transaction.new(transaction_attributes)
|
|
}
|
|
|
|
Entry.create! entry_defaults.merge(entry_attributes)
|
|
end
|
|
|
|
def create_valuation(attributes = {})
|
|
entry_attributes = attributes.except(:kind)
|
|
valuation_attributes = attributes.slice(:kind)
|
|
|
|
account = attributes[:account] || accounts(:depository)
|
|
amount = attributes[:amount] || 5000
|
|
|
|
entry_defaults = {
|
|
account: account,
|
|
name: "Valuation",
|
|
date: 1.day.ago.to_date,
|
|
currency: "USD",
|
|
amount: amount,
|
|
entryable: Valuation.new({ kind: "reconciliation" }.merge(valuation_attributes))
|
|
}
|
|
|
|
Entry.create! entry_defaults.merge(entry_attributes)
|
|
end
|
|
|
|
def create_trade(security, account:, qty:, date:, price: nil, currency: "USD")
|
|
trade_price = price || Security::Price.find_by!(security: security, date: date).price
|
|
|
|
trade = Trade.new \
|
|
qty: qty,
|
|
security: security,
|
|
price: trade_price,
|
|
currency: currency,
|
|
investment_activity_label: qty > 0 ? "Buy" : "Sell"
|
|
|
|
account.entries.create! \
|
|
name: "Trade",
|
|
date: date,
|
|
amount: qty * trade_price,
|
|
currency: currency,
|
|
entryable: trade
|
|
end
|
|
|
|
def create_transfer(from_account:, to_account:, amount:, date: Date.current, currency: "USD")
|
|
outflow_transaction = Transaction.create!(kind: "funds_movement")
|
|
inflow_transaction = Transaction.create!(kind: "funds_movement")
|
|
|
|
transfer = Transfer.create!(
|
|
outflow_transaction: outflow_transaction,
|
|
inflow_transaction: inflow_transaction
|
|
)
|
|
|
|
# Create entries for both accounts
|
|
from_account.entries.create!(
|
|
name: "Transfer to #{to_account.name}",
|
|
date: date,
|
|
amount: -amount.abs,
|
|
currency: currency,
|
|
entryable: outflow_transaction
|
|
)
|
|
|
|
to_account.entries.create!(
|
|
name: "Transfer from #{from_account.name}",
|
|
date: date,
|
|
amount: amount.abs,
|
|
currency: currency,
|
|
entryable: inflow_transaction
|
|
)
|
|
|
|
transfer
|
|
end
|
|
end
|