mirror of
https://github.com/we-promise/sure.git
synced 2026-04-19 12:04:08 +00:00
* Add full import/export support for rules with versioned JSON schema This commit implements comprehensive import/export functionality for rules, allowing users to back up and restore their rule definitions. Key features: - Export rules to both CSV and NDJSON formats with versioned schema (v1) - Import rules from CSV with full support for nested conditions and actions - UUID to name mapping for categories and merchants for portability - Support for compound conditions with sub-conditions - Comprehensive test coverage for export and import functionality - UI integration for rules import in the imports interface Technical details: - Extended Family::DataExporter to generate rules.csv and include rules in all.ndjson - Created RuleImport model following the existing Import STI pattern - Added migration for rule-specific columns in import_rows table - Implemented serialization helpers to map UUIDs to human-readable names - Added i18n support for the new import option - Included versioning in NDJSON export to support future schema evolution The implementation ensures rules can be safely exported from one family and imported into another, even when category/merchant IDs differ, by mapping between names and IDs during export/import. * Fix AR migration version * Mention support for rules export * Rabbit suggestion * Fix tests * Missed schema.rb * Fix sample CSV download for rule import * Fix parsing in Rules import * Fix tests * Rule import message i18n * Export tag names, not UUIDs * Make sure tags are created if needed at import * Avoid test errors when running in parallel --------- Co-authored-by: Claude <noreply@anthropic.com>
112 lines
3.2 KiB
Ruby
112 lines
3.2 KiB
Ruby
class Rule < ApplicationRecord
|
|
UnsupportedResourceTypeError = Class.new(StandardError)
|
|
|
|
belongs_to :family
|
|
has_many :conditions, dependent: :destroy
|
|
has_many :actions, dependent: :destroy
|
|
|
|
accepts_nested_attributes_for :conditions, allow_destroy: true
|
|
accepts_nested_attributes_for :actions, allow_destroy: true
|
|
|
|
before_validation :normalize_name
|
|
|
|
validates :resource_type, presence: true
|
|
validates :name, length: { minimum: 1 }, allow_nil: true
|
|
validate :no_nested_compound_conditions
|
|
|
|
# Every rule must have at least 1 action
|
|
validate :min_actions
|
|
validate :no_duplicate_actions
|
|
|
|
def action_executors
|
|
registry.action_executors
|
|
end
|
|
|
|
def condition_filters
|
|
registry.condition_filters
|
|
end
|
|
|
|
def registry
|
|
@registry ||= case resource_type
|
|
when "transaction"
|
|
Rule::Registry::TransactionResource.new(self)
|
|
else
|
|
raise UnsupportedResourceTypeError, "Unsupported resource type: #{resource_type}"
|
|
end
|
|
end
|
|
|
|
def affected_resource_count
|
|
matching_resources_scope.count
|
|
end
|
|
|
|
def apply(ignore_attribute_locks: false)
|
|
actions.each do |action|
|
|
action.apply(matching_resources_scope, ignore_attribute_locks: ignore_attribute_locks)
|
|
end
|
|
end
|
|
|
|
def apply_later(ignore_attribute_locks: false)
|
|
RuleJob.perform_later(self, ignore_attribute_locks: ignore_attribute_locks)
|
|
end
|
|
|
|
def primary_condition_title
|
|
return "No conditions" if conditions.none?
|
|
|
|
first_condition = conditions.first
|
|
if first_condition.compound? && first_condition.sub_conditions.any?
|
|
first_sub_condition = first_condition.sub_conditions.first
|
|
"If #{first_sub_condition.filter.label.downcase} #{first_sub_condition.operator} #{first_sub_condition.value_display}"
|
|
else
|
|
"If #{first_condition.filter.label.downcase} #{first_condition.operator} #{first_condition.value_display}"
|
|
end
|
|
end
|
|
|
|
private
|
|
def matching_resources_scope
|
|
scope = registry.resource_scope
|
|
|
|
# 1. Prepare the query with joins required by conditions
|
|
conditions.each do |condition|
|
|
scope = condition.prepare(scope)
|
|
end
|
|
|
|
# 2. Apply the conditions to the query
|
|
conditions.each do |condition|
|
|
scope = condition.apply(scope)
|
|
end
|
|
|
|
scope
|
|
end
|
|
|
|
def min_actions
|
|
return if new_record? && actions.empty?
|
|
|
|
if actions.reject(&:marked_for_destruction?).empty?
|
|
errors.add(:base, "must have at least one action")
|
|
end
|
|
end
|
|
|
|
def no_duplicate_actions
|
|
action_types = actions.reject(&:marked_for_destruction?).map(&:action_type)
|
|
|
|
errors.add(:base, "Rule cannot have duplicate actions #{action_types.inspect}") if action_types.uniq.count != action_types.count
|
|
end
|
|
|
|
# Validation: To keep rules simple and easy to understand, we don't allow nested compound conditions.
|
|
def no_nested_compound_conditions
|
|
return true if conditions.none? { |condition| condition.compound? }
|
|
|
|
conditions.each do |condition|
|
|
if condition.compound?
|
|
if condition.sub_conditions.any? { |sub_condition| sub_condition.compound? }
|
|
errors.add(:base, "Compound conditions cannot be nested")
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
def normalize_name
|
|
self.name = nil if name.is_a?(String) && name.strip.empty?
|
|
end
|
|
end
|