mirror of
https://github.com/we-promise/sure.git
synced 2026-05-24 04:54:56 +00:00
* feat(sync): add Brex provider schema Adds Brex item and account tables with per-family credentials, scoped upstream account uniqueness, encrypted token storage, and sanitized provider payload columns. * feat(sync): add Brex provider core Adds Brex item/account models, provider client and adapter support, family connection helpers, and provider enum registration for read-only Brex cash and card data. * feat(sync): add Brex import pipeline Adds Brex account discovery, linked-account sync, cash/card balance processors, transaction import, sanitized metadata handling, and idempotent provider entry processing. * feat(sync): add Brex connection flows Adds Mercury-style Brex connection management, explicit item-scoped account selection and linking, settings provider UI, account index visibility, localized copy, and per-item cache handling. * test(sync): cover Brex provider workflows Adds targeted coverage for Brex provider requests, adapter config, item/account guards, importer behavior, entry processing, and Mercury-style controller flows. * fix(sync): align Brex API edge cases Tightens Brex account fetching against the official card-account response shape, sends transaction start filters as RFC3339 date-times, and keeps provider error bodies out of user-facing messages while expanding provider client guard coverage. * fix(sync): harden Brex provider integration Restrict Brex API base URLs to official hosts, tighten account-selection UI behavior, and add tests for invalid credentials, cache scoping, and provider setup edge cases. * test(sync): avoid Brex secret-shaped fixtures * refactor(sync): extract Brex account flows * fix(sync): address Brex provider review feedback * fix(sync): address Brex review follow-ups Move remaining Brex review cleanup into focused model behavior, tighten link/setup edge cases, localize summaries, and add regression coverage from CodeRabbit feedback. Also records the security-review pass as no-findings after diff-scoped inspection and Brakeman validation. * refactor(sync): split Brex account flow controllers Route Brex account selection and setup actions through small namespaced controllers while keeping existing URLs and helpers stable. Business flow remains in BrexItem::AccountFlow; the main Brex item controller now only handles connection CRUD, provider-panel rendering, destroy, and sync. * fix(sync): address Brex CodeRabbit review * fix(sync): address Brex follow-up review * fix(sync): address Brex review follow-ups * fix(sync): address Brex sync review findings * fix(sync): polish Brex review copy and errors * fix(sync): register Brex provider health * fix(sync): polish Brex bank sync presentation * fix(sync): address Brex review follow-ups * fix(sync): tighten Brex setup params * test(api): stabilize usage rate-limit window * fix(sync): polish Brex setup flow nits * fix(sync): harden Brex setup params * fix(sync): finalize Brex review cleanup --------- Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
99 lines
3.0 KiB
Ruby
99 lines
3.0 KiB
Ruby
class BrexItemsController < ApplicationController
|
|
before_action :set_brex_item, only: [ :show, :edit, :update, :destroy, :sync ]
|
|
before_action :require_admin!, only: [ :new, :create, :edit, :update, :destroy, :sync ]
|
|
|
|
def index
|
|
@brex_items = Current.family.brex_items.active.ordered
|
|
render layout: "settings"
|
|
end
|
|
|
|
def show
|
|
end
|
|
|
|
def new
|
|
@brex_item = Current.family.brex_items.build
|
|
end
|
|
|
|
def create
|
|
@brex_item = Current.family.brex_items.build(brex_item_params)
|
|
@brex_item.name = t("brex_items.default_connection_name") if @brex_item.name.blank?
|
|
|
|
if @brex_item.save
|
|
@brex_item.sync_later
|
|
render_provider_panel_success(t(".success"))
|
|
else
|
|
render_provider_panel_error
|
|
end
|
|
end
|
|
|
|
def edit
|
|
end
|
|
|
|
def update
|
|
if BrexItem::AccountFlow.update_item_with_cache_expiration(@brex_item, family: Current.family, attributes: brex_item_params)
|
|
render_provider_panel_success(t(".success"))
|
|
else
|
|
render_provider_panel_error
|
|
end
|
|
end
|
|
|
|
def destroy
|
|
@brex_item.unlink_all!(dry_run: false)
|
|
@brex_item.destroy_later
|
|
redirect_to accounts_path, notice: t(".success")
|
|
end
|
|
|
|
def sync
|
|
@brex_item.sync_later unless @brex_item.syncing?
|
|
|
|
respond_to do |format|
|
|
format.html { redirect_back_or_to accounts_path }
|
|
format.json { head :ok }
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def render_provider_panel_success(message)
|
|
return redirect_to accounts_path, notice: message, status: :see_other unless turbo_frame_request?
|
|
|
|
flash.now[:notice] = message
|
|
@brex_items = Current.family.brex_items.active.ordered.includes(:syncs, :brex_accounts)
|
|
render_brex_provider_panel(locals: { brex_items: @brex_items }, include_flash: true)
|
|
end
|
|
|
|
def render_provider_panel_error
|
|
@error_message = @brex_item.errors.full_messages.join(", ")
|
|
return redirect_to settings_providers_path, alert: @error_message, status: :see_other unless turbo_frame_request?
|
|
|
|
render_brex_provider_panel(locals: { error_message: @error_message }, status: :unprocessable_entity)
|
|
end
|
|
|
|
def render_brex_provider_panel(locals:, status: :ok, include_flash: false)
|
|
streams = [
|
|
turbo_stream.replace(
|
|
"brex-providers-panel",
|
|
partial: "settings/providers/brex_panel",
|
|
locals: locals
|
|
)
|
|
]
|
|
streams += flash_notification_stream_items if include_flash
|
|
render turbo_stream: streams, status: status
|
|
end
|
|
|
|
def set_brex_item
|
|
@brex_item = Current.family.brex_items.find(params[:id])
|
|
end
|
|
|
|
def brex_item_params
|
|
permitted = params.require(:brex_item).permit(:name, :sync_start_date, :token, :base_url)
|
|
permitted.delete(:token) if @brex_item&.persisted? && permitted[:token].blank?
|
|
permitted[:token] = permitted[:token].to_s.strip if permitted[:token].present?
|
|
if permitted.key?(:base_url)
|
|
permitted[:base_url] = permitted[:base_url].to_s.strip
|
|
permitted[:base_url] = nil if permitted[:base_url].blank?
|
|
end
|
|
permitted
|
|
end
|
|
end
|