mirror of
https://github.com/we-promise/sure.git
synced 2026-05-24 13:04:56 +00:00
* feat(i18n): complete Catalan translations + extract residual hardcoded strings
CA coverage
- All view/model/breadcrumb/doorkeeper/mailer locale files for ca: 0 missing
keys (was ~3,400). Translations follow informal "tu" register, sentence case,
domain glossary (Compte/Saldo/Transacció/Posició/Operació/Pressupost/...).
- Catalan pluralization test: ca uses one/other; mirrors
test/lib/polish_pluralization_test.rb.
- 8 LanguageTool-flagged grammar fixes applied (Connexió òrfena, Secret de
l'API, comma-pero, apostrophe elisions, etc).
Hardcoded string extraction (also fixes EN parity)
- UI::Account::Chart#title + chart.html.erb view tabs -> UI.account.chart.*
- UI::Account::BalanceReconciliation labels + tooltips ->
UI.account.balance_reconciliation.{labels,tooltips}.*
- transactions/_transfer_match.html.erb (Auto-matched, A/M, Confirm/Reject
match, Payment/Transfer is confirmed) -> transactions.transfer_match.*
- AccountOrder labels (Name/Balance asc/desc) -> account_order.* keys with
fallback to existing hardcoded labels.
- Depository::SUBTYPES surface in account list -> depositories.subtypes.*.*
- User role badge -> users.roles.* (admin / member / super_admin).
- 110+ country names -> countries.* (config/locales/countries.ca.yml).
Breadcrumb locale fix
- Breadcrumbable was a before_action that ran before Localize's around_action
switched I18n.locale, so default crumbs rendered in EN even when locale=ca.
- Convert to helper_method that defers translation to render-time (when
I18n.locale is already correct). Add all missing breadcrumb keys to ca + en.
- Layouts switched from @breadcrumbs to breadcrumbs helper.
Locale-aware helpers / formatters
- ApplicationHelper#localized_ordinal: ordinalize that respects ca
(1r/2n/3r/4t/Nè). Wired into preferences month_start_day select.
- Family#moniker_label / moniker_label_plural: translate the default "Family"/
"Group" monikers via shared.family_moniker.* with fallback to the family's
custom override.
- Budget#name: use I18n.l for month_year/short/long instead of strftime("%B %Y")
so the budget header date follows the active locale.
Tooling
- script/lt_check_ca.rb: batched LanguageTool checker (premium endpoint when
LT_USERNAME/LT_API_KEY are set, free fallback otherwise), picky mode,
motherTongue=en for false-friend detection.
- lib/tasks/i18n_screenshot.rake: dev-only rake to set user.locale=ca and
role=super_admin on the demo user so the i18n surfaces can be walked.
Out of scope (pre-existing, not introduced here)
- Native browser file input "Choose Files / No file chosen" (browser locale).
- D3.js client-side chart x-axis dates (JS-side Intl.DateTimeFormat needed).
- Sankey/donut labels = seed category names (data, not i18n).
- 2 rails-i18n datetime/errors interpolation warnings inherited from
config/locales/defaults/ca.yml.
* fix(i18n): apply idiomatic Catalan review (3-agent + native review)
Three parallel review agents flagged 203 findings (31 high / 73 medium / 99 low)
across all 111 ca.yml files. This commit applies the high-severity bugs plus a
curated subset of medium-impact fixes.
Grammar / agreement
- provider_sync_summary.health.stale_pending: `(exclòs)` -> `(exclosa/excloses)`
to agree with feminine `transacció(s)`.
- accounts.confirm_unlink.warning_no_sync: added reflexive `es` -
`el compte ja no es sincronitzarà`.
- sophtron_setup_required.heading: `no configurats` -> `sense configurar`
(avoids broken agreement across "ID" masc. + "clau" fem.).
- admin.sso_providers.form.errors_title: split into one/other pluralization
keys (en + ca); singular `ha impedit` was wrong for count > 1.
Brand consistency
- IndexaCapital -> Indexa Capital (37 occurrences across one file).
- Lunchflow -> Lunch Flow in two remaining places.
Anglicisms / domain mistranslations
- kraken_items setup_accounts.instructions: `ompliments d'operacions`
(lit. dental/food fillings) -> `execucions d'operacions`.
- settings kraken_panel.read_only_title: `Sincronització d'intercanvi`
(swap/trade) -> `Sincronització només de lectura amb l'exchange`.
- transactions convert_to_trade.security_custom + security_not_listed_hint:
`cotització` (price quote) -> `ticker` (the EN field IS a ticker symbol).
- loans.form.rate_type: `Tipus d'interès` collided with sibling
interest_rate -> `Modalitat del tipus`.
- brex_items.provider_panel.sandbox_note_html: `L'staging` (broken
contraction) -> `el staging`.
Idiom traps
- coinbase/binance/kraken wait_for_sync: `acabi de sincronitzar` is
ambiguous in CA (`acabar de + inf` reads as "has just done X") ->
`acabi la sincronització`.
- chats.ai_greeting.there: `a tothom` -> `''` (the EN fallback "Hey there"
is singular; literal CA `tothom` is plural and wrong for 1:1 chat).
- transactions.split_parent_row.split_label: `Divideix` (imperative) is
wrong as a status badge -> `Divisió` (noun).
- transactions.keep_both (2 occurrences): infinitive `mantenir ambdues` ->
imperative `mantén-les totes dues` to match the sibling Yes/No buttons.
- rules.clear_ai_cache: `Reinicia` (restart) -> `Buida` (empty/clear),
which matches the success notice (`s'està netejant`).
Moniker gender breakage (cross-file)
%{moniker} is interpolated downcased from family.moniker_label and may
resolve to feminine `família`/`llar` or masculine `grup`. Strings that
hard-code a gendered article ('al teu %{moniker}', 'aquesta %{moniker}',
'aquest/a %{moniker}') broke on at least one branch. Restructured the
affected sentences to drop the gendered determiner:
- account_sharings.show.no_members
- merchants.family_empty / family_title / provider_empty
- registrations.new.join_family_title
- settings.preferences.show.currencies_subtitle / sharing_subtitle
- simplefin_items.select_existing_account.no_accounts_found
- invitations.new.subtitle
- invitation_mailer.invite_email.subject (mailers/) + body (views/)
- snaptrade_items.providers.snaptrade.free_tier_warning
Terminology consistency
- models/account_statement/ca.yml attributes aligned with view-side
forms: `Saldo d'obertura`/`Saldo de tancament` ->
`Saldo inicial`/`Saldo final`; `Suggeriment de...` -> `Pista de...`.
- account_statements.coverage.status.not_expected:
`No s'esperava` -> `No previst` (status label, not past action).
- account_statements.index.empty_unmatched: aligned with the section's
own label `Safata sense aparellar`.
- imports.create.document_provider_not_configured + document_upload_failed:
`arxiu vectorial` -> `magatzem vectorial` (correct TermCat term).
- coinstats_items blockchain gender: `els blockchains` / `un blockchain` ->
`les blockchains` / `una blockchain` (feminine per TermCat).
- accounts.account.remove_default: `Treu el predeterminat` ->
`Treu com a predeterminat` (pairs with sibling `Estableix com a
predeterminat`).
- accounts.tax_treatments.tax_deferred: `Diferit fiscalment` (lit. calque)
-> `Tributació diferida` (standard CA tax-accounting term).
- settings.payments.show.currently_on_plan: `Actualment al` ->
`Actualment al pla:` (was a fragment).
Out of scope (review flagged, not applied here)
- LOW-severity stylistic preferences (Veure vs Mostra, etc).
- `models/category/ca.yml` default category names — seeded at family
creation, not via I18n at runtime, so changes wouldn't affect existing
families.
- `models/period/ca.yml` short labels mixing EN (MTD/YTD) and CA (STD/MA)
— needs a one-convention decision separately.
* fix(i18n,ca): drop gendered article in period_activity + tighten cash-flow terms
- pages.dashboard.investment_summary.period_activity: 'Activitat del
%{period}' contracted 'del' = 'de el' (masc.sg.). %{period} resolves
to mixed forms ('Setmana en curs' fem, 'Últims 30 dies' pl., 'Any en
curs' apostrophe), so hard-coded 'del' was wrong on most labels.
Replaced with 'Activitat — %{period}' (em-dash) to skip the
contraction entirely.
- pages.dashboard.outflows_donut.title / total_outflows: switched from
bare 'Sortides' / 'Total de sortides' to 'Sortides de caixa' /
'Total de sortides de caixa' to match TermCat's precise term
('sortida de caixa' = cash outflow).
* fix(i18n,ca): rephrase transfer source/destination amount labels
'Import d'origen' / 'Import de destinació' were literal calques of
'Source amount' / 'Destination amount'. In a multi-currency transfer
form (sender/receiver in different currencies) the natural CA pair is
'Import enviat' / 'Import rebut'.
* fix(i18n,ca): 'Dades en brut' -> 'Dades sense processar'
The literal calque of 'Raw data' read as too technical for personal-
finance UI. 'Dades sense processar' is the more natural Catalan
equivalent for raw/unprocessed data files.
* fix(i18n): localize Import col_sep label + separator options
The CSV upload form rendered 'Col sep' (the auto-humanized attribute
name) plus hardcoded English 'Comma (,)' / 'Semicolon (;)' options
from Import::SEPARATORS.
- activerecord.attributes.import.col_sep added (en + ca: 'Column
separator' / 'Separador de columnes').
- Import.separator_options class method returns translated tuples;
view switched from Import::SEPARATORS to Import.separator_options.
- activerecord.attributes.import.col_seps.{comma,semicolon} added so
the option labels follow the active locale.
* fix(i18n,ca): drop moniker apposition in sharing/currencies section titles
- sharing_title 'Compartició de %{moniker}' rendered as 'Compartició
de Família' (a noun-noun apposition that's odd in CA) -> 'Compartició
de comptes'.
- sharing_subtitle replaced '%{moniker}' with 'entre els membres' so
the sentence reads naturally and doesn't depend on moniker gender.
- currencies_title 'Divises de %{moniker}' had the same apposition
-> 'Divises'. Subtitle no longer references moniker either.
* fix(i18n,ca): keep 'Self Hosting' untranslated
Reverted 'Autoallotjament' / 'autoallotjada' / 'autoallotjats' usages
to the original English 'Self Hosting' (sidebar label, breadcrumbs,
hostings page title, chat assistant settings hint, redis configuration
subheading, LLM usages cost-estimates description).
The brand-style term reads more naturally in EN for technical users
configuring their own deployment.
* fix(i18n,ca): lowercase 'self hosting' (sentence case in labels)
* fix(i18n): extract budget_categories stepper + allocation_progress strings
Hardcoded English strings on the budget category editor:
- 'Setup' / 'Categories' stepper labels in budgets/_budget_nav.html.erb
- 'X% set' / '> 100% set' / 'left to allocate' / 'Budget exceeded by ...'
in budget_categories/_allocation_progress.erb
- '/m avg' caption + 'Shared' placeholder + 'Leave empty to share
parent's budget' tooltip in budget_categories/_budget_category_form
and _uncategorized_budget_category_form
Extracted to:
- budgets.budget_nav.{setup,categories}
- budget_categories.allocation_progress.{percent_set,over_set,left_to_allocate,budget_exceeded_html}
- budget_categories.budget_category_form.{monthly_average,shared_placeholder,shared_title}
CA translations added; EN keys mirror the prior literals.
* chore(i18n): drop translation tooling from PR
These were dev-only helpers used during the Catalan translation pass:
- script/lt_check_ca.rb: LanguageTool API checker (premium/free
endpoint, picky mode, batching). Useful for ongoing locale QA but
shouldn't ship in this feature PR.
- lib/tasks/i18n_screenshot.rake: rake task that flips user.locale and
role on the demo user for walking the i18n surfaces locally.
Both stay available locally; pulled out of the PR scope.
* fix(i18n): apply PR review feedback (CodeRabbit + Codex)
- balance_reconciliation crypto_items: use :end_balance_crypto tooltip
(was :end_balance_investment). Added new UI.account.balance_reconciliation.tooltips.end_balance_crypto key in en + ca.
- doorkeeper.ca.yml confidentiality.no: was YAML boolean false, now string 'No'.
- views/categories: 'Poor contrast, choose darker color or' continued with hardcoded 'auto-adjust.' button text; extracted to categories.form.auto_adjust key (en + ca).
- imports.create.document_upload_failed: 'a l'magatzem' was broken
contraction -> 'al magatzem'.
- invitation_mailer body + mailer subject: 'unir-se' -> 'unir-te' (was
3rd person, should be 2nd to match the rest of the copy).
- 7 strings across mercury_items / sophtron_items / simplefin_items /
lunchflow_items / brex_items / indexa_capital_items / other_assets:
'se sincronitzaran' -> 'es sincronitzaran', 'se segueixen' ->
'es segueixen' (correct reflexive pronoun before consonants).
- settings.providers.status: key was 'false' (YAML-coerced), now 'off'
to match settings/en.yml status.off used in view lookups.
- sophtron_items.sophtron_setup_required.message: stripped trailing
blank line from the quoted scalar.
- settings/profiles/show.html.erb: switched 'family_moniker ==
"Group"' branch checks to 'Current.family&.moniker == "Group"'.
After Family#moniker_label started returning translated values,
callers using the display label for branching would render the
household copy for group families in ca. Compare the stored sentinel
instead.
- Did not apply CodeRabbit's webauthn 'eliminada' -> 'desada' suggestion:
the key is wired to the destroy action (verified at
settings/webauthn_credentials_controller.rb:55), so 'eliminada' is
correct.
239 lines
6.6 KiB
Ruby
239 lines
6.6 KiB
Ruby
module ApplicationHelper
|
|
include Pagy::Frontend
|
|
|
|
def product_name
|
|
Rails.configuration.x.product_name
|
|
end
|
|
|
|
def brand_name
|
|
Rails.configuration.x.brand_name
|
|
end
|
|
|
|
def styled_form_with(**options, &block)
|
|
options[:builder] = StyledFormBuilder
|
|
form_with(**options, &block)
|
|
end
|
|
|
|
# Locale-aware ordinal label for integers.
|
|
# English falls through to Ruby's ordinalize ("1st"); Catalan returns "1r"/"2n"/...
|
|
def localized_ordinal(number)
|
|
case I18n.locale
|
|
when :ca
|
|
n = number.to_i
|
|
suffix = case n
|
|
when 1, 3 then "r"
|
|
when 2 then "n"
|
|
when 4 then "t"
|
|
else "è"
|
|
end
|
|
"#{n}#{suffix}"
|
|
else
|
|
number.to_i.ordinalize
|
|
end
|
|
end
|
|
|
|
def icon(key, size: "md", color: "default", custom: false, as_button: false, **opts)
|
|
extra_classes = opts.delete(:class)
|
|
sizes = { xs: "w-3 h-3", sm: "w-4 h-4", md: "w-5 h-5", lg: "w-6 h-6", xl: "w-7 h-7", "2xl": "w-8 h-8" }
|
|
colors = { default: "text-secondary", white: "text-inverse", success: "text-success", warning: "text-warning", destructive: "text-destructive", info: "text-info", current: "text-current" }
|
|
|
|
icon_classes = class_names(
|
|
"shrink-0",
|
|
sizes[size.to_sym],
|
|
colors[color.to_sym],
|
|
extra_classes
|
|
)
|
|
|
|
resolved_key = normalize_icon_key(key)
|
|
|
|
if custom
|
|
inline_svg_tag("#{resolved_key}.svg", class: icon_classes, **opts)
|
|
elsif as_button
|
|
render DS::Button.new(variant: "icon", class: extra_classes, icon: resolved_key, size: size, type: "button", **opts)
|
|
else
|
|
safe_lucide_icon(resolved_key, class: icon_classes, **opts)
|
|
end
|
|
end
|
|
|
|
# Convert alpha (0-1) to 8-digit hex (00-FF)
|
|
def hex_with_alpha(hex, alpha)
|
|
alpha_hex = (alpha * 255).round.to_s(16).rjust(2, "0")
|
|
"#{hex}#{alpha_hex}"
|
|
end
|
|
|
|
def title(page_title)
|
|
content_for(:title) { page_title }
|
|
end
|
|
|
|
def header_title(page_title)
|
|
content_for(:header_title) { page_title }
|
|
end
|
|
|
|
def header_description(page_description)
|
|
content_for(:header_description) { page_description }
|
|
end
|
|
|
|
def page_active?(path)
|
|
current_page?(path) || (request.path.start_with?(path) && path != "/")
|
|
end
|
|
|
|
# Wrapper around I18n.l to support custom date formats
|
|
def format_date(object, format = :default, options = {})
|
|
date = object.to_date
|
|
|
|
format_code = options[:format_code] || Current.family&.date_format
|
|
|
|
if format_code.present?
|
|
date.strftime(format_code)
|
|
else
|
|
I18n.l(date, format: format, **options)
|
|
end
|
|
end
|
|
|
|
|
|
def family_moniker
|
|
Current.family&.moniker_label || I18n.t("shared.family_moniker.singular")
|
|
end
|
|
|
|
def family_moniker_downcase
|
|
family_moniker.downcase
|
|
end
|
|
|
|
def family_moniker_plural
|
|
Current.family&.moniker_label_plural || I18n.t("shared.family_moniker.plural")
|
|
end
|
|
|
|
def family_moniker_plural_downcase
|
|
family_moniker_plural.downcase
|
|
end
|
|
|
|
def format_money(number_or_money, options = {})
|
|
return nil unless number_or_money
|
|
|
|
Money.new(number_or_money).format(options)
|
|
end
|
|
|
|
def totals_by_currency(collection:, money_method:, separator: " | ", negate: false)
|
|
collection.group_by(&:currency)
|
|
.transform_values { |item| calculate_total(item, money_method, negate) }
|
|
.map { |_currency, money| format_money(money) }
|
|
.join(separator)
|
|
end
|
|
|
|
def currency_picker_options_for_family(family = Current.family, extra: [])
|
|
return Money::Currency.as_options.map(&:iso_code) unless family
|
|
|
|
family.enabled_currency_codes(extra:)
|
|
end
|
|
|
|
def currency_label(currency_or_code)
|
|
currency = currency_or_code.is_a?(Money::Currency) ? currency_or_code : Money::Currency.new(currency_or_code)
|
|
"#{currency.name} (#{currency.iso_code})"
|
|
end
|
|
|
|
def show_super_admin_bar?
|
|
if params[:admin].present?
|
|
cookies.permanent[:admin] = params[:admin]
|
|
end
|
|
|
|
cookies[:admin] == "true"
|
|
end
|
|
|
|
def assistant_icon
|
|
type = ENV["ASSISTANT_TYPE"].presence || Current.family&.assistant_type.presence || "builtin"
|
|
type == "external" ? "claw" : "ai"
|
|
end
|
|
|
|
def default_ai_model
|
|
# Always return a valid model, never nil or empty
|
|
# Delegates to Chat.default_model for consistency
|
|
Chat.default_model
|
|
end
|
|
|
|
# Renders Markdown text using Redcarpet
|
|
def markdown(text)
|
|
return "" if text.blank?
|
|
|
|
renderer = Redcarpet::Render::HTML.new(
|
|
hard_wrap: true,
|
|
link_attributes: { target: "_blank", rel: "noopener noreferrer" }
|
|
)
|
|
|
|
markdown = Redcarpet::Markdown.new(
|
|
renderer,
|
|
autolink: true,
|
|
tables: true,
|
|
fenced_code_blocks: true,
|
|
strikethrough: true,
|
|
superscript: true,
|
|
underline: true,
|
|
highlight: true,
|
|
quote: true,
|
|
footnotes: true
|
|
)
|
|
|
|
markdown.render(text).html_safe
|
|
end
|
|
|
|
# Generate the callback URL for Enable Banking OAuth (used in views and controller).
|
|
# In production, uses the standard Rails route.
|
|
# In development, uses DEV_WEBHOOKS_URL if set (e.g., ngrok URL).
|
|
def enable_banking_callback_url
|
|
return callback_enable_banking_items_url if Rails.env.production?
|
|
|
|
ENV.fetch("DEV_WEBHOOKS_URL", root_url).chomp("/") + "/enable_banking_items/callback"
|
|
end
|
|
|
|
# Formats quantity with adaptive precision based on the value size.
|
|
# Shows more decimal places for small quantities (common with crypto).
|
|
#
|
|
# @param qty [Numeric] The quantity to format
|
|
# @param max_precision [Integer] Maximum precision for very small numbers
|
|
# @return [String] Formatted quantity with appropriate precision
|
|
def format_quantity(qty)
|
|
return "0" if qty.nil? || qty.zero?
|
|
|
|
abs_qty = qty.abs
|
|
|
|
precision = if abs_qty >= 1
|
|
1 # "10.5"
|
|
elsif abs_qty >= 0.01
|
|
2 # "0.52"
|
|
elsif abs_qty >= 0.0001
|
|
4 # "0.0005"
|
|
else
|
|
8 # "0.00000052"
|
|
end
|
|
|
|
# Use strip_insignificant_zeros to avoid trailing zeros like "0.50000000"
|
|
number_with_precision(qty, precision: precision, strip_insignificant_zeros: true)
|
|
end
|
|
|
|
private
|
|
def safe_lucide_icon(key, **opts)
|
|
lucide_icon(key, **opts)
|
|
rescue StandardError => e
|
|
Rails.logger.warn("[ApplicationHelper] Falling back to key for unknown icon #{key.inspect}: #{e.message}")
|
|
lucide_icon("key", **opts)
|
|
end
|
|
|
|
def normalize_icon_key(key)
|
|
normalized = key.to_s.strip
|
|
return normalized if normalized.blank?
|
|
|
|
normalized.downcase
|
|
end
|
|
|
|
def calculate_total(item, money_method, negate)
|
|
# Filter out transfer-type transactions from entries
|
|
# Only Entry objects have entryable transactions, Account objects don't
|
|
items = item.reject do |i|
|
|
i.is_a?(Entry) &&
|
|
i.entryable.is_a?(Transaction) &&
|
|
i.entryable.transfer?
|
|
end
|
|
total = items.sum(&money_method)
|
|
negate ? -total : total
|
|
end
|
|
end
|