mirror of
https://github.com/we-promise/sure.git
synced 2026-05-24 21:14:56 +00:00
cdce00c71e
* refactor(design-system): migrate 9 hand-rolled buttons with orphan btn-- classes to DS::Button / DS::Link Part of #1715 §5. The `btn`, `btn--primary`, `btn--outline`, `btn--ghost`, `btn--sm` CSS classes have no backing styles anywhere in the codebase (no .btn definition in app/assets/, no Bootstrap dependency). These callsites have been rendering unstyled buttons / links since the underlying CSS was last removed. Migrate the 9 broken callsites: - `app/views/transactions/show.html.erb` — duplicate-merge action buttons (×2): `button_to ... class: "btn btn--primary btn--sm"` / `class: "btn btn--outline btn--sm"` → DS::Button with href + variant + size + `data: { turbo_method: :post }`. - `app/views/snaptrade_items/select_existing_account.html.erb` — "Go to Provider Settings" link → DS::Link primary sm. - `app/views/indexa_capital_items/select_existing_account.html.erb` — same pattern → DS::Link primary sm. - `app/views/import/confirms/show.html.erb` — Publish button + Cancel link → DS::Button primary full-width + DS::Link ghost full-width. - `app/views/simplefin_items/new.html.erb` — Cancel link (`class: "btn"` only) + Connect submit → DS::Link secondary + bare `f.submit` (already routes to DS::Button via StyledFormBuilder). - `app/views/settings/providers/_ibkr_panel.html.erb`, `_snaptrade_panel.html.erb`, `_indexa_capital_panel.html.erb` — strip the orphan `class: "btn btn--primary"` from `f.submit` callers; the submit is already a styled DS::Button via the form builder. The next PR in this chain (Phase B) will tackle the larger inline- button cluster (~29 files, 38 instances) — provider panels and provider-item flows hand-rolling the same `inline-flex items-center justify-center rounded-lg px-4 py-2 text-sm font-medium text-inverse bg-inverse hover:bg-inverse-hover focus:outline-none focus:ring-2 focus:ring-primary transition-colors` string. * refactor(design-system): migrate 38 hand-rolled provider buttons to DS::Button / DS::Link (#1715 §5 part B) Bulk sweep of the second cluster from §5. 29 files, 38 button instances — each one hand-rolled the same long Tailwind string for the primary action button: inline-flex items-center justify-center rounded-lg px-4 py-2 text-sm font-medium text-inverse bg-inverse hover:bg-inverse-hover focus:outline-none focus:ring-2 focus:ring-primary transition-colors (some variations used `button-bg-primary hover:button-bg-primary-hover` instead of `bg-inverse hover:bg-inverse-hover` — same intent). Every instance is now a DS::Button / DS::Link with `variant: :primary`, which: - Picks up the new focus-ring + touch-target work from #1840 once that merges. - Stops duplicating the long Tailwind string across 29 files — single source of truth in `DS::Buttonish::VARIANTS[:primary]`. - Picks up consistent `aria-label` derivation for icon-only forms. - Removes the misnamed `focus:ring-primary` (no token) — the new ring comes from `base.css` automatically. Migration patterns applied: - `f.submit text, class: "inline-flex …"` inside `styled_form_with` → bare `<%= f.submit text %>`. StyledFormBuilder routes through DS::Button. - `link_to text, path, class: "inline-flex …"` → DS::Link primary. - `button_to text, path, method: :X, class: "inline-flex …"` → DS::Button with `href: path` and `data: { turbo_method: :X }`. - `submit_tag text, class: "inline-flex …"` inside raw `form_with` → DS::Button with `type: :submit`. Notable adjustments: - `holdings/show.html.erb` — the form was `form_with` (not styled). Switched to `styled_form_with` so `f.submit` routes through DS::Button. `f.combobox` (hotwire_combobox) still works through the styled builder. - Two `link_to settings_providers_path` callsites in `coinstats_items/new.html.erb` + `enable_banking_items/new.html.erb` had `w-full inline-flex … hidden md:inline-flex` — the responsive pair conflicted (both `inline-flex` and `hidden md:inline-flex` on the same element). Migrated to `full_width: true` without the responsive split; the buttons now render at all breakpoints consistently. (Pre-existing copy-paste bug, fixed in passing.) - `enable_banking_panel` add-connection button gained `icon: "plus"` via the DS::Button API; the explicit `gap-2 … icon "plus"` markup is now redundant. Sibling buttons that don't match the primary spec (destructive trash, secondary outline-bordered, button-bg-secondary-strong on holdings/show.html.erb, etc.) are intentionally left alone — they need their own audit pass once #1840 lands and the focus-ring behavior on those variants is stable. * fix(review): restore SimpleFIN submit styling + i18n provider_form label - SimpleFIN new modal: switch form_with -> styled_form_with so f.submit picks up the DS::Button render via styled builder (Codex #1860). - _provider_form: replace hardcoded "Save and connect" with t(".save_and_connect") and add scoped key under settings.providers.provider_form (CodeRabbit).
70 lines
3.8 KiB
Plaintext
70 lines
3.8 KiB
Plaintext
<%# locals: (simplefin_item:, suggestions:)
|
|
Banner rendered at the top of the SimpleFIN item card when the importer
|
|
detects a likely card-replacement pair (old card + new card, same
|
|
institution, same type). "Relink" reuses the existing link_existing_account
|
|
controller action to atomically swap the AccountProvider on the linked
|
|
Sure account. "Dismiss" persists a per-(dormant_sfa_id) dismissal on the
|
|
latest sync's sync_stats so the banner stops showing for that pair.
|
|
Suggestions are also auto-suppressed once the relink has already landed. %>
|
|
<% latest_sync = simplefin_item.syncs.order(created_at: :desc).first %>
|
|
<% dismissed_ids = Array(latest_sync&.sync_stats&.dig("dismissed_replacement_suggestions")) %>
|
|
<div class="space-y-2">
|
|
<% suggestions.each do |suggestion| %>
|
|
<% old_sfa = simplefin_item.simplefin_accounts.find_by(id: suggestion["dormant_sfa_id"]) %>
|
|
<% new_sfa = simplefin_item.simplefin_accounts.find_by(id: suggestion["active_sfa_id"]) %>
|
|
<% sure_account = Current.family.accounts.find_by(id: suggestion["sure_account_id"]) %>
|
|
<% next unless old_sfa && new_sfa && sure_account %>
|
|
<%# Hide once the relink has landed: new sfa already linked to the target account. %>
|
|
<% next if new_sfa.current_account&.id == sure_account.id %>
|
|
<%# Hide if the user has dismissed this specific pair. %>
|
|
<% dismissal_key = "#{old_sfa.id}:#{new_sfa.id}" %>
|
|
<% next if dismissed_ids.include?(dismissal_key) %>
|
|
|
|
<div class="bg-yellow-50 theme-dark:bg-yellow-900/20 border border-yellow-200 theme-dark:border-yellow-800 rounded-lg p-4">
|
|
<div class="flex items-start gap-3">
|
|
<%= icon "credit-card", size: "sm", color: "warning", class: "shrink-0 mt-0.5" %>
|
|
<div class="flex-1 space-y-2">
|
|
<div class="flex items-start justify-between gap-2">
|
|
<p class="text-sm font-medium text-primary">
|
|
<%= t("simplefin_items.replacement_prompt.title",
|
|
institution: suggestion["institution_name"].presence || simplefin_item.name) %>
|
|
</p>
|
|
<%= button_to dismiss_replacement_suggestion_simplefin_item_path(simplefin_item),
|
|
params: { dormant_sfa_id: old_sfa.id, active_sfa_id: new_sfa.id },
|
|
method: :post,
|
|
form: { class: "inline shrink-0" },
|
|
class: "-mt-1 -mr-1 p-1 rounded hover:bg-yellow-100 theme-dark:hover:bg-yellow-900/40 text-secondary",
|
|
aria: { label: t("simplefin_items.replacement_prompt.dismiss_aria") } do %>
|
|
<%= icon "x", size: "sm" %>
|
|
<% end %>
|
|
</div>
|
|
<p class="text-xs text-secondary">
|
|
<%= t("simplefin_items.replacement_prompt.description",
|
|
account_name: sure_account.name,
|
|
old_name: old_sfa.name,
|
|
new_name: new_sfa.name) %>
|
|
</p>
|
|
<div class="pt-1">
|
|
<% confirm = CustomConfirm.new(
|
|
title: t("simplefin_items.replacement_prompt.confirm_title"),
|
|
body: t("simplefin_items.replacement_prompt.confirm_body",
|
|
account_name: sure_account.name,
|
|
new_name: new_sfa.name),
|
|
btn_text: t("simplefin_items.replacement_prompt.relink")
|
|
) %>
|
|
<%= render DS::Button.new(
|
|
text: t("simplefin_items.replacement_prompt.relink"),
|
|
href: link_existing_account_simplefin_items_path(
|
|
account_id: sure_account.id,
|
|
simplefin_account_id: new_sfa.id
|
|
),
|
|
variant: :primary,
|
|
data: { turbo_method: :post, turbo_confirm: confirm.to_data_attribute }
|
|
) %>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
</div>
|