mirror of
https://github.com/we-promise/sure.git
synced 2026-07-12 21:05:20 +00:00
169fd139b5
* fix(chat): surface and recover from undelivered assistant responses When the background worker that runs AssistantResponseJob is down or not polling the high_priority queue, the eager "pending" assistant message had no safeguard: chat hung on "Thinking…" forever with no error, timeout, or retry, and the LLM provider was never even called. Add three layers of resilience: - Client watchdog (chat_controller.js): a pending "Thinking…" bubble that waits past a threshold (default 90s) with no response asks the server to fail it. Keyed on the pending marker — which disappears the instant a real response streams — so a slow-but-working response is never falsely timed out. - Server failure capture (Chat#handle_undelivered_response! + MessagesController#report_timeout): clears the dead bubble, records a friendly "the assistant didn't respond" error with Retry, and writes a DebugLogEntry so support can see it in /settings/debug. - Worker liveness signal (BackgroundJobHealth + warning banner): reads Sidekiq's process/queue state directly from Redis in the web process — so a down worker is detectable even though the worker is the thing that's broken — and warns self-hosted users when no worker polls high_priority or it's badly backed up. Fails open so a Sidekiq/Redis blip never blocks chat. Tests: Chat model (3), MessagesController (2), BackgroundJobHealth (5). * fix(chat): address review — server-side timeout guard + watchdog retry safety - Chat#handle_undelivered_response!: gate the state change behind a row lock and a server-side minimum age (UNDELIVERED_RESPONSE_TIMEOUT = 60s). The browser watchdog is untrusted, so re-read the row under lock and only fail a bubble that is still pending AND has genuinely waited past the timeout — never racing a worker that is finishing a slow response. (Codex P2 + CodeRabbit) - chat_controller.js: only mark a report URL as reported on response.ok (fetch resolves on HTTP 4xx/5xx, rejecting only on network errors), and guard concurrent duplicate POSTs with an in-flight set, so a failed report retries instead of stranding the bubble. (CodeRabbit) - _worker_health_warning: drop the unused `chat:` local + its render arg. (CodeRabbit)
40 lines
1.0 KiB
Ruby
40 lines
1.0 KiB
Ruby
class MessagesController < ApplicationController
|
|
guard_feature unless: -> { Current.user.ai_enabled? }
|
|
|
|
before_action :set_chat
|
|
|
|
def create
|
|
@message = UserMessage.new(
|
|
chat: @chat,
|
|
content: message_params[:content],
|
|
ai_model: message_params[:ai_model].presence || Chat.default_model
|
|
)
|
|
|
|
if @message.save
|
|
redirect_to chat_path(@chat, thinking: true)
|
|
else
|
|
redirect_to chat_path(@chat), alert: @message.errors.full_messages.to_sentence
|
|
end
|
|
end
|
|
|
|
# Called by the chat watchdog when an assistant "Thinking…" bubble has waited
|
|
# too long for a response that never arrived. Idempotent and scoped to the
|
|
# current user's chat.
|
|
def report_timeout
|
|
message = @chat.messages.find(params[:id])
|
|
@chat.handle_undelivered_response!(message)
|
|
head :ok
|
|
rescue ActiveRecord::RecordNotFound
|
|
head :not_found
|
|
end
|
|
|
|
private
|
|
def set_chat
|
|
@chat = Current.user.chats.find(params[:chat_id])
|
|
end
|
|
|
|
def message_params
|
|
params.require(:message).permit(:content, :ai_model)
|
|
end
|
|
end
|