mirror of
https://github.com/we-promise/sure.git
synced 2026-09-06 15:14:19 +00:00
* fix(transactions): Resolve N+1 query in bulk update controller * Test transaction bulk update eager loading --------- Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
30 lines
1.0 KiB
Ruby
30 lines
1.0 KiB
Ruby
class Transactions::BulkUpdatesController < ApplicationController
|
|
def new
|
|
end
|
|
|
|
def create
|
|
# Skip split parents from bulk update - update children instead
|
|
updated = Current.family
|
|
.entries
|
|
.excluding_split_parents
|
|
.where(id: bulk_update_params[:entry_ids])
|
|
.includes(:entryable)
|
|
.bulk_update!(bulk_update_params, update_tags: tags_provided?)
|
|
|
|
redirect_back_or_to transactions_path, notice: "#{updated} transactions updated"
|
|
end
|
|
|
|
private
|
|
def bulk_update_params
|
|
params.require(:bulk_update)
|
|
.permit(:date, :notes, :name, :category_id, :merchant_id, entry_ids: [], tag_ids: [])
|
|
end
|
|
|
|
# Check if tag_ids was explicitly provided in the request.
|
|
# This distinguishes between "user wants to update tags" vs "user didn't touch tags field".
|
|
def tags_provided?
|
|
bulk_update = params[:bulk_update]
|
|
bulk_update.respond_to?(:key?) && bulk_update.key?(:tag_ids)
|
|
end
|
|
end
|