mirror of
https://github.com/we-promise/sure.git
synced 2026-08-05 08:32:15 +00:00
* Add support for trading212 integration in investments sync * Respect Trading 212 history rate limits * Replace hex colors with design tokens * Changed withdrawal to withdraw * Address PR review feedback for Trading 212 integration - Replace all Rails.logger calls with DebugLogEntry.capture across syncer, importer, processor, provider, controller, and unlinking - Fix destroy action to surface unlink errors via DebugLogEntry - Replace hardcoded 'GBP' currency fallback with Current.family.currency - Replace hardcoded English status strings in Syncer with i18n - Add config/initializers/trading212.rb with DEBUG_RAW ENV toggle - Add comprehensive test coverage: item, account, data_helpers, holdings_processor, activities_processor, importer, syncer, and controller tests - Rewrite syncer and controller tests to match actual interfaces * Fix tests and bugs found during local test execution - Fix standard_ticker: empty string caused nil.upcase via [].first - Fix parse_date: DateTime < Date, so when Date caught DateTime first - Fix ActivitiesProcessor/HoldingsProcessor: missing instruments_map in DataHelpers caused NameError when processing dividends - Fix test: security fixture ticker collision with test data - Fix test: sync_status_summary i18n matching in assertions - Fix test: trading212_provider ConfigurationError test path - Fix test: controller invalid params needs Turbo-Frame header - Fix test: syncer test uses stubs instead of strict expects 116 tests, 257 assertions, 0 failures, 0 errors * Keep raw provider response bodies out of exception messages. * Fix Secrets leak into page HTML, prevents the API key/secret from appearing in the HTML source while keeping the "leave blank to keep existing" UX. * Address review findings: env gate, sync test, uniqueness test, destroy flow - Gate TRADING212_DEBUG_RAW behind Rails.env.local? so staging/production cannot accidentally enable raw payload logging - Assert SyncJob enqueue in sync controller test, not just redirect - Fix cross-item uniqueness test to actually use two different items - Remove rescue in destroy so unlink failures stop the flow (matching Brex/Akahu pattern) instead of proceeding to destroy_later silently * Add Trading212 tables to db/schema.rb for CI test database CI runs db:test:prepare which loads db/schema.rb, not migrations. Without these table definitions, fixture loading fails with PG::UndefinedTable: relation "trading212_accounts" does not exist. * Removed lint complaint * Register Trading212 in ProviderConnectionStatus::PROVIDERS Fixes CI failure: test_provider_registry_covers_syncable_family_provider_item_associations * Fixed bad merge --------- Signed-off-by: jdcdp <47483528+jdcdp@users.noreply.github.com> Co-authored-by: jdcdp <jdcdp@cdm4.net>
60 lines
1.3 KiB
Ruby
60 lines
1.3 KiB
Ruby
class Provider::Trading212Adapter < Provider::Base
|
|
include Provider::Syncable
|
|
include Provider::InstitutionMetadata
|
|
|
|
Provider::Factory.register("Trading212Account", self)
|
|
|
|
def self.supported_account_types
|
|
%w[Investment]
|
|
end
|
|
|
|
def self.connection_configs(family:)
|
|
return [] unless family.can_connect_trading212?
|
|
|
|
[ {
|
|
key: "trading212",
|
|
name: I18n.t("providers.trading212.name"),
|
|
description: I18n.t("providers.trading212.connection_description"),
|
|
can_connect: true,
|
|
new_account_path: ->(_accountable_type, _return_to) {
|
|
Rails.application.routes.url_helpers.select_accounts_trading212_items_path
|
|
},
|
|
existing_account_path: ->(account_id) {
|
|
Rails.application.routes.url_helpers.select_existing_account_trading212_items_path(account_id: account_id)
|
|
}
|
|
} ]
|
|
end
|
|
|
|
def provider_name
|
|
"trading212"
|
|
end
|
|
|
|
def sync_path
|
|
Rails.application.routes.url_helpers.sync_trading212_item_path(item)
|
|
end
|
|
|
|
def item
|
|
provider_account.trading212_item
|
|
end
|
|
|
|
def can_delete_holdings?
|
|
false
|
|
end
|
|
|
|
def institution_domain
|
|
"trading212.com"
|
|
end
|
|
|
|
def institution_name
|
|
I18n.t("providers.trading212.institution_name")
|
|
end
|
|
|
|
def institution_url
|
|
"https://www.trading212.com"
|
|
end
|
|
|
|
def institution_color
|
|
"#2A9D8F"
|
|
end
|
|
end
|