mirror of
https://github.com/we-promise/sure.git
synced 2026-08-05 08:32:15 +00:00
* Add support for trading212 integration in investments sync * Respect Trading 212 history rate limits * Replace hex colors with design tokens * Changed withdrawal to withdraw * Address PR review feedback for Trading 212 integration - Replace all Rails.logger calls with DebugLogEntry.capture across syncer, importer, processor, provider, controller, and unlinking - Fix destroy action to surface unlink errors via DebugLogEntry - Replace hardcoded 'GBP' currency fallback with Current.family.currency - Replace hardcoded English status strings in Syncer with i18n - Add config/initializers/trading212.rb with DEBUG_RAW ENV toggle - Add comprehensive test coverage: item, account, data_helpers, holdings_processor, activities_processor, importer, syncer, and controller tests - Rewrite syncer and controller tests to match actual interfaces * Fix tests and bugs found during local test execution - Fix standard_ticker: empty string caused nil.upcase via [].first - Fix parse_date: DateTime < Date, so when Date caught DateTime first - Fix ActivitiesProcessor/HoldingsProcessor: missing instruments_map in DataHelpers caused NameError when processing dividends - Fix test: security fixture ticker collision with test data - Fix test: sync_status_summary i18n matching in assertions - Fix test: trading212_provider ConfigurationError test path - Fix test: controller invalid params needs Turbo-Frame header - Fix test: syncer test uses stubs instead of strict expects 116 tests, 257 assertions, 0 failures, 0 errors * Keep raw provider response bodies out of exception messages. * Fix Secrets leak into page HTML, prevents the API key/secret from appearing in the HTML source while keeping the "leave blank to keep existing" UX. * Address review findings: env gate, sync test, uniqueness test, destroy flow - Gate TRADING212_DEBUG_RAW behind Rails.env.local? so staging/production cannot accidentally enable raw payload logging - Assert SyncJob enqueue in sync controller test, not just redirect - Fix cross-item uniqueness test to actually use two different items - Remove rescue in destroy so unlink failures stop the flow (matching Brex/Akahu pattern) instead of proceeding to destroy_later silently * Add Trading212 tables to db/schema.rb for CI test database CI runs db:test:prepare which loads db/schema.rb, not migrations. Without these table definitions, fixture loading fails with PG::UndefinedTable: relation "trading212_accounts" does not exist. * Removed lint complaint * Register Trading212 in ProviderConnectionStatus::PROVIDERS Fixes CI failure: test_provider_registry_covers_syncable_family_provider_item_associations * Fixed bad merge --------- Signed-off-by: jdcdp <47483528+jdcdp@users.noreply.github.com> Co-authored-by: jdcdp <jdcdp@cdm4.net>
59 lines
1.6 KiB
Ruby
59 lines
1.6 KiB
Ruby
class Trading212Account < ApplicationRecord
|
|
include CurrencyNormalizable, Encryptable
|
|
include Trading212Account::DataHelpers
|
|
|
|
if encryption_ready?
|
|
encrypts :raw_positions_payload
|
|
encrypts :raw_orders_payload
|
|
encrypts :raw_dividends_payload
|
|
encrypts :raw_transactions_payload
|
|
end
|
|
|
|
belongs_to :trading212_item
|
|
|
|
has_one :account_provider, as: :provider, dependent: :destroy
|
|
has_one :account, through: :account_provider, source: :account
|
|
has_one :linked_account, through: :account_provider, source: :account
|
|
|
|
validates :currency, presence: true
|
|
validates :trading212_account_id, uniqueness: { scope: :trading212_item_id, allow_nil: true }
|
|
|
|
def current_account
|
|
account || linked_account
|
|
end
|
|
|
|
def ensure_account_provider!(account = nil)
|
|
if account_provider.present?
|
|
account_provider.update!(account: account) if account && account_provider.account_id != account.id
|
|
return account_provider
|
|
end
|
|
|
|
acct = account || current_account
|
|
return nil unless acct
|
|
|
|
provider = AccountProvider
|
|
.find_or_initialize_by(provider_type: "Trading212Account", provider_id: id)
|
|
.tap do |record|
|
|
record.account = acct
|
|
record.save!
|
|
end
|
|
|
|
reload_account_provider
|
|
provider
|
|
rescue => e
|
|
DebugLogEntry.capture(
|
|
category: "sync",
|
|
level: "warn",
|
|
message: "Trading212Account##{id}: failed to ensure AccountProvider link: #{e.class} - #{e.message}",
|
|
source: "trading212",
|
|
family: trading212_item.family,
|
|
provider_key: "trading212"
|
|
)
|
|
nil
|
|
end
|
|
|
|
def instruments_map
|
|
trading212_item.instruments_map
|
|
end
|
|
end
|