mirror of
https://github.com/we-promise/sure.git
synced 2026-08-05 16:42:18 +00:00
fc0581fba3
* Add per-account toggle to disable automatic transaction categorization Adds an `enable_category_matcher` boolean (default: true) to accounts so users can opt out of Plaid's automatic category suggestions on a per-account basis. When disabled, newly synced transactions arrive uncategorized so rules or manual assignment take precedence. - New migration adds `enable_category_matcher` column (default true, null: false) - `PlaidEntry::Processor#matched_category` gates the CategoryMatcher call on the account flag - Toggle rendered in the account edit modal for linked accounts (saves via main form submit) - `AccountableResource#account_params` permits the new field - `AccountsController#toggle_category_matcher` action added for potential API use - i18n strings added for label and hint text - Unit test covers the disabled-matcher path Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Only show category matcher toggle for Plaid-linked accounts Only PlaidEntry::Processor honors enable_category_matcher, but the toggle rendered for every linked account, silently doing nothing for other providers. Adds Account::Linkable#supports_category_matcher? (covering both the legacy plaid_account_id link and AccountProvider rows) and gates the form toggle on it. The SimpleFIN TODO now also points at this helper so the toggle appears once SimpleFIN matching lands. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Add controller tests for category matcher toggle persistence and rendering Covers the two paths flagged in review as untested: the flag persisting through the shared AccountableResource#update action via account_params (both disable and re-enable), and the edit form rendering the toggle only for accounts where supports_category_matcher? is true. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Signed-off-by: Mike Lloyd <49411532+mike-lloyd03@users.noreply.github.com> Signed-off-by: Juan José Mata <juanjo.mata@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
67 lines
2.6 KiB
Plaintext
67 lines
2.6 KiB
Plaintext
<%# locals: (account:, url:) %>
|
|
|
|
<% if @error_message.present? %>
|
|
<%= render DS::Alert.new(message: @error_message, variant: :error) %>
|
|
<% end %>
|
|
|
|
<%= styled_form_with model: account, url: url, scope: :account, data: { turbo: false }, class: "flex flex-col gap-4 justify-between grow text-primary" do |form| %>
|
|
<div class="grow space-y-2">
|
|
<%= form.hidden_field :accountable_type %>
|
|
<%= form.hidden_field :return_to, value: params[:return_to] %>
|
|
|
|
<%= form.text_field :name, placeholder: t(".name_placeholder"), required: "required", label: t(".name_label") %>
|
|
|
|
<% unless account.linked? %>
|
|
<%= form.money_field :balance, label: t(".balance"), required: true, default_currency: Current.family.currency %>
|
|
<% end %>
|
|
|
|
<% if account.new_record? && !account.linked? %>
|
|
<%= form.date_field :opening_balance_date,
|
|
label: t(".opening_balance_date_label"),
|
|
value: Time.zone.today - 2.years,
|
|
required: true %>
|
|
<% end %>
|
|
|
|
<%= yield form %>
|
|
|
|
<% if account.persisted? && account.supports_category_matcher? %>
|
|
<div class="flex items-center justify-between gap-3 py-2">
|
|
<div class="space-y-1">
|
|
<p class="text-sm text-primary"><%= t(".enable_category_matcher_label") %></p>
|
|
<p class="text-secondary text-sm"><%= t(".enable_category_matcher_hint") %></p>
|
|
</div>
|
|
<%= form.toggle :enable_category_matcher %>
|
|
</div>
|
|
<% end %>
|
|
|
|
<details class="group">
|
|
<summary class="cursor-pointer text-sm text-secondary hover:text-primary flex items-center gap-1 py-2">
|
|
<%= icon "chevron-right", size: "sm", class: "group-open:rotate-90 transition-transform" %>
|
|
<%= t(".additional_details") %>
|
|
</summary>
|
|
|
|
<div class="space-y-2 mt-2 pl-4 border-l border-primary">
|
|
<%= form.text_field :institution_name,
|
|
label: t(".institution_name_label"),
|
|
placeholder: account.provider&.institution_name || t(".institution_name_placeholder") %>
|
|
|
|
<%= form.text_field :institution_domain,
|
|
label: t(".institution_domain_label"),
|
|
placeholder: account.provider&.institution_domain || t(".institution_domain_placeholder") %>
|
|
|
|
<%= form.text_area :notes,
|
|
label: t(".notes_label"),
|
|
placeholder: t(".notes_placeholder"),
|
|
rows: 4 %>
|
|
|
|
<div class="flex items-center justify-between gap-2">
|
|
<span class="text-sm"><%= t(".exclude_from_reports") %></span>
|
|
<%= form.toggle :exclude_from_reports %>
|
|
</div>
|
|
</div>
|
|
</details>
|
|
</div>
|
|
|
|
<%= form.submit %>
|
|
<% end %>
|