mirror of
https://github.com/we-promise/sure.git
synced 2026-08-05 00:22:17 +00:00
c54369bd2d
* Add send_email_notification rule action Adds a new rule action that emails a digest of transactions matching a rule. Re-syncs re-apply every active rule to all in-window matches, so a notification_deliveries table (unique on rule_id + transaction_id) backs deduplication and a per-rule watermark: - Rule::ActionExecutor::SendEmailNotification plucks candidate ids, drops ones already in notification_deliveries, records the remainder BEFORE enqueuing (fail-safe: a crash suppresses rather than double-sends), and returns the count of newly-notified transactions. - RuleEmailNotificationJob loads the rule + transactions and delivers the digest via RuleNotificationMailer. - Creating the action pre-seeds all currently-matching transactions as already-delivered (after_create_commit), so the rule only emails about transactions appearing after the action exists. Dedup keys on the DB row id, not provider identity, so a re-ingested transaction (new id) may re-notify; accepted as benign. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Add view transactions link to rule notification digest email Include a "View transactions" CTA (APP_DOMAIN/transactions) in both the HTML and text versions of the rule notification digest email. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Address review feedback on rule email notifications - Restrict digest delivery to family admins only (drop non-admin fallback) - Make NotificationDelivery.record_for return only inserted ids and enqueue off that result, preventing duplicate digests under concurrent rule runs - Seed the notification baseline when an existing action is changed to send_email_notification, so historical matches are not emailed - Strengthen tests: assert the transactions CTA/link in the digest and the enqueued job's transaction-id args Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Include super_admin owner as rule digest recipient The admin-only recipient lookup used find_by(role: :admin), which excluded super_admin owners. A self-hosted family is commonly a single super_admin, so the digest was silently skipped (NullMail no-op) and no email was sent. Match the recipient on %w[admin super_admin] (the same pattern used elsewhere, and consistent with User#admin?), while still excluding regular members/guests. Add tests for the super_admin recipient and the no-admin skip path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Add mixed-role digest recipient test Cover the case where a family has both an admin and a super_admin. The recipient lookup uses find_by(role: %w[admin super_admin]) with no ORDER BY, so which one is returned is non-deterministic; the contract is only that the recipient is an admin-level user (never a member). Assert recipient.admin? rather than a brittle precedence between the two roles. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Deliver rule digest via deliver_later and order in DB Use deliver_later so a slow/flaky SMTP connection doesn't tie up the Sidekiq worker, and push the entry-date sort into the query instead of materializing and sorting the result set in Ruby. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Replace raw hex colors with email-safe design tokens in digest template The rule digest email hardcoded Tailwind slate-100/200 hex values for table borders, which aren't part of this project's design system. Resolve to the actual border-primary/border-secondary token values and centralize them as a reusable .email-table class in the mailer layout. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
74 lines
1.7 KiB
Plaintext
74 lines
1.7 KiB
Plaintext
<!DOCTYPE html>
|
|
<html>
|
|
<head>
|
|
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
|
|
<meta name="viewport" content="width=device-width, initial-scale=1.0">
|
|
<style>
|
|
/* Email-safe styles that work across clients */
|
|
body {
|
|
background-color: #f8fafc;
|
|
font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Helvetica, Arial, sans-serif;
|
|
line-height: 1.5;
|
|
margin: 0;
|
|
padding: 0;
|
|
}
|
|
.container {
|
|
background-color: #ffffff;
|
|
border-radius: 8px;
|
|
margin: 20px auto;
|
|
max-width: 600px;
|
|
padding: 32px;
|
|
text-align: center;
|
|
}
|
|
h1 {
|
|
color: #1e293b;
|
|
font-size: 24px;
|
|
margin-bottom: 24px;
|
|
}
|
|
p {
|
|
color: #475569;
|
|
font-size: 16px;
|
|
margin-bottom: 16px;
|
|
}
|
|
.button {
|
|
background-color: #3b82f6;
|
|
border-radius: 6px;
|
|
color: #ffffff;
|
|
display: inline-block;
|
|
font-weight: 600;
|
|
margin: 16px 0;
|
|
padding: 12px 24px;
|
|
text-decoration: none;
|
|
}
|
|
.footer {
|
|
color: #64748b;
|
|
font-size: 14px;
|
|
margin-top: 32px;
|
|
text-align: center;
|
|
}
|
|
.email-table {
|
|
border-collapse: collapse;
|
|
text-align: left;
|
|
width: 100%;
|
|
}
|
|
.email-table th {
|
|
border-bottom: 1px solid rgba(11, 11, 11, 0.15); /* border-primary */
|
|
padding: 8px;
|
|
}
|
|
.email-table td {
|
|
border-bottom: 1px solid rgba(11, 11, 11, 0.1); /* border-secondary */
|
|
padding: 8px;
|
|
}
|
|
.email-table .text-right {
|
|
text-align: right;
|
|
}
|
|
</style>
|
|
</head>
|
|
|
|
<body>
|
|
<div class="container">
|
|
<%= yield %>
|
|
</div>
|
|
</body>
|
|
</html>
|