mirror of
https://github.com/we-promise/sure.git
synced 2026-09-08 16:14:23 +00:00
Brandon
fe0d27471d
* feat(bills): the bills pages, calendar feed and in-page AI helpers Second of three chunks carved out of #3083, stacked on the schema and domain core. This is everything a user sees and clicks. The whole surface sits behind the preview flag, so it is unreachable until someone opts in. Pages, all under one nav entry: - the pay run, a month calendar, the full bills table, and the paycheck planner - a detail drawer per bill, with payment history, price changes and cost analytics - create and edit flows for bills, subscriptions, installment plans and income The overview marks pay periods inside the month, so a weekly paycheck no longer reads as one undifferentiated month of bills. Markers appear only when income actually subdivides the month, which means monthly and undeclared income render exactly as before and there is no new setting to configure. Navigation and design system: - one preview-gated nav item shared by the desktop rail and the mobile bar - DS::Sparkline for payment-history charts, replacing raw SVG in views - status badges render through DS::Pill rather than hand-rolled spans - the suggestions panel is a disclosure that remembers being collapsed, per device, the way privacy mode and the sidebar width already do - every surface reflows to phone widths without horizontal scroll Calendar feed: a signed ICS feed per family, served sessionless by token, with a reset that revokes previously shared URLs. In-page AI helpers: smart fill on the bill form and a smart configuration proposal on an existing bill, each reading a bounded slice of charge history. Provider-side prompt assembly sits behind the existing LlmConcept interface, with an implementation for each of the two providers. These belong here rather than with the assistant tools because they are buttons on these pages and lean on the provider suggester, not on the tool registry. Suite 7,776 runs green apart from the pre-existing passkey-session flake, which passes standalone. Rubocop clean, eager loading verified. The hosting guide for the feature ships here rather than with the schema, since its instructions walk pages this PR introduces. * Render the suggested strip through DS::Disclosure The hand-rolled details pair predates the component. The card_inset variant is the same shape, so the strip now inherits the design system chrome, and the persisted-disclosure controller rides along unchanged. * Route the remaining hand-rolled chips through the design system The subscription-state chips, rule-match chips and match-reason chips become DS::Pill, with the state chips extracted to one shared partial so the drawer and the summary tab stop carrying copy-pasted markup. The AI prompt chips become DS::Button and the bills-index filter becomes DS::SearchInput, both of which this PR already uses elsewhere for the same shapes. * Fix erb_lint whitespace offenses in bills views * Address the post-ready review round * Require a writable destination account and gate the feed on preview * Reject an unresolvable declared account out loud
56 lines
1.6 KiB
Ruby
56 lines
1.6 KiB
Ruby
# A small labeled line-with-dots chart: one polyline over evenly spaced
|
|
# points, a dot per point (hollow when the value is zero), and a label under
|
|
# every other point.
|
|
#
|
|
# Extracted from the bill detail's twelve-month payment history so views stop
|
|
# hand-rolling SVG (raw SVG belongs in DS primitives). The component owns the
|
|
# geometry; the caller passes dated values and sets the color via a text-*
|
|
# class on `css`, which the strokes and fills pick up through currentColor.
|
|
class DS::Sparkline < DesignSystemComponent
|
|
WIDTH = 336
|
|
HEIGHT = 84
|
|
LEFT_PAD = 10
|
|
SPAN = 316.0
|
|
BASELINE_Y = 62
|
|
VALUE_HEIGHT = 48
|
|
LABEL_Y = 80
|
|
|
|
attr_reader :series, :aria_label, :css, :label_format
|
|
|
|
# series: [ [Date, Numeric], ... ] in display order.
|
|
def initialize(series:, aria_label:, css: "w-full text-success", label_format: "%b")
|
|
@series = series
|
|
@aria_label = aria_label
|
|
@css = css
|
|
@label_format = label_format
|
|
end
|
|
|
|
def points
|
|
@points ||= series.each_with_index.map do |(_label, value), index|
|
|
[ x_at(index), BASELINE_Y - (value.to_f / peak) * VALUE_HEIGHT, value ]
|
|
end
|
|
end
|
|
|
|
def polyline_points
|
|
points.map { |x, y, _| "#{x.round(1)},#{y.round(1)}" }.join(" ")
|
|
end
|
|
|
|
# Every other label keeps the axis readable at sparkline width.
|
|
def labels
|
|
series.each_with_index.filter_map do |(label, _value), index|
|
|
next unless index.even?
|
|
|
|
[ x_at(index).round(1), I18n.l(label, format: label_format) ]
|
|
end
|
|
end
|
|
|
|
private
|
|
def x_at(index)
|
|
LEFT_PAD + index * (SPAN / [ series.size - 1, 1 ].max)
|
|
end
|
|
|
|
def peak
|
|
@peak ||= [ series.map(&:last).max, 1 ].max.to_f
|
|
end
|
|
end
|