mirror of
https://github.com/we-promise/sure.git
synced 2026-09-09 08:34:26 +00:00
2bca87b856
* fix(demo): stop the goal-seeding matrix crashing rake demo_data:default
Several goals in the demo coverage matrix claimed the same account as a
100%-whole-account link (GoalAccount#whole_account_link_must_be_exclusive),
which only ever worked because they saved one at a time with nothing to
conflict with yet — the moment a second active goal wanted the same
account, save! raised and the whole task aborted.
Give every goal but one per account an explicit partial earmark instead of
a whole-account claim ("Long-term portfolio" keeps the whole of `primary`,
since its on_track pace needs most of that balance).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016GTNba5qE5NwzaHzbp27ye
* No need to overexplain inside the code.
---------
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: Juan José Mata <jjmata@jjmata.com>
74 lines
2.6 KiB
Ruby
74 lines
2.6 KiB
Ruby
require "test_helper"
|
|
|
|
class Demo::GeneratorTest < ActiveSupport::TestCase
|
|
setup do
|
|
@family = Family.create!(name: "Demo Family")
|
|
@admin_user = create_user!(@family, "demo-admin@example.com")
|
|
end
|
|
|
|
test "monitoring api key creation reassigns stale demo monitoring key owned by another user" do
|
|
stale_family = Family.create!(name: "Old Demo Family")
|
|
stale_user = create_user!(stale_family, "old-demo-admin@example.com")
|
|
stale_key = stale_user.api_keys.create!(
|
|
name: "monitoring",
|
|
key: ApiKey::DEMO_MONITORING_KEY,
|
|
scopes: [ "read" ],
|
|
source: "monitoring"
|
|
)
|
|
|
|
monitoring_key = Demo::Generator.new.send(:create_monitoring_api_key!, @family)
|
|
|
|
assert_equal stale_key.id, monitoring_key.id
|
|
assert_equal @admin_user, monitoring_key.user
|
|
assert_equal "monitoring", monitoring_key.source
|
|
assert_equal [ "read" ], monitoring_key.scopes
|
|
assert_equal 1, ApiKey.where(display_key: ApiKey::DEMO_MONITORING_KEY).count
|
|
end
|
|
|
|
test "monitoring api key creation reuses the current admin user's key" do
|
|
existing_key = @admin_user.api_keys.create!(
|
|
name: "monitoring",
|
|
key: ApiKey::DEMO_MONITORING_KEY,
|
|
scopes: [ "read" ],
|
|
source: "monitoring"
|
|
)
|
|
|
|
monitoring_key = Demo::Generator.new.send(:create_monitoring_api_key!, @family)
|
|
|
|
assert_equal existing_key, monitoring_key
|
|
assert_equal 1, ApiKey.where(display_key: ApiKey::DEMO_MONITORING_KEY).count
|
|
end
|
|
|
|
# Regression for a `rake demo_data:default` crash: the goal-seeding matrix
|
|
# linked several active goals to the same account as a 100%-whole-account
|
|
# claim each, which violates GoalAccount#whole_account_link_must_be_exclusive
|
|
# the moment the second one tries to save.
|
|
test "generate_goals! seeds the full matrix without raising" do
|
|
@family.update!(currency: "USD")
|
|
@family.accounts.create!(accountable: Depository.new, name: "Primary Checking",
|
|
currency: @family.currency, balance: 150_000)
|
|
@family.accounts.create!(accountable: Depository.new, name: "Secondary Savings",
|
|
currency: @family.currency, balance: 10_000)
|
|
|
|
assert_difference "@family.goals.count", 9 do
|
|
Demo::Generator.new.send(:generate_goals!, @family)
|
|
end
|
|
end
|
|
|
|
private
|
|
def create_user!(family, email)
|
|
family.users.create!(
|
|
first_name: "Demo",
|
|
last_name: "Admin",
|
|
email: email,
|
|
password: "password123",
|
|
role: :admin,
|
|
onboarded_at: Time.current,
|
|
ai_enabled: true,
|
|
show_sidebar: true,
|
|
show_ai_sidebar: true,
|
|
ui_layout: :dashboard
|
|
)
|
|
end
|
|
end
|