Files
sure/test/controllers/imports_controller_test.rb
Juan José Mata 8264943f23 Show disabled import options when no accounts exist (#977)
* Show disabled import options before accounts exist

Keep account-dependent import choices visible on /imports/new and render them as disabled with guidance when no accounts are available.

* Refactor disabled import options: extract partial, fix accessibility (#986)

- Extract _import_option partial to eliminate duplicated enabled/disabled
  markup across TransactionImport, TradeImport, and MintImport (also
  used by AccountImport, CategoryImport, RuleImport for consistency)
- Replace misleading chevron-right with lock icon in disabled state
- Add aria-disabled="true" for screen reader accessibility
- Remove redundant default: parameter from t() call
- Fix locale key ordering (requires_account after import_* keys)
- Fix extra blank line in test file
- Add assertion for aria-disabled attribute in test

https://claude.ai/code/session_016j9tDYEBfWX9Dzd99rAYjX

Co-authored-by: Claude <noreply@anthropic.com>

* Tailwind fixes

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-02-14 01:10:25 +01:00

138 lines
3.9 KiB
Ruby

require "test_helper"
class ImportsControllerTest < ActionDispatch::IntegrationTest
setup do
sign_in @user = users(:family_admin)
end
test "gets index" do
get imports_url
assert_response :success
@user.family.imports.ordered.each do |import|
assert_select "#" + dom_id(import), count: 1
end
end
test "gets new" do
get new_import_url
assert_response :success
assert_select "turbo-frame#modal"
end
test "shows disabled account-dependent imports when family has no accounts" do
sign_in users(:empty)
get new_import_url
assert_response :success
assert_select "button", text: "Import accounts"
assert_select "button", text: "Import transactions", count: 0
assert_select "button", text: "Import investments", count: 0
assert_select "button", text: "Import from Mint", count: 0
assert_select "span", text: "Import accounts first to unlock this option.", count: 3
assert_select "div[aria-disabled=true]", count: 3
end
test "creates import" do
assert_difference "Import.count", 1 do
post imports_url, params: {
import: {
type: "TransactionImport"
}
}
end
assert_redirected_to import_upload_url(Import.all.ordered.first)
end
test "uploads supported non-pdf document for vector store without creating import" do
adapter = mock("vector_store_adapter")
adapter.stubs(:supported_extensions).returns(%w[.csv .pdf])
VectorStore::Registry.stubs(:adapter).returns(adapter)
family_document = family_documents(:tax_return)
Family.any_instance.expects(:upload_document).with do |file_content:, filename:, **|
assert_not_empty file_content
assert_equal "valid.csv", filename
true
end.returns(family_document)
assert_no_difference "Import.count" do
post imports_url, params: {
import: {
type: "DocumentImport",
import_file: file_fixture_upload("imports/valid.csv", "text/csv")
}
}
end
assert_redirected_to new_import_url
assert_equal I18n.t("imports.create.document_uploaded"), flash[:notice]
end
test "uploads pdf document as PdfImport when using DocumentImport option" do
adapter = mock("vector_store_adapter")
adapter.stubs(:supported_extensions).returns(%w[.pdf .txt])
VectorStore::Registry.stubs(:adapter).returns(adapter)
@user.family.expects(:upload_document).never
assert_difference "Import.count", 1 do
post imports_url, params: {
import: {
type: "DocumentImport",
import_file: file_fixture_upload("imports/sample_bank_statement.pdf", "application/pdf")
}
}
end
created_import = Import.order(:created_at).last
assert_equal "PdfImport", created_import.type
assert_redirected_to import_url(created_import)
assert_equal I18n.t("imports.create.pdf_processing"), flash[:notice]
end
test "rejects unsupported document type for DocumentImport option" do
adapter = mock("vector_store_adapter")
adapter.stubs(:supported_extensions).returns(%w[.pdf .txt])
VectorStore::Registry.stubs(:adapter).returns(adapter)
assert_no_difference "Import.count" do
post imports_url, params: {
import: {
type: "DocumentImport",
import_file: file_fixture_upload("profile_image.png", "image/png")
}
}
end
assert_redirected_to new_import_url
assert_equal I18n.t("imports.create.invalid_document_file_type"), flash[:alert]
end
test "publishes import" do
import = imports(:transaction)
TransactionImport.any_instance.expects(:publish_later).once
post publish_import_url(import)
assert_equal "Your import has started in the background.", flash[:notice]
assert_redirected_to import_path(import)
end
test "destroys import" do
import = imports(:transaction)
assert_difference "Import.count", -1 do
delete import_url(import)
end
assert_redirected_to imports_path
end
end