Files
sure/test/system/onboardings_test.rb
tlink 9a9ebb147b Add localization for onboarding goals across multiple languages (#873)
* Add localization for onboarding goals across multiple languages

* Add password requirements localization for multiple languages

* Refactor localization keys for authentication messages

* Add `oidc` localization key for multiple languages

* Add OIDC account localization for multiple languages

* Add localization for trial and profile setup across multiple languages

* Refactor OIDC button label fallback to prioritize label presence over localization key

* Refactor onboarding tests to use I18n for text assertions and button labels

* Linter

* Last test fix?!?

* We keep both `oidc` and `openid_connect` due to contatenation issues

---------

Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
2026-02-03 14:49:21 +01:00

209 lines
6.3 KiB
Ruby

require "application_system_test_case"
class OnboardingsTest < ApplicationSystemTestCase
setup do
@user = users(:family_admin)
@family = @user.family
# Reset onboarding state
@user.update!(set_onboarding_preferences_at: nil)
# Force English locale for tests
I18n.locale = :en
sign_in @user
end
teardown do
I18n.locale = I18n.default_locale
end
test "can complete the full onboarding flow" do
# Start at the main onboarding page
visit onboarding_path
assert_text I18n.t("onboardings.show.title")
assert_button I18n.t("onboardings.show.submit")
# Navigate to preferences
click_button I18n.t("onboardings.show.submit")
assert_current_path preferences_onboarding_path
assert_text I18n.t("onboardings.preferences.title")
# Test that the chart renders without errors (this would catch the Series bug)
assert_selector "[data-controller='time-series-chart']"
# Fill out preferences form
select "English (en)", from: "user_family_attributes_locale"
select "United States Dollar (USD)", from: "user_family_attributes_currency"
select "MM/DD/YYYY", from: "user_family_attributes_date_format"
select_theme("light")
# Submit preferences
click_button I18n.t("onboardings.preferences.submit")
# Should redirect to goals page
assert_current_path goals_onboarding_path
assert_text I18n.t("onboardings.goals.title")
end
test "preferences page renders chart without errors" do
visit preferences_onboarding_path
# This test specifically targets the Series model bug
# The chart should render without throwing JavaScript errors
assert_selector "[data-controller='time-series-chart']"
assert_selector "#previewChart"
# Verify the chart data is properly formatted JSON
chart_element = find("[data-controller='time-series-chart']")
chart_data = chart_element["data-time-series-chart-data-value"]
# Should be valid JSON
assert_nothing_raised do
JSON.parse(chart_data)
end
# Verify the preview example shows
assert_text I18n.t("onboardings.preferences.example")
assert_text "$2,325.25"
assert_text "+$78.90"
end
test "can change currency and see preview update" do
visit preferences_onboarding_path
# Change currency
select "Euro (EUR)", from: "user_family_attributes_currency"
# The preview should update (this tests the JavaScript controller)
# Note: This would require the onboarding controller to handle currency changes
assert_text I18n.t("onboardings.preferences.example")
end
test "can change date format and see preview update" do
visit preferences_onboarding_path
# Change date format
select "DD/MM/YYYY", from: "user_family_attributes_date_format"
# The preview should update
assert_text I18n.t("onboardings.preferences.example")
end
test "can change theme" do
visit preferences_onboarding_path
# Change theme using value instead of label
select_theme("dark")
# Theme should be applied (this tests the JavaScript controller)
assert_text I18n.t("onboardings.preferences.example")
end
test "preferences form validation" do
visit preferences_onboarding_path
# Clear required fields and try to submit
select "", from: "user_family_attributes_locale"
click_button I18n.t("onboardings.preferences.submit")
# Should stay on preferences page with validation errors (may have query params)
assert_match %r{/onboarding/preferences}, current_path
end
test "preferences form saves data correctly" do
visit preferences_onboarding_path
# Fill out form with specific values
select "Spanish (es)", from: "user_family_attributes_locale"
select "Euro (EUR)", from: "user_family_attributes_currency"
select "DD/MM/YYYY", from: "user_family_attributes_date_format"
select_theme("dark")
# Button text is in Spanish due to locale preview
click_button I18n.t("onboardings.preferences.submit", locale: :es)
# Wait for redirect to goals page to ensure form was submitted
assert_current_path goals_onboarding_path
# Verify data was saved
@family.reload
@user.reload
assert_equal "es", @family.locale
assert_equal "EUR", @family.currency
assert_equal "%d/%m/%Y", @family.date_format
assert_equal "dark", @user.theme
assert_not_nil @user.set_onboarding_preferences_at
end
test "goals page renders correctly" do
# Complete preferences first
@user.update!(set_onboarding_preferences_at: Time.current)
visit goals_onboarding_path
assert_text I18n.t("onboardings.goals.title")
assert_button I18n.t("onboardings.goals.submit")
end
test "trial page renders correctly" do
visit trial_onboarding_path
assert_text "Sure"
end
test "navigation between onboarding steps" do
# Start at main onboarding
visit onboarding_path
click_button I18n.t("onboardings.show.submit")
# Should be at preferences
assert_current_path preferences_onboarding_path
# Complete preferences
select "English (en)", from: "user_family_attributes_locale"
select "United States Dollar (USD)", from: "user_family_attributes_currency"
select "MM/DD/YYYY", from: "user_family_attributes_date_format"
click_button I18n.t("onboardings.preferences.submit")
# Should be at goals
assert_current_path goals_onboarding_path
end
test "onboarding nav shows correct steps" do
visit preferences_onboarding_path
# Check that navigation shows current step
assert_selector "ul.hidden.md\\:flex.items-center.gap-2"
end
test "logout option is available during onboarding" do
visit preferences_onboarding_path
# Should have logout option (rendered as a button component)
assert_text I18n.t("onboardings.logout.sign_out")
end
private
def select_theme(value)
find("#user_theme", visible: :all)
.find("option[value='#{value}']", visible: :all)
.select_option
end
def sign_in(user)
visit new_session_path
within %(form[action='#{sessions_path}']) do
fill_in I18n.t("sessions.new.email"), with: user.email
fill_in I18n.t("sessions.new.password"), with: user_password_test
click_on I18n.t("sessions.new.submit")
end
# Wait for successful login
assert_current_path root_path
end
end