Files
sure/app/javascript/controllers/dashboard_sortable_controller.js
juan f37378b2ff Revert edge-based insertion, restore center-point drag algorithm
Edge-based insertion was too restrictive for tall uncollapsed sections
since the gap between them is only ~24px. The center-point approach
works better for the common case. The key improvements (800ms hold
delay, native dragstart cancellation, text selection prevention,
Euclidean movement cancellation) remain.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 23:44:48 -07:00

375 lines
9.9 KiB
JavaScript

import { Controller } from "@hotwired/stimulus";
export default class extends Controller {
static targets = ["section", "handle"];
// Hold delay to require deliberate press-and-hold before activating drag mode
static values = {
holdDelay: { type: Number, default: 800 },
};
connect() {
this.draggedElement = null;
this.placeholder = null;
this.touchStartY = 0;
this.currentTouchX = 0;
this.currentTouchY = 0;
this.isTouching = false;
this.keyboardGrabbedElement = null;
this.holdTimer = null;
this.holdActivated = false;
}
// ===== Mouse Drag Events =====
dragStart(event) {
// On touch devices, cancel native drag — use touch events with hold delay instead
if (this.isTouchDevice()) {
event.preventDefault();
return;
}
this.draggedElement = event.currentTarget;
this.draggedElement.classList.add("opacity-50");
this.draggedElement.setAttribute("aria-grabbed", "true");
event.dataTransfer.effectAllowed = "move";
}
isTouchDevice() {
return "ontouchstart" in window || navigator.maxTouchPoints > 0;
}
dragEnd(event) {
event.currentTarget.classList.remove("opacity-50");
event.currentTarget.setAttribute("aria-grabbed", "false");
this.clearPlaceholders();
}
dragOver(event) {
event.preventDefault();
event.dataTransfer.dropEffect = "move";
const afterElement = this.getDragAfterElement(event.clientX, event.clientY);
const container = this.element;
this.clearPlaceholders();
if (afterElement == null) {
this.showPlaceholder(container.lastElementChild, "after");
} else {
this.showPlaceholder(afterElement, "before");
}
}
drop(event) {
event.preventDefault();
event.stopPropagation();
const afterElement = this.getDragAfterElement(event.clientX, event.clientY);
const container = this.element;
if (afterElement == null) {
container.appendChild(this.draggedElement);
} else {
container.insertBefore(this.draggedElement, afterElement);
}
this.clearPlaceholders();
this.saveOrder();
}
// ===== Touch Events =====
// Touch events are bound to the drag handle only, with a short hold delay
// to prevent accidental touches.
touchStart(event) {
// Find the parent section element from the handle
const section = event.currentTarget.closest(
"[data-dashboard-sortable-target='section']",
);
if (!section) return;
// Respect strict draggable="false" which might be set by other controllers (e.g. expand-controller)
if (section.getAttribute("draggable") === "false") return;
this.pendingSection = section;
this.touchStartX = event.touches[0].clientX;
this.touchStartY = event.touches[0].clientY;
this.currentTouchX = this.touchStartX;
this.currentTouchY = this.touchStartY;
this.holdActivated = false;
// Prevent text selection while waiting for hold to activate
section.style.userSelect = "none";
section.style.webkitUserSelect = "none";
// Start hold timer
this.holdTimer = setTimeout(() => {
this.activateDrag();
}, this.holdDelayValue);
}
activateDrag() {
if (!this.pendingSection) return;
this.holdActivated = true;
this.isTouching = true;
this.draggedElement = this.pendingSection;
this.draggedElement.classList.add("opacity-50", "scale-[1.02]");
this.draggedElement.setAttribute("aria-grabbed", "true");
// Haptic feedback if available
if (navigator.vibrate) {
navigator.vibrate(30);
}
}
touchMove(event) {
const touchX = event.touches[0].clientX;
const touchY = event.touches[0].clientY;
// If hold hasn't activated yet, cancel if user moves too far (scrolling or swiping)
// Uses Euclidean distance to catch diagonal gestures too
if (!this.holdActivated) {
const dx = touchX - this.touchStartX;
const dy = touchY - this.touchStartY;
if (dx * dx + dy * dy > 100) { // 10px radius
this.cancelHold();
}
return;
}
if (!this.isTouching || !this.draggedElement) return;
event.preventDefault();
this.currentTouchX = touchX;
this.currentTouchY = touchY;
const afterElement = this.getDragAfterElement(this.currentTouchX, this.currentTouchY);
this.clearPlaceholders();
if (afterElement == null) {
this.showPlaceholder(this.element.lastElementChild, "after");
} else {
this.showPlaceholder(afterElement, "before");
}
}
touchEnd() {
this.cancelHold();
if (!this.holdActivated || !this.isTouching || !this.draggedElement) {
this.resetTouchState();
return;
}
const afterElement = this.getDragAfterElement(this.currentTouchX, this.currentTouchY);
const container = this.element;
if (afterElement == null) {
container.appendChild(this.draggedElement);
} else {
container.insertBefore(this.draggedElement, afterElement);
}
this.draggedElement.classList.remove("opacity-50", "scale-[1.02]");
this.draggedElement.setAttribute("aria-grabbed", "false");
this.clearPlaceholders();
this.saveOrder();
this.resetTouchState();
}
cancelHold() {
if (this.holdTimer) {
clearTimeout(this.holdTimer);
this.holdTimer = null;
}
}
resetTouchState() {
// Restore text selection
if (this.pendingSection) {
this.pendingSection.style.userSelect = "";
this.pendingSection.style.webkitUserSelect = "";
}
if (this.draggedElement) {
this.draggedElement.style.userSelect = "";
this.draggedElement.style.webkitUserSelect = "";
}
this.isTouching = false;
this.draggedElement = null;
this.pendingSection = null;
this.holdActivated = false;
}
// ===== Keyboard Navigation =====
handleKeyDown(event) {
const currentSection = event.currentTarget;
switch (event.key) {
case "ArrowUp":
event.preventDefault();
if (this.keyboardGrabbedElement === currentSection) {
this.moveUp(currentSection);
}
break;
case "ArrowDown":
event.preventDefault();
if (this.keyboardGrabbedElement === currentSection) {
this.moveDown(currentSection);
}
break;
case "Enter":
case " ":
event.preventDefault();
this.toggleGrabMode(currentSection);
break;
case "Escape":
if (this.keyboardGrabbedElement) {
event.preventDefault();
this.releaseKeyboardGrab();
}
break;
}
}
toggleGrabMode(section) {
if (this.keyboardGrabbedElement === section) {
this.releaseKeyboardGrab();
} else {
this.grabWithKeyboard(section);
}
}
grabWithKeyboard(section) {
// Release any previously grabbed element
if (this.keyboardGrabbedElement) {
this.releaseKeyboardGrab();
}
this.keyboardGrabbedElement = section;
section.setAttribute("aria-grabbed", "true");
section.classList.add("ring-2", "ring-primary", "ring-offset-2");
}
releaseKeyboardGrab() {
if (this.keyboardGrabbedElement) {
this.keyboardGrabbedElement.setAttribute("aria-grabbed", "false");
this.keyboardGrabbedElement.classList.remove(
"ring-2",
"ring-primary",
"ring-offset-2",
);
this.keyboardGrabbedElement = null;
this.saveOrder();
}
}
moveUp(section) {
const previousSibling = section.previousElementSibling;
if (previousSibling?.hasAttribute("data-section-key")) {
this.element.insertBefore(section, previousSibling);
section.focus();
}
}
moveDown(section) {
const nextSibling = section.nextElementSibling;
if (nextSibling?.hasAttribute("data-section-key")) {
this.element.insertBefore(nextSibling, section);
section.focus();
}
}
getDragAfterElement(pointerX, pointerY) {
const draggableElements = this.sectionTargets.filter(
(section) => section !== this.draggedElement,
);
if (draggableElements.length === 0) return null;
let closest = null;
let minDistance = Number.POSITIVE_INFINITY;
draggableElements.forEach((child) => {
const rect = child.getBoundingClientRect();
const centerX = rect.left + rect.width / 2;
const centerY = rect.top + rect.height / 2;
const dx = pointerX - centerX;
const dy = pointerY - centerY;
const distance = Math.sqrt(dx * dx + dy * dy);
if (distance < minDistance) {
minDistance = distance;
closest = child;
}
});
return closest;
}
showPlaceholder(element, position) {
if (!element) return;
if (position === "before") {
element.classList.add("border-t-4", "border-primary");
} else {
element.classList.add("border-b-4", "border-primary");
}
}
clearPlaceholders() {
this.sectionTargets.forEach((section) => {
section.classList.remove(
"border-t-4",
"border-b-4",
"border-primary",
"border-t-2",
"border-b-2",
);
});
}
async saveOrder() {
const order = this.sectionTargets.map(
(section) => section.dataset.sectionKey,
);
// Safely obtain CSRF token
const csrfToken = document.querySelector('meta[name="csrf-token"]');
if (!csrfToken) {
console.error(
"[Dashboard Sortable] CSRF token not found. Cannot save section order.",
);
return;
}
try {
const response = await fetch("/dashboard/preferences", {
method: "PATCH",
headers: {
"Content-Type": "application/json",
"X-CSRF-Token": csrfToken.content,
},
body: JSON.stringify({ preferences: { section_order: order } }),
});
if (!response.ok) {
const errorData = await response.json().catch(() => ({}));
console.error(
"[Dashboard Sortable] Failed to save section order:",
response.status,
errorData,
);
}
} catch (error) {
console.error(
"[Dashboard Sortable] Network error saving section order:",
error,
);
}
}
}