mirror of
https://github.com/we-promise/sure.git
synced 2026-06-01 00:39:01 +00:00
174f7e6be6
* feat(binance): add full account sync and transaction processing - Fixed a bug that hindered Account setup - Wire up Binance accounts, sync statistics, and unlinked account tracking in the accounts dashboard. - Support setting a sync_start_date during Binance account setup. - Set Binance accounts' opening balance to zero to ensure the ledger builds cleanly from the actual trade history. - Expand the Binance importer and processor to handle Spot, Margin, Earn, P2P, and Futures trades and assets. - Implement TransactionBuilder to parse raw Binance trades, accurately calculating fees, base/quote asset amounts, and market values for proper ledger integration. - Update Binance API timeout (`recvWindow`) to 60,000ms to prevent connection drops. These changes provide comprehensive support for tracking Binance portfolios, ensuring accurate historical ledgers and proper visibility of sync statuses in the frontend dashboard. * refactor(binance): enforce strong params, double-entry safety, and native fiat currency support - Implement strong parameters in BinanceItemsController#complete_account_setup to satisfy Rails security guidelines. - Add robust date parsing with a grace fallback to prevent controller crashes on malformed sync start dates. - Wrap P2P transaction creations inside a database transaction block to guarantee ledger integrity and prevent orphan records. - Optimize P2P deduplication queries by batching checks for both transaction and funding external IDs. - Shift P2P entry persistence from forced USD tracking to native fiat values extracted directly from the Binance API payload. - Update BinanceAccount::ProcessorTest assertions and fixtures to validate native fiat and fee calculation logic. * fix(binance): process sync trades before caching transaction payload - Reorder Binance processor execution to insert trade records into the database prior to updating the `raw_transactions_payload` cache. This guarantees that if a database insertion fails, the cache won't prematurely mark the sync as successful, ensuring the data is retried on the next run. - Move `set_opening_anchor_balance(balance: 0)` out of the generic crypto exchange account builder and apply it specifically during Binance account creation. - Refactor date parsing in BinanceItemsController to explicitly catch `ArgumentError` via a block instead of using a blanket inline `rescue`. - Clean up the `setup_accounts` view template by removing hardcoded default translation strings. * fix(binance): enhance trade sync logic and error propagation - Pass `startTime` (from `sync_start_date`) to spot and futures trade endpoints on initial sync to optimize data fetching. - Include previously synced futures pairs alongside spot pairs when resolving relevant symbols to properly recover sold-out assets. - Re-raise exceptions in processor rescue blocks to prevent silent failures and ensure errors are correctly propagated to background jobs. - Decrease Binance API `recvWindow` from 60000ms to 5000ms to align with recommended default timeout values.
106 lines
3.4 KiB
Ruby
106 lines
3.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
# Orchestrates all Binance sub-importers and upserts a single combined BinanceAccount.
|
|
class BinanceItem::Importer
|
|
attr_reader :binance_item, :binance_provider
|
|
|
|
def initialize(binance_item, binance_provider:)
|
|
@binance_item = binance_item
|
|
@binance_provider = binance_provider
|
|
end
|
|
|
|
def import
|
|
Rails.logger.info "BinanceItem::Importer #{binance_item.id} - starting import"
|
|
|
|
spot_result = BinanceItem::SpotImporter.new(binance_item, provider: binance_provider).import
|
|
margin_result = BinanceItem::MarginImporter.new(binance_item, provider: binance_provider).import
|
|
earn_result = BinanceItem::EarnImporter.new(binance_item, provider: binance_provider).import
|
|
futures_result = BinanceItem::FuturesImporter.new(binance_item, provider: binance_provider).import
|
|
|
|
all_assets = tagged_assets(spot_result) + tagged_assets(margin_result) + tagged_assets(earn_result) + tagged_assets(futures_result)
|
|
|
|
return { success: true, assets_imported: 0, total_usd: 0 } if all_assets.empty?
|
|
|
|
total_usd = calculate_total_usd(all_assets)
|
|
|
|
upsert_binance_account(
|
|
all_assets: all_assets,
|
|
total_usd: total_usd,
|
|
spot_raw: spot_result[:raw],
|
|
margin_raw: margin_result[:raw],
|
|
earn_raw: earn_result[:raw],
|
|
futures_raw: futures_result[:raw]
|
|
)
|
|
|
|
binance_item.upsert_binance_snapshot!({
|
|
"spot" => spot_result[:raw],
|
|
"margin" => margin_result[:raw],
|
|
"earn" => earn_result[:raw],
|
|
"futures" => futures_result[:raw],
|
|
"imported_at" => Time.current.iso8601
|
|
})
|
|
|
|
Rails.logger.info "BinanceItem::Importer #{binance_item.id} - imported #{all_assets.size} assets, total_usd=#{total_usd}"
|
|
|
|
{ success: true, assets_imported: all_assets.size, total_usd: total_usd }
|
|
end
|
|
|
|
private
|
|
|
|
def tagged_assets(result)
|
|
result[:assets].map { |a| a.merge(source: result[:source]) }
|
|
end
|
|
|
|
def calculate_total_usd(assets)
|
|
assets.sum do |asset|
|
|
quantity = asset[:total].to_d
|
|
next 0 if quantity.zero?
|
|
|
|
price = price_for(asset[:symbol])
|
|
quantity * price
|
|
end.round(2)
|
|
end
|
|
|
|
def price_for(symbol)
|
|
return 1.0 if BinanceAccount::STABLECOINS.include?(symbol)
|
|
|
|
price = binance_provider.get_spot_price("#{symbol}USDT")
|
|
price.to_d
|
|
rescue => e
|
|
Rails.logger.warn "BinanceItem::Importer - could not get price for #{symbol}: #{e.message}"
|
|
0
|
|
end
|
|
|
|
def upsert_binance_account(all_assets:, total_usd:, spot_raw:, margin_raw:, earn_raw:, futures_raw:)
|
|
ba = binance_item.binance_accounts.find_or_initialize_by(account_type: "combined")
|
|
|
|
ba.assign_attributes(
|
|
name: binance_item.institution_name.presence || "Binance",
|
|
currency: "USD",
|
|
current_balance: total_usd,
|
|
institution_metadata: build_institution_metadata(all_assets),
|
|
raw_payload: {
|
|
"spot" => spot_raw,
|
|
"margin" => margin_raw,
|
|
"earn" => earn_raw,
|
|
"futures" => futures_raw,
|
|
"assets" => all_assets.map(&:stringify_keys),
|
|
"fetched_at" => Time.current.iso8601
|
|
}
|
|
)
|
|
|
|
ba.save!
|
|
ba
|
|
end
|
|
|
|
def build_institution_metadata(all_assets)
|
|
%w[spot margin earn futures].each_with_object({}) do |source, hash|
|
|
source_assets = all_assets.select { |a| a[:source] == source }
|
|
hash[source] = {
|
|
"asset_count" => source_assets.size,
|
|
"assets" => source_assets.map { |a| a[:symbol] }
|
|
}
|
|
end
|
|
end
|
|
end
|