mirror of
https://github.com/we-promise/sure.git
synced 2026-06-01 00:39:01 +00:00
174f7e6be6
* feat(binance): add full account sync and transaction processing - Fixed a bug that hindered Account setup - Wire up Binance accounts, sync statistics, and unlinked account tracking in the accounts dashboard. - Support setting a sync_start_date during Binance account setup. - Set Binance accounts' opening balance to zero to ensure the ledger builds cleanly from the actual trade history. - Expand the Binance importer and processor to handle Spot, Margin, Earn, P2P, and Futures trades and assets. - Implement TransactionBuilder to parse raw Binance trades, accurately calculating fees, base/quote asset amounts, and market values for proper ledger integration. - Update Binance API timeout (`recvWindow`) to 60,000ms to prevent connection drops. These changes provide comprehensive support for tracking Binance portfolios, ensuring accurate historical ledgers and proper visibility of sync statuses in the frontend dashboard. * refactor(binance): enforce strong params, double-entry safety, and native fiat currency support - Implement strong parameters in BinanceItemsController#complete_account_setup to satisfy Rails security guidelines. - Add robust date parsing with a grace fallback to prevent controller crashes on malformed sync start dates. - Wrap P2P transaction creations inside a database transaction block to guarantee ledger integrity and prevent orphan records. - Optimize P2P deduplication queries by batching checks for both transaction and funding external IDs. - Shift P2P entry persistence from forced USD tracking to native fiat values extracted directly from the Binance API payload. - Update BinanceAccount::ProcessorTest assertions and fixtures to validate native fiat and fee calculation logic. * fix(binance): process sync trades before caching transaction payload - Reorder Binance processor execution to insert trade records into the database prior to updating the `raw_transactions_payload` cache. This guarantees that if a database insertion fails, the cache won't prematurely mark the sync as successful, ensuring the data is retried on the next run. - Move `set_opening_anchor_balance(balance: 0)` out of the generic crypto exchange account builder and apply it specifically during Binance account creation. - Refactor date parsing in BinanceItemsController to explicitly catch `ArgumentError` via a block instead of using a blanket inline `rescue`. - Clean up the `setup_accounts` view template by removing hardcoded default translation strings. * fix(binance): enhance trade sync logic and error propagation - Pass `startTime` (from `sync_start_date`) to spot and futures trade endpoints on initial sync to optimize data fetching. - Include previously synced futures pairs alongside spot pairs when resolving relevant symbols to properly recover sold-out assets. - Re-raise exceptions in processor rescue blocks to prevent silent failures and ensure errors are correctly propagated to background jobs. - Decrease Binance API `recvWindow` from 60000ms to 5000ms to align with recommended default timeout values.
43 lines
1.5 KiB
Ruby
43 lines
1.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "test_helper"
|
|
|
|
class BinanceItem::FuturesImporterTest < ActiveSupport::TestCase
|
|
setup do
|
|
@provider = mock
|
|
@family = families(:dylan_family)
|
|
@item = BinanceItem.create!(family: @family, name: "B", api_key: "k", api_secret: "s")
|
|
end
|
|
|
|
test "returns normalized assets from USDⓈ-M futures with source=futures" do
|
|
@provider.stubs(:get_futures_account).returns({
|
|
"assets" => [
|
|
{ "asset" => "USDT", "walletBalance" => "100.0", "unrealizedProfit" => "5.0", "availableBalance" => "90.0" },
|
|
{ "asset" => "BUSD", "walletBalance" => "0.0", "unrealizedProfit" => "0.0", "availableBalance" => "0.0" }
|
|
],
|
|
"positions" => [
|
|
{ "symbol" => "BTCUSDT", "positionAmt" => "0.5" }
|
|
]
|
|
})
|
|
|
|
result = BinanceItem::FuturesImporter.new(@item, provider: @provider).import
|
|
|
|
assert_equal "futures", result[:source]
|
|
assert_equal 1, result[:assets].size
|
|
usdt = result[:assets].first
|
|
assert_equal "USDT", usdt[:symbol]
|
|
assert_equal "105.0", usdt[:total] # walletBalance + unrealizedProfit
|
|
assert_equal "90.0", usdt[:free]
|
|
assert_equal "10.0", usdt[:locked] # walletBalance - availableBalance
|
|
end
|
|
|
|
test "returns empty on API error" do
|
|
@provider.stubs(:get_futures_account).raises(Provider::Binance::ApiError, "WAF")
|
|
|
|
result = BinanceItem::FuturesImporter.new(@item, provider: @provider).import
|
|
|
|
assert_equal "futures", result[:source]
|
|
assert_equal [], result[:assets]
|
|
end
|
|
end
|