mirror of
https://github.com/we-promise/sure.git
synced 2026-04-07 14:31:25 +00:00
* Add Google SSO onboarding flow for Flutter mobile app Previously, mobile users attempting Google SSO without a linked OIDC identity received an error telling them to link from the web app first. This adds the same account linking/creation flow that exists on the PWA. Backend changes: - sessions_controller: Cache pending OIDC auth with a linking code and redirect back to the app instead of returning an error - api/v1/auth_controller: Add sso_link endpoint to link Google identity to an existing account via email/password, and sso_create_account endpoint to create a new SSO-only account (respects JIT config) - routes: Add POST auth/sso_link and auth/sso_create_account Flutter changes: - auth_service: Detect account_not_linked callback status, add ssoLink and ssoCreateAccount API methods - auth_provider: Track SSO onboarding state, expose linking/creation methods and cancelSsoOnboarding - sso_onboarding_screen: New screen with tabs to link existing account or create new account, pre-filled with Google profile data - main.dart: Show SsoOnboardingScreen when ssoOnboardingPending is true https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Fix broken SSO tests: use MemoryStore cache and correct redirect param - Sessions test: check `status` param instead of `error` since handle_mobile_sso_onboarding sends linking info with status key - API auth tests: swap null_store for MemoryStore so cache-based linking code validation works in test environment https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Delay linking-code consumption until SSO link/create succeeds Split validate_and_consume_linking_code into validate_linking_code (read-only) and consume_linking_code! (delete). The code is now only consumed after password verification (sso_link) or successful user save (sso_create_account), so recoverable errors no longer burn the one-time code and force a full Google SSO roundtrip. https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Make linking-code consumption atomic to prevent race conditions Move consume_linking_code! (backed by Rails.cache.delete) to after recoverable checks (bad password, policy rejection) but before side-effecting operations (identity/user creation). Only the first caller to delete the cache key gets true, so concurrent requests with the same code cannot both succeed. - sso_link: consume after password auth, before OidcIdentity creation - sso_create_account: consume after allow_account_creation check, before User creation - Bad password still preserves the code for retry - Add single-use regression tests for both endpoints https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Add missing sso_create_account test coverage for blank code and validation failure - Test blank linking_code returns 400 (bad_request) with proper error - Test duplicate email triggers user.save failure → 422 with validation errors https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Verify cache payload in mobile SSO onboarding test with MemoryStore The test environment uses :null_store which silently discards cache writes, so handle_mobile_sso_onboarding's Rails.cache.write was never verified. Swap in a MemoryStore for this test and assert the full cached payload (provider, uid, email, name, device_info, allow_account_creation) at the linking_code key from the redirect URL. https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Add rswag/OpenAPI specs for sso_link and sso_create_account endpoints POST /api/v1/auth/sso_link: documents linking_code + email/password params, 200 (tokens), 400 (missing code), 401 (invalid creds/expired). POST /api/v1/auth/sso_create_account: documents linking_code + optional first_name/last_name params, 200 (tokens), 400 (missing code), 401 (expired code), 403 (creation disabled), 422 (validation errors). Note: RAILS_ENV=test bundle exec rake rswag:specs:swaggerize should be run to regenerate docs/api/openapi.yaml once the runtime environment matches the Gemfile Ruby version. https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Preserve OIDC issuer through mobile SSO onboarding flow handle_mobile_sso_onboarding now caches the issuer from auth.extra.raw_info.iss so it survives the linking-code round trip. build_omniauth_hash populates extra.raw_info.iss from the cached issuer so OidcIdentity.create_from_omniauth stores it correctly. Previously the issuer was always nil for mobile SSO-created identities because build_omniauth_hash passed an empty raw_info OpenStruct. https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Block MFA users from bypassing second factor via sso_link sso_link authenticated with email/password but never checked user.otp_required?, allowing MFA users to obtain tokens without a second factor. The mobile SSO callback already rejects MFA users with "mfa_not_supported"; apply the same guard in sso_link before consuming the linking code or creating an identity. Returns 401 with mfa_required: true, consistent with the login action's MFA response shape. https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Fix NoMethodError in SSO link MFA test Replace non-existent User.generate_otp_secret class method with ROTP::Base32.random(32), matching the pattern used in User#setup_mfa!. https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c * Assert linking code survives rejected SSO create account Add cache persistence assertion to "should reject SSO create account when not allowed" test, verifying the linking code is not consumed on the 403 path. This mirrors the pattern used in the invalid-password sso_link test. The other rejection tests (expired/missing linking code) don't have a valid cached code to check, so no assertion is needed there. https://claude.ai/code/session_011ag1qSfriUg6j7TqFgbS5c --------- Co-authored-by: Claude <noreply@anthropic.com>
380 lines
13 KiB
Ruby
380 lines
13 KiB
Ruby
class SessionsController < ApplicationController
|
|
extend SslConfigurable
|
|
|
|
before_action :set_session, only: :destroy
|
|
skip_authentication only: %i[index new create openid_connect failure post_logout mobile_sso_start]
|
|
|
|
layout "auth"
|
|
|
|
# Handle GET /sessions (usually from browser back button)
|
|
def index
|
|
redirect_to new_session_path
|
|
end
|
|
|
|
def new
|
|
store_pending_invitation_if_valid
|
|
# Clear any stale mobile SSO session flag from an abandoned mobile flow
|
|
session.delete(:mobile_sso)
|
|
|
|
begin
|
|
demo = Rails.application.config_for(:demo)
|
|
@prefill_demo_credentials = demo_host_match?(demo)
|
|
if @prefill_demo_credentials
|
|
@email = params[:email].presence || demo["email"]
|
|
@password = params[:password].presence || demo["password"]
|
|
else
|
|
@email = params[:email]
|
|
@password = params[:password]
|
|
end
|
|
rescue RuntimeError, Errno::ENOENT, Psych::SyntaxError
|
|
# Demo config file missing or malformed - disable demo credential prefilling
|
|
@prefill_demo_credentials = false
|
|
@email = params[:email]
|
|
@password = params[:password]
|
|
end
|
|
end
|
|
|
|
def create
|
|
# Clear any stale mobile SSO session flag from an abandoned mobile flow
|
|
session.delete(:mobile_sso)
|
|
|
|
user = nil
|
|
|
|
if AuthConfig.local_login_enabled?
|
|
user = User.authenticate_by(email: params[:email], password: params[:password])
|
|
else
|
|
# Local login is disabled. Only allow attempts when an emergency super-admin
|
|
# override is enabled and the email belongs to a super-admin.
|
|
if AuthConfig.local_admin_override_enabled?
|
|
candidate = User.find_by(email: params[:email])
|
|
unless candidate&.super_admin?
|
|
redirect_to new_session_path, alert: t("sessions.create.local_login_disabled")
|
|
return
|
|
end
|
|
|
|
user = User.authenticate_by(email: params[:email], password: params[:password])
|
|
else
|
|
redirect_to new_session_path, alert: t("sessions.create.local_login_disabled")
|
|
return
|
|
end
|
|
end
|
|
|
|
if user
|
|
if user.otp_required?
|
|
log_super_admin_override_login(user)
|
|
session[:mfa_user_id] = user.id
|
|
redirect_to verify_mfa_path
|
|
else
|
|
log_super_admin_override_login(user)
|
|
@session = create_session_for(user)
|
|
flash[:notice] = t("invitations.accept_choice.joined_household") if accept_pending_invitation_for(user)
|
|
redirect_to root_path
|
|
end
|
|
else
|
|
flash.now[:alert] = t(".invalid_credentials")
|
|
render :new, status: :unprocessable_entity
|
|
end
|
|
end
|
|
|
|
def destroy
|
|
user = Current.user
|
|
id_token = session[:id_token_hint]
|
|
login_provider = session[:sso_login_provider]
|
|
|
|
# Find the identity for the provider used during login, with fallback to first if session data lost
|
|
oidc_identity = if login_provider.present?
|
|
user.oidc_identities.find_by(provider: login_provider)
|
|
else
|
|
user.oidc_identities.first
|
|
end
|
|
|
|
# Destroy local session
|
|
@session.destroy
|
|
session.delete(:id_token_hint)
|
|
session.delete(:sso_login_provider)
|
|
|
|
# Check if we should redirect to IdP for federated logout
|
|
if oidc_identity && id_token.present?
|
|
idp_logout_url = build_idp_logout_url(oidc_identity, id_token)
|
|
|
|
if idp_logout_url
|
|
SsoAuditLog.log_logout_idp!(user: user, provider: oidc_identity.provider, request: request)
|
|
redirect_to idp_logout_url, allow_other_host: true
|
|
return
|
|
end
|
|
end
|
|
|
|
# Standard local logout
|
|
SsoAuditLog.log_logout!(user: user, request: request)
|
|
redirect_to new_session_path, notice: t(".logout_successful")
|
|
end
|
|
|
|
# Handle redirect back from IdP after federated logout
|
|
def post_logout
|
|
redirect_to new_session_path, notice: t(".logout_successful")
|
|
end
|
|
|
|
def mobile_sso_start
|
|
provider = params[:provider].to_s
|
|
configured_providers = Rails.configuration.x.auth.sso_providers.map { |p| p[:name].to_s }
|
|
|
|
unless configured_providers.include?(provider)
|
|
mobile_sso_redirect(error: "invalid_provider", message: "SSO provider not configured")
|
|
return
|
|
end
|
|
|
|
device_params = params.permit(:device_id, :device_name, :device_type, :os_version, :app_version)
|
|
unless device_params[:device_id].present? && device_params[:device_name].present? && device_params[:device_type].present?
|
|
mobile_sso_redirect(error: "missing_device_info", message: "Device information is required")
|
|
return
|
|
end
|
|
|
|
session[:mobile_sso] = {
|
|
device_id: device_params[:device_id],
|
|
device_name: device_params[:device_name],
|
|
device_type: device_params[:device_type],
|
|
os_version: device_params[:os_version],
|
|
app_version: device_params[:app_version]
|
|
}
|
|
|
|
# Render auto-submitting form to POST to OmniAuth (required by omniauth-rails_csrf_protection)
|
|
@provider = provider
|
|
render layout: false
|
|
end
|
|
|
|
def openid_connect
|
|
auth = request.env["omniauth.auth"]
|
|
|
|
# Nil safety: ensure auth and required fields are present
|
|
unless auth&.provider && auth&.uid
|
|
redirect_to new_session_path, alert: t("sessions.openid_connect.failed")
|
|
return
|
|
end
|
|
|
|
# Security fix: Look up by provider + uid, not just email
|
|
oidc_identity = OidcIdentity.find_by(provider: auth.provider, uid: auth.uid)
|
|
|
|
if oidc_identity
|
|
# Existing OIDC identity found - authenticate the user
|
|
user = oidc_identity.user
|
|
oidc_identity.record_authentication!
|
|
oidc_identity.sync_user_attributes!(auth)
|
|
|
|
# Log successful SSO login
|
|
SsoAuditLog.log_login!(user: user, provider: auth.provider, request: request)
|
|
|
|
# Mobile SSO: issue Doorkeeper tokens and redirect to app
|
|
if session[:mobile_sso].present?
|
|
if user.otp_required?
|
|
session.delete(:mobile_sso)
|
|
mobile_sso_redirect(error: "mfa_not_supported", message: "MFA users should sign in with email and password")
|
|
else
|
|
handle_mobile_sso_callback(user)
|
|
end
|
|
return
|
|
end
|
|
|
|
# Store id_token and provider for RP-initiated logout
|
|
session[:id_token_hint] = auth.credentials&.id_token if auth.credentials&.id_token
|
|
session[:sso_login_provider] = auth.provider
|
|
|
|
# MFA check: If user has MFA enabled, require verification
|
|
if user.otp_required?
|
|
session[:mfa_user_id] = user.id
|
|
redirect_to verify_mfa_path
|
|
else
|
|
@session = create_session_for(user)
|
|
flash[:notice] = t("invitations.accept_choice.joined_household") if accept_pending_invitation_for(user)
|
|
redirect_to root_path
|
|
end
|
|
else
|
|
# Mobile SSO with no linked identity - cache pending auth and redirect
|
|
# back to the app with a linking code so the user can link or create an account
|
|
if session[:mobile_sso].present?
|
|
handle_mobile_sso_onboarding(auth)
|
|
return
|
|
end
|
|
|
|
# No existing OIDC identity - need to link to account
|
|
# Store auth data in session and redirect to linking page
|
|
session[:pending_oidc_auth] = {
|
|
provider: auth.provider,
|
|
uid: auth.uid,
|
|
email: auth.info&.email,
|
|
name: auth.info&.name,
|
|
first_name: auth.info&.first_name,
|
|
last_name: auth.info&.last_name
|
|
}
|
|
redirect_to link_oidc_account_path
|
|
end
|
|
end
|
|
|
|
def failure
|
|
# Sanitize reason to known values only
|
|
known_reasons = %w[sso_provider_unavailable sso_invalid_response sso_failed]
|
|
sanitized_reason = known_reasons.include?(params[:message]) ? params[:message] : "sso_failed"
|
|
|
|
# Log failed SSO attempt
|
|
SsoAuditLog.log_login_failed!(
|
|
provider: params[:strategy],
|
|
request: request,
|
|
reason: sanitized_reason
|
|
)
|
|
|
|
# Mobile SSO: redirect back to the app with error instead of web login page
|
|
if session[:mobile_sso].present?
|
|
session.delete(:mobile_sso)
|
|
mobile_sso_redirect(error: sanitized_reason, message: "SSO authentication failed")
|
|
return
|
|
end
|
|
|
|
message = case sanitized_reason
|
|
when "sso_provider_unavailable"
|
|
t("sessions.failure.sso_provider_unavailable")
|
|
when "sso_invalid_response"
|
|
t("sessions.failure.sso_invalid_response")
|
|
else
|
|
t("sessions.failure.sso_failed")
|
|
end
|
|
|
|
redirect_to new_session_path, alert: message
|
|
end
|
|
|
|
private
|
|
def handle_mobile_sso_callback(user)
|
|
device_info = session.delete(:mobile_sso)
|
|
|
|
unless device_info.present?
|
|
mobile_sso_redirect(error: "missing_session", message: "Mobile SSO session expired")
|
|
return
|
|
end
|
|
|
|
device = MobileDevice.upsert_device!(user, device_info.symbolize_keys)
|
|
token_response = device.issue_token!
|
|
|
|
# Store tokens behind a one-time authorization code instead of passing in URL
|
|
authorization_code = SecureRandom.urlsafe_base64(32)
|
|
Rails.cache.write(
|
|
"mobile_sso:#{authorization_code}",
|
|
token_response.merge(
|
|
user_id: user.id,
|
|
user_email: user.email,
|
|
user_first_name: user.first_name,
|
|
user_last_name: user.last_name,
|
|
user_ui_layout: user.ui_layout,
|
|
user_ai_enabled: user.ai_enabled?
|
|
),
|
|
expires_in: 5.minutes
|
|
)
|
|
|
|
mobile_sso_redirect(code: authorization_code)
|
|
rescue ActiveRecord::RecordInvalid => e
|
|
Rails.logger.warn("[Mobile SSO] Device save failed: #{e.record.errors.full_messages.join(', ')}")
|
|
mobile_sso_redirect(error: "device_error", message: "Unable to register device")
|
|
end
|
|
|
|
def handle_mobile_sso_onboarding(auth)
|
|
device_info = session.delete(:mobile_sso)
|
|
email = auth.info&.email
|
|
|
|
linking_code = SecureRandom.urlsafe_base64(32)
|
|
Rails.cache.write(
|
|
"mobile_sso_link:#{linking_code}",
|
|
{
|
|
provider: auth.provider,
|
|
uid: auth.uid,
|
|
email: email,
|
|
first_name: auth.info&.first_name,
|
|
last_name: auth.info&.last_name,
|
|
name: auth.info&.name,
|
|
issuer: auth.extra&.raw_info&.iss || auth.extra&.raw_info&.[]("iss"),
|
|
device_info: device_info,
|
|
allow_account_creation: !AuthConfig.jit_link_only? && AuthConfig.allowed_oidc_domain?(email)
|
|
},
|
|
expires_in: 10.minutes
|
|
)
|
|
|
|
mobile_sso_redirect(
|
|
status: "account_not_linked",
|
|
linking_code: linking_code,
|
|
email: email,
|
|
first_name: auth.info&.first_name,
|
|
last_name: auth.info&.last_name,
|
|
allow_account_creation: !AuthConfig.jit_link_only? && AuthConfig.allowed_oidc_domain?(email)
|
|
)
|
|
end
|
|
|
|
def mobile_sso_redirect(params = {})
|
|
redirect_to "sureapp://oauth/callback?#{params.to_query}", allow_other_host: true
|
|
end
|
|
|
|
def set_session
|
|
@session = Current.user.sessions.find(params[:id])
|
|
end
|
|
|
|
def log_super_admin_override_login(user)
|
|
# Only log when local login is globally disabled but an emergency
|
|
# super-admin override is enabled.
|
|
return if AuthConfig.local_login_enabled?
|
|
return unless AuthConfig.local_admin_override_enabled?
|
|
return unless user&.super_admin?
|
|
|
|
Rails.logger.info("[AUTH] Super admin override login: user_id=#{user.id} email=#{user.email}")
|
|
end
|
|
|
|
def demo_host_match?(demo)
|
|
return false unless demo.present? && demo["hosts"].present?
|
|
|
|
demo["hosts"].include?(request.host)
|
|
end
|
|
|
|
def build_idp_logout_url(oidc_identity, id_token)
|
|
# Find the provider configuration using unified loader (supports both YAML and DB providers)
|
|
provider_config = ProviderLoader.load_providers.find do |p|
|
|
p[:name] == oidc_identity.provider
|
|
end
|
|
|
|
return nil unless provider_config
|
|
|
|
# For OIDC providers, fetch end_session_endpoint from discovery
|
|
if provider_config[:strategy] == "openid_connect" && provider_config[:issuer].present?
|
|
begin
|
|
discovery_url = discovery_url_for(provider_config[:issuer])
|
|
response = Faraday.new(ssl: self.class.faraday_ssl_options).get(discovery_url) do |req|
|
|
req.options.timeout = 5
|
|
req.options.open_timeout = 3
|
|
end
|
|
|
|
return nil unless response.success?
|
|
|
|
discovery = JSON.parse(response.body)
|
|
end_session_endpoint = discovery["end_session_endpoint"]
|
|
|
|
return nil unless end_session_endpoint.present?
|
|
|
|
# Build the logout URL with post_logout_redirect_uri
|
|
post_logout_redirect = "#{request.base_url}/auth/logout/callback"
|
|
params = {
|
|
id_token_hint: id_token,
|
|
post_logout_redirect_uri: post_logout_redirect
|
|
}
|
|
|
|
"#{end_session_endpoint}?#{params.to_query}"
|
|
rescue Faraday::Error, JSON::ParserError, StandardError => e
|
|
Rails.logger.warn("[SSO] Failed to fetch OIDC discovery for logout: #{e.message}")
|
|
nil
|
|
end
|
|
else
|
|
nil
|
|
end
|
|
end
|
|
|
|
def discovery_url_for(issuer)
|
|
if issuer.end_with?("/")
|
|
"#{issuer}.well-known/openid-configuration"
|
|
else
|
|
"#{issuer}/.well-known/openid-configuration"
|
|
end
|
|
end
|
|
end
|