Files
sure/app/javascript/controllers/goal_form_controller.js
Guillem Arias Fauste 5d0eb7f445 fix(goals): UI polish — submit validation, container-responsive cards, picker & filter fixes (#2160)
* fix(ds): disabled buttons use not-allowed cursor

Tailwind v4 preflight sets cursor:pointer on every <button>, including
disabled ones. Add disabled:cursor-not-allowed to the DS button base so
disabled buttons read as non-interactive.

* fix(goals): disable new-goal submit until required fields valid

The submit button was always enabled, and the funding-accounts checkbox
group has no native 'required', so a goal with no linked account could be
submitted and only fail server-side (422). Disable the submit until name,
a positive target amount, and >=1 account are present, and add a
submit-time guard that surfaces inline errors and focuses the first
offending field as a backstop.

* fix(goals): keep color/icon picker from shifting the form

DS::Disclosure wraps its body in an mt-2 div that sits in normal flow, so
opening the absolutely-positioned picker popover nudged the form down ~8px.
Use a raw <details> for the picker so the popover overlays without
reflowing the content beneath it.

* fix(goals): container-responsive cards, meta-line status, scrollable tabs

- Card grids + KPI strip switch from viewport breakpoints to container
  queries (@container), so columns track the actual content width when the
  account/AI sidebars are open instead of crushing three columns into a
  narrow center.
- Move the status pill from the title row to the meta line; the title now
  gets the full header width (no more 'Hou...' truncation at 3-up). Drop
  the secondary line when the pill already states it (completed / open).
- Card internals harden for narrow widths (ring shrink-0, footer wrap,
  shorter 'N days left' secondary).
- Filter tabs scroll horizontally instead of wrapping 'On track' mid-label
  or forcing the row wider than the viewport.

* fix(goals): only require a funding account on the create form

GoalsController#edit renders account checkboxes from visible accounts only,
so a goal backed solely by a now-hidden (disabled / pending_deletion)
account renders none checked. The submit-validation then wedged the edit
form — a name/notes change couldn't be saved even though #update preserves
existing links when account_ids is omitted. Gate the account requirement on
a require-account Stimulus value that is true only for the create form.

* fix(goals): give the color/icon picker trigger an accessible name

The hand-rolled <summary> is icon-only (pen), so screen readers announced an
unlabeled control. Add a localized aria-label.

* fix(goals): render form validation errors inline on server re-render

The client-side controller already surfaces name / amount / account errors
inline and disables submit, but a server 422 (JS disabled, or a race that
lets an invalid submit through) fell back to the top run-on banner
("X must be filled and Y and Z."). Make the existing inline error hints
server-aware so a failed submit shows the same per-field red text the
client path does, and drop the base-error banner — base only ever carries
the account requirement, which now renders beside the funding-accounts
list.

* fix(goals): blur projection chart under privacy mode

The projection chart's SVG axis labels and annotations (target, "$X short",
$200K/$400K ticks) rendered in cleartext while privacy mode blurred every
other number on the page. Tag the chart container `privacy-sensitive`, the
same wrapper-level treatment the net-worth and cashflow-sankey charts
already use, so it blurs with the rest.

* fix(goals): stop target-date input stretching when amount error shows

The target-amount / target-date row is a two-column grid. The amount
column carries its inline error <p> underneath, so when that error
appears the column grows and the default `items-stretch` makes the
sibling date input stretch to match — the date box visibly grew taller
than the amount box. Anchor the row with `items-start` so each input
keeps its natural height and the error just extends below its own column.

* fix(goals): make invalid submit announce errors instead of dead-ending

Review follow-ups:
- Swap the submit gate from the disabled attribute to aria-disabled: a
  truly disabled default submit also blocks Enter-key implicit
  submission, so an invalid form was a dead button with every inline
  error still hidden. The button now stays clickable and lets
  validateOnSubmit surface the errors; DS buttonish styles the
  aria-disabled state (cursor-not-allowed + opacity-50). Side effect:
  loading_button_controller submits also dim while busy, which reads as
  an upgrade.
- Focus the first funding-account checkbox when accounts are the only
  missing field (focus previously went nowhere).
- Drop the now-orphaned goals.goal_card.days_left_by locale key.
2026-06-06 16:24:17 +02:00

211 lines
8.0 KiB
JavaScript

import { Controller } from "@hotwired/stimulus";
// Single-form controller for the goal create / edit modal.
//
// Replaces the 2-step stepper: the form is short enough that all fields
// fit on one panel, so the previous review step (which only showed a
// derived "Save $X/mo to hit it on time" hint) collapses into an inline
// live hint below the target date. Validation + avatar preview from the
// name field still live here.
export default class extends Controller {
static targets = [
"nameInput",
"amountInput",
"dateInput",
"avatarPreview",
"nameError",
"amountError",
"accountsError",
"linkedAccountCheckbox",
"suggested",
"submitButton",
];
static INVALID_INPUT_CLASSES = ["ring-2", "ring-destructive", "border-destructive"];
static values = {
currency: { type: String, default: "USD" },
suggestedWithDate: { type: String, default: "Save {monthly}/mo across {accounts} to hit it on time." },
suggestedNoDate: { type: String, default: "Set a target date to project a finish line." },
// Only the create form must pick an account. On edit the checkboxes are
// populated from visible accounts only, so a goal backed by a now-hidden
// account renders none — and the controller preserves existing links when
// account_ids is omitted. Requiring a checkbox there would wedge the form.
requireAccount: { type: Boolean, default: true },
};
connect() {
// Capture the default avatar contents (the "target" icon SVG) so we
// can restore it when the user clears the name field after typing.
if (this.hasAvatarPreviewTarget) {
this._defaultAvatarHTML = this.avatarPreviewTarget.innerHTML;
}
this.updateSuggested();
// Edit form arrives pre-filled (valid) so this clears immediately; new
// form arrives empty so the submit starts visually disabled.
this.refreshSubmitState();
}
nameChanged() {
if (this.hasNameInputTarget) {
this.clearFieldError(this.nameInputTarget, this.hasNameErrorTarget ? this.nameErrorTarget : null);
}
this.refreshSubmitState();
if (!this.hasAvatarPreviewTarget || !this.hasNameInputTarget) return;
// If the user has explicitly picked an icon, leave it alone. Name
// changes shouldn't undo an explicit choice.
const iconPicked = this.element.querySelector('input[name="goal[icon]"]:checked');
if (iconPicked) return;
const name = this.nameInputTarget.value.trim();
if (name) {
this.avatarPreviewTarget.textContent = name.charAt(0).toUpperCase();
} else if (this._defaultAvatarHTML) {
// Captured at connect. Restore the default "target" icon from the
// server-rendered template, not a "?" character.
this.avatarPreviewTarget.innerHTML = this._defaultAvatarHTML;
}
}
amountChanged() {
if (this.hasAmountInputTarget) {
this.clearFieldError(this.amountInputTarget, this.hasAmountErrorTarget ? this.amountErrorTarget : null);
}
this.refreshSubmitState();
}
linkedAccountChanged() {
this.updateSuggested();
if (this.linkedAccountCheckboxTargets.some((cb) => cb.checked) && this.hasAccountsErrorTarget) {
this.accountsErrorTarget.classList.add("hidden");
}
this.refreshSubmitState();
}
// Required to create a goal: a name, a positive target amount, and at least
// one funding account. Mirrors the server-side Goal validations (name
// presence, target_amount > 0, must_have_at_least_one_linked_account) so the
// button only enables when a submit would actually succeed.
isValid() {
const name = this.hasNameInputTarget ? this.nameInputTarget.value.trim() : "";
const amount = this.hasAmountInputTarget ? Number.parseFloat(this.amountInputTarget.value) : Number.NaN;
const accountOk = !this.requireAccountValue || this.linkedAccountCheckboxTargets.some((cb) => cb.checked);
return name.length > 0 && Number.isFinite(amount) && amount > 0 && accountOk;
}
// `aria-disabled` instead of the `disabled` attribute: a truly disabled
// default submit also blocks Enter-key implicit submission, so an invalid
// form would be a dead button with every inline error still hidden. With
// aria-disabled the button keeps its not-allowed affordance (styled via the
// DS `aria-disabled:` variants) while clicks and Enter still reach
// validateOnSubmit, which surfaces the errors and moves focus.
refreshSubmitState() {
if (this.hasSubmitButtonTarget) {
this.submitButtonTarget.setAttribute("aria-disabled", String(!this.isValid()));
}
}
// The real gate for the submit: covers the funding-accounts group (a
// checkbox group can't carry native `required`) and everything the
// aria-disabled affordance merely hints at. Surfaces the inline errors and
// focuses the first offending field instead of a silent no-op.
validateOnSubmit(event) {
if (this.isValid()) return;
event.preventDefault();
const nameEmpty = !(this.hasNameInputTarget && this.nameInputTarget.value.trim().length > 0);
const amount = this.hasAmountInputTarget ? Number.parseFloat(this.amountInputTarget.value) : Number.NaN;
const amountInvalid = !(Number.isFinite(amount) && amount > 0);
const noAccount = this.requireAccountValue && !this.linkedAccountCheckboxTargets.some((cb) => cb.checked);
if (nameEmpty) {
this.showFieldError(this.nameInputTarget, this.hasNameErrorTarget ? this.nameErrorTarget : null);
}
if (amountInvalid) {
this.showFieldError(this.amountInputTarget, this.hasAmountErrorTarget ? this.amountErrorTarget : null);
}
if (noAccount && this.hasAccountsErrorTarget) {
this.accountsErrorTarget.classList.remove("hidden");
}
const firstInvalid = nameEmpty
? this.nameInputTarget
: amountInvalid
? this.amountInputTarget
: noAccount
? this.linkedAccountCheckboxTargets[0]
: null;
firstInvalid?.focus();
}
// Hook for any input that influences the suggested-pace hint
// (target_amount, target_date). Also re-evaluates as accounts toggle.
suggestedChanged() {
this.amountChanged();
this.updateSuggested();
}
updateSuggested() {
if (!this.hasSuggestedTarget) return;
const amount = this.hasAmountInputTarget ? Number.parseFloat(this.amountInputTarget.value) : Number.NaN;
const dateValue = this.hasDateInputTarget ? this.dateInputTarget.value : null;
const checkedCount = this.linkedAccountCheckboxTargets.filter((cb) => cb.checked).length;
const amountValid = Number.isFinite(amount) && amount > 0;
if (!amountValid || checkedCount === 0) {
this.suggestedTarget.classList.add("hidden");
this.suggestedTarget.textContent = "";
return;
}
let text;
if (dateValue) {
const months = this.#monthsBetween(new Date(), new Date(dateValue));
if (months <= 0) {
this.suggestedTarget.classList.add("hidden");
this.suggestedTarget.textContent = "";
return;
}
const perMonth = Math.ceil(amount / months);
const accountLabel = `${checkedCount} ${checkedCount === 1 ? "account" : "accounts"}`;
text = this.suggestedWithDateValue
.replace("{monthly}", this.#money(perMonth))
.replace("{accounts}", accountLabel);
} else {
text = this.suggestedNoDateValue;
}
this.suggestedTarget.textContent = text;
this.suggestedTarget.classList.remove("hidden");
}
showFieldError(input, errorEl) {
if (input) input.classList.add(...this.constructor.INVALID_INPUT_CLASSES);
if (errorEl) errorEl.classList.remove("hidden");
}
clearFieldError(input, errorEl) {
if (input) input.classList.remove(...this.constructor.INVALID_INPUT_CLASSES);
if (errorEl) errorEl.classList.add("hidden");
}
#money(value) {
try {
return new Intl.NumberFormat(undefined, {
style: "currency",
currency: this.currencyValue || "USD",
maximumFractionDigits: 0,
}).format(value);
} catch {
return `${this.currencyValue || "$"}${Math.round(value).toLocaleString()}`;
}
}
#monthsBetween(from, to) {
return (to - from) / (1000 * 60 * 60 * 24 * 30.44);
}
}