mirror of
https://github.com/we-promise/sure.git
synced 2026-09-02 05:11:05 +00:00
Guillem Arias Fauste
23e7db4f4d
* fix(transactions): don't crash the rule-prompt flash when clearing a category needs_rule_notification? only checked saved_change_to_category_id? and eligible_for_category_rule?, neither of which accounts for category_id being nil. Clearing a category (Clear category / entryable_attributes category_id: nil) satisfies both, so the caller went on to read transaction.category.name against a nil category and crashed. A rule prompt only makes sense when a category was assigned, not cleared, so bail out early when there's no category to build a rule around. * feat(transactions): surface recently-used categories in the category picker Reframes the recency-vs-muscle-memory question as additive, not either/or: a small "Recent" section pinned above the existing alphabetical list, which stays exactly where it always was below it. Precedent for reordering the primary list by frequency (Office's old adaptive menus, browser-history-style resorting) is a well-known anti-pattern — position drifts under the user's hand. Every picker that does recency well (VS Code's command palette, Spotify, Slack's emoji picker) adds a small separate recent cluster instead. - Category#last_used_at, touched only in TransactionCategoriesController#update — the one place a category is actually hand-picked by a person, as opposed to a rule or import auto-assigning one. - Category.recently_used_for(family:, excluding:, limit:) batches the family-scoped query; dropdowns_controller excludes the already- selected category from the Recent section since it's already pinned to the top of the main list. - "Recent" hides itself the moment a search query is typed — it's a pre-search shortcut, not a second copy of search results. Its rows are force-hidden (not just filtered) so keyboard nav can't land on a row that's invisible only because its ancestor section is hidden. * fix(categories): address review feedback on recent-categories picker - Track last_used_at from every manual assignment path (transaction edit form, categorization wizard bulk-update, create-and-assign), not just the category-picker endpoint. Centralized as Transaction#record_category_usage!, called explicitly from each manual controller action rather than wired to a blanket after_save callback, since rule/import auto-assignment must not count as a "recent" pick. - Give recent-section rows a distinct DOM id (recent_category_option_<id>) from their canonical-list counterpart so aria-activedescendant can't resolve to a hidden duplicate during keyboard nav. - Fix migration to ActiveRecord::Migration[7.2] to match the rest of the repo. - Materialize @recent_categories with .to_a to avoid a redundant query.
24 lines
695 B
Ruby
24 lines
695 B
Ruby
class Category::DropdownsController < ApplicationController
|
|
before_action :set_from_params
|
|
|
|
def show
|
|
@categories = categories_scope.to_a.excluding(@selected_category).prepend(@selected_category).compact
|
|
@recent_categories = Category.recently_used_for(family: Current.family, excluding: @selected_category).to_a
|
|
end
|
|
|
|
private
|
|
def set_from_params
|
|
if params[:category_id]
|
|
@selected_category = categories_scope.find(params[:category_id])
|
|
end
|
|
|
|
if params[:transaction_id]
|
|
@transaction = Current.family.transactions.find(params[:transaction_id])
|
|
end
|
|
end
|
|
|
|
def categories_scope
|
|
Current.family.categories.alphabetically
|
|
end
|
|
end
|