mirror of
https://github.com/we-promise/sure.git
synced 2026-09-03 22:01:16 +00:00
fd01a5b3dc
* fix(accounts): remember transaction page size across account navigation per_page was only ever read from the current request's query string, so switching accounts always reset the activity feed back to 10 entries. Reuses TransactionsController's existing prev_transaction_page_params session store so the chosen page size applies consistently on both the account detail page and the global transactions page. Closes #3082 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(accounts): validate stored per_page and preserve it across filtered requests Addresses review feedback on #3084: safe_per_page now validates the stored default against the allowed values (a raw stored value like "1" was previously passed through unchecked), TransactionsController no longer wipes the remembered per_page when a request supplies filters but omits per_page, and Session#prev_transaction_page_params normalizes a NULL value to an empty hash. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(transactions): use stored per_page as pagy fallback on filtered requests store_params! already preserved the previously-selected per_page in the session when a filtered request (e.g. dashboard money-flow links) omitted it, but TransactionsController#index still called safe_per_page with its hardcoded default of 10, so the stored preference was never applied to the actual page rendered. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Gerald <248542187+gfr-free@users.noreply.github.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
19 lines
462 B
Ruby
19 lines
462 B
Ruby
# frozen_string_literal: true
|
|
|
|
module SafePagination
|
|
extend ActiveSupport::Concern
|
|
|
|
private
|
|
def safe_per_page(default = 10)
|
|
allowed_values = [ 10, 20, 30, 50, 100 ]
|
|
default = default.to_i
|
|
default = 10 unless allowed_values.include?(default)
|
|
|
|
per_page = params[:per_page].to_i
|
|
|
|
return default if per_page <= 0
|
|
|
|
allowed_values.include?(per_page) ? per_page : allowed_values.min_by { |v| (v - per_page).abs }
|
|
end
|
|
end
|