mirror of
https://github.com/we-promise/sure.git
synced 2026-09-03 05:41:18 +00:00
e5750a6c09
* feat(budgets): add per-user personal budgets with strict isolation Families can now opt into personal budgets (toggleable via family settings): each family member gets their own budget for a given period instead of sharing a single family-wide budget. - Add families.personal_budgets flag and budgets.user_id, with partial unique indexes so shared budgets (user_id IS NULL) and personal budgets (user_id IS NOT NULL) can't collide. - Budget.find_or_bootstrap scopes lookup/creation by user when the family has personal_budgets enabled. - Scope most_recent_initialized_budget (used to seed a new budget from the prior period) by user_id so one user's copy-forward never bleeds into another user's budget. - budgets.user_id cascades on user deletion so personal budgets don't outlive their owner. * feat(budgets): enforce user-specific budget ownership and cascade deletion * feat(budgets): display user name for personal budgets in budget card on the plan section * feat(budgets): enhance personal budgets display for admins with preview feature indication * feat(budgets): enforce user-specific budget and category visibility for personal budgets * feat(budgets): create budget section titles and add translations notice in preferences * feat(budgets): let household and personal budgets coexist with sharing Previously enabling personal_budgets made the shared household budget unreachable. Budget.find_or_bootstrap now takes an explicit household: flag so both can be resolved independently for the same period, with a new household_budget_enabled family setting to opt out of the household side and keep personal budgets only. Adds a BudgetShare model (read_only/read_write) so a member can grant another family member access to their personal budget, enforced via Budget#viewable_by?/editable_by? across BudgetsController, BudgetCategoriesController, PlansController, and the read-only API. Preferences gains a Budget sharing card (gated on preview access like the rest of the personal budgets UI) and an owner switcher pill ( Household / mine / shared-with-me) appears on the budget page and the Plan hub card. Also fixes personal budgets showing the same "actual spending" as the household budget: actual spending/income now scope to the budget owner's own accounts instead of the viewer's full accessible set, via a new accounts: override on IncomeStatement. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * feat(budgets): enhance budget switcher with icons and improved styling * feat(budgets): remove user name display from budget card and header * feat(budgets): remove unique index on taggable_type and taggable_id in taggings * feat(budgets): enhance budget sharing functionality and improve UI elements * Collapse personal budget migrations --------- Signed-off-by: JulienGourmet <69808509+jubbakka@users.noreply.github.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> Co-authored-by: sure-admin <sure-admin@splashblot.com>
51 lines
1.6 KiB
Ruby
51 lines
1.6 KiB
Ruby
require "test_helper"
|
|
|
|
class Settings::BudgetSharesControllerTest < ActionDispatch::IntegrationTest
|
|
setup do
|
|
@family = families(:empty)
|
|
@owner = users(:josh)
|
|
@viewer = users(:ann)
|
|
sign_in @owner
|
|
end
|
|
|
|
test "grants a new share with the selected permission" do
|
|
patch settings_budget_shares_url, params: {
|
|
budget_shares: { members: { "0" => { viewer_id: @viewer.id, permission: "read_only" } } }
|
|
}
|
|
|
|
assert_redirected_to settings_preferences_path
|
|
share = @owner.budget_shares_given.find_by(viewer: @viewer)
|
|
assert_equal "read_only", share.permission
|
|
end
|
|
|
|
test "updates an existing share's permission" do
|
|
BudgetShare.create!(owner: @owner, viewer: @viewer, permission: "read_only")
|
|
|
|
patch settings_budget_shares_url, params: {
|
|
budget_shares: { members: { "0" => { viewer_id: @viewer.id, permission: "read_write" } } }
|
|
}
|
|
|
|
assert_equal "read_write", @owner.budget_shares_given.find_by(viewer: @viewer).permission
|
|
end
|
|
|
|
test "revokes a share when permission is blank" do
|
|
BudgetShare.create!(owner: @owner, viewer: @viewer, permission: "read_only")
|
|
|
|
patch settings_budget_shares_url, params: {
|
|
budget_shares: { members: { "0" => { viewer_id: @viewer.id, permission: "" } } }
|
|
}
|
|
|
|
assert_nil @owner.budget_shares_given.find_by(viewer: @viewer)
|
|
end
|
|
|
|
test "ignores a viewer_id outside the current user's family" do
|
|
outsider = users(:family_admin)
|
|
|
|
patch settings_budget_shares_url, params: {
|
|
budget_shares: { members: { "0" => { viewer_id: outsider.id, permission: "read_only" } } }
|
|
}
|
|
|
|
assert_nil BudgetShare.find_by(owner: @owner, viewer: outsider)
|
|
end
|
|
end
|