Files
sure/test/models/import_test.rb
T
GFRandGerald fa8769f792 fix: support DD/MM/YY date format for CSV imports (#3110)
Adds "DD/MM/YY" as a CSV-only date format for transaction and account
balance imports, addressing #1530.

Kept out of Family::DATE_FORMATS (the global date preference) since a
prior PR (#531) adding it there was rejected by a maintainer: 2-digit
years are ambiguous (Ruby's %y assumes 1969-2068) and could silently
misparse historical or future-dated transactions. Restricting it to
Import::CSV_ONLY_DATE_FORMATS keeps it available where the user can
see and verify a parsed preview against their own CSV data, per the
maintainer's suggested approach in that PR's discussion.

Co-authored-by: Gerald <248542187+gfr-free@users.noreply.github.com>
2026-08-22 03:55:08 +02:00

218 lines
7.3 KiB
Ruby

require "test_helper"
class ImportTest < ActiveSupport::TestCase
test "publish skips imports in terminal statuses" do
import = imports(:transaction)
import.update_columns(status: "complete")
import.expects(:import!).never
import.publish
assert_equal "complete", import.reload.status
end
test "publish skips imports that are reverting" do
import = imports(:transaction)
import.update_columns(status: "reverting")
import.expects(:import!).never
import.publish
assert_equal "reverting", import.reload.status
end
test "clean fails stuck imports but leaves PdfImports to their own reclaim" do
stuck_csv = imports(:transaction)
stuck_csv.update_columns(status: "importing", updated_at: 7.hours.ago)
stuck_pdf = imports(:pdf)
stuck_pdf.update_columns(status: "importing", updated_at: 7.hours.ago)
Import.clean
assert_equal "failed", stuck_csv.reload.status
assert_equal "importing", stuck_pdf.reload.status
end
test "clean leaves session-owned chunks to ImportSession.clean" do
family = families(:dylan_family)
session = family.import_sessions.create!(status: "importing")
chunk = TransactionImport.create!(
family: family,
import_session: session,
sequence: 1,
checksum: Digest::SHA256.hexdigest("chunk"),
status: "importing"
)
chunk.update_columns(updated_at: 7.hours.ago)
Import.clean
assert_equal "importing", chunk.reload.status
end
test "clean completes a stuck import whose data already committed" do
stuck = imports(:transaction)
stuck.update_columns(status: "importing", updated_at: 7.hours.ago)
entries(:transaction).update_columns(import_id: stuck.id)
Import.clean
stuck.reload
assert_equal "complete", stuck.status
assert_nil stuck.error
end
test "clean moves a stuck revert to revert_failed" do
stuck = imports(:transaction)
stuck.update_columns(status: "reverting", updated_at: 7.hours.ago)
Import.clean
assert_equal "revert_failed", stuck.reload.status
end
test "PdfImport clean reclaims the AI claim but completes a committed publish" do
ai_claim = imports(:pdf)
ai_claim.update_columns(status: "importing", updated_at: 7.hours.ago)
published = imports(:pdf_processed)
published.update_columns(status: "importing", updated_at: 7.hours.ago)
entries(:transaction).update_columns(import_id: published.id)
PdfImport.clean
assert_equal "pending", ai_claim.reload.status
assert_equal "complete", published.reload.status
end
test "PdfImport clean moves a stuck revert to revert_failed" do
stuck = imports(:pdf)
stuck.update_columns(status: "reverting", updated_at: 7.hours.ago)
PdfImport.clean
assert_equal "revert_failed", stuck.reload.status
end
test "force_fail! refuses records that have not been idle long enough" do
import = imports(:transaction)
import.update_columns(status: "importing", updated_at: 5.minutes.ago)
assert_not import.force_fail!
assert_equal "importing", import.reload.status
end
test "force_fail! fails a lost import and keeps reverts retryable" do
lost_import = imports(:transaction)
lost_import.update_columns(status: "importing", updated_at: 2.hours.ago)
assert lost_import.force_fail!
assert_equal "failed", lost_import.reload.status
assert_equal Import.lost_error_message, lost_import.error
lost_revert = imports(:trade)
lost_revert.update_columns(status: "reverting", updated_at: 2.hours.ago)
assert lost_revert.force_fail!
assert_equal "revert_failed", lost_revert.reload.status
end
test "force_fail! refuses terminal statuses" do
import = imports(:transaction)
import.update_columns(status: "complete", updated_at: 2.hours.ago)
assert_not import.force_fail!
assert_equal "complete", import.reload.status
end
test "force_fail! releases a lost PdfImport claim back to pending" do
pdf = imports(:pdf)
pdf.update_columns(status: "importing", updated_at: 2.hours.ago)
assert pdf.force_fail!
assert_equal "pending", pdf.reload.status
end
# Category/Merchant/Rule imports attach nothing to the import (their records
# hang off the family), so reap_stuck! leans on the type-specific
# data_committed? override to tell a committed run from a rolled-back one.
test "clean completes a stuck CategoryImport whose categories committed" do
family = families(:dylan_family)
stuck = CategoryImport.create!(family: family, status: "importing")
stuck.rows.create!(source_row_number: 1, name: categories(:income).name, currency: "USD")
stuck.update_columns(updated_at: 7.hours.ago)
Import.clean
stuck.reload
assert_equal "complete", stuck.status
assert_nil stuck.error
end
test "clean fails a stuck CategoryImport whose categories never committed" do
family = families(:dylan_family)
stuck = CategoryImport.create!(family: family, status: "importing")
stuck.rows.create!(source_row_number: 1, name: "Never Committed Category", currency: "USD")
stuck.update_columns(updated_at: 7.hours.ago)
Import.clean
assert_equal "failed", stuck.reload.status
end
test "clean completes a stuck MerchantImport whose merchants committed" do
family = families(:dylan_family)
stuck = MerchantImport.create!(family: family, status: "importing")
stuck.rows.create!(source_row_number: 1, name: merchants(:netflix).name, currency: "USD")
stuck.update_columns(updated_at: 7.hours.ago)
Import.clean
assert_equal "complete", stuck.reload.status
end
test "clean completes a stuck RuleImport whose named rules committed" do
family = families(:dylan_family)
# Skip Rule's own validations — the reaper only asks whether a rule with
# this name exists in the family, which is the state a committed import
# leaves behind.
family.rules.new(resource_type: "transaction", name: "Committed rule").save!(validate: false)
stuck = RuleImport.create!(family: family, status: "importing")
stuck.rows.create!(source_row_number: 1, name: "Committed rule", resource_type: "transaction", conditions: "[]", actions: "[]", currency: "USD")
stuck.update_columns(updated_at: 7.hours.ago)
Import.clean
assert_equal "complete", stuck.reload.status
end
test "clean fails a stuck RuleImport of only nameless rows (no commit signal)" do
family = families(:dylan_family)
stuck = RuleImport.create!(family: family, status: "importing")
stuck.rows.create!(source_row_number: 1, name: "", resource_type: "transaction", conditions: "[]", actions: "[]", currency: "USD")
stuck.update_columns(updated_at: 7.hours.ago)
Import.clean
assert_equal "failed", stuck.reload.status
end
test "CSV-only date formats are not offered as a global family preference" do
# 2-digit years are ambiguous (see we-promise/sure#1530 and the rejected
# PR #531), so this format must stay out of Family::DATE_FORMATS and only
# be offered on the CSV mapping screen, where the user can preview it
# against their own data.
assert_empty Import::CSV_ONLY_DATE_FORMATS & Family::DATE_FORMATS
end
test "date_format accepts a CSV-only format like DD/MM/YY" do
import = imports(:transaction)
import.update!(date_format: "%d/%m/%y")
assert_equal Date.new(2024, 5, 15), Date.strptime("15/05/24", import.date_format)
end
end