mirror of
https://github.com/we-promise/sure.git
synced 2026-07-26 11:42:16 +00:00
826c4a356e
* feat(wise): add Wise integration with JAR savings account and activity support
- Add WiseItem/WiseAccount models with full sync pipeline (importer, syncer, processor)
- Detect income vs expense using targetAccount == recipientId from borderless accounts API
- Support JAR (SAVINGS) accounts with totalWorth balance and savings subtype
- Fetch JAR activity via profile activities API (INTERBALANCE, BALANCE_CASHBACK, BALANCE_ASSET_FEE)
- Route INTERBALANCE activities to both JAR and STANDARD accounts and link as Transfer records
- Add provider connection status registration, routes, views, and i18n
- Add migration for wise_items and wise_accounts tables
- Add tests for WiseAccount, WiseEntry::Processor, WiseActivity::Processor, WiseItem::Importer, and WiseItem#link_jar_transfers!
* chore(lint): add ignore to security scan (false positive)
* fix(wise): address PR review feedback on activity routing, HTML stripping, rate limiting, and scope extraction
- Replace title string matching in activity_for_account? with resource.id vs balance_id comparison to avoid breakage when users rename JAR accounts on Wise
- Replace gsub(/<[^>]+>/, "") with ActionController::Base.helpers.strip_tags to safely handle user-controlled HTML-like content
- Wrap paginated API calls in with_rate_limit_retry (up to 3 attempts, exponential backoff) to handle 429 responses during fetch_jar_activities and fetch_transfers
- Extract WiseAccount.unlinked scope and remove duplicated left_joins query from controller
* fix(wise): address PR #2433 review feedback
- Wire @wise_items into AccountsController#index so linked accounts appear on /accounts
- Fix find_wise_account_for_linking to preserve .active scope via .merge instead of .then
- Fix cross-currency incoming transfer amount to use targetValue instead of sourceValue
- Add missing select_profiles.session_expired locale key
- Add missing account_name interpolation to link_existing_account success notice
- Use i18n for profile type labels in profile_display_name
- Trigger wise_item.sync_later after account linking in all three linking actions
- Isolate fee transaction failure so it no longer aborts the main transfer import
- Use bare raise in WiseActivity/WiseEntry processors to preserve original backtrace
- Re-raise in WiseItem::Unlinking to prevent silently orphaned Holdings
- Fix avatar badge to use design system tokens (bg-container-inset, text-primary)
* fix(wise): fix INTERBALANCE routing and encrypt pending token in session
* fix(wise): replace hand-rolled buttons/links with DS::Button and DS::Link
Address repeated sure-design DS drift findings: migrate all manual
Tailwind button_to and link_to calls in Wise views to DS::Button
(outline/outline_destructive variants) and DS::Link (secondary variant).
Add missing provider_panel.disconnect locale key for the disconnect button text.
* fix(wise): use render_provider_panel_error in create instead of missing new template
* fix(wise): add missing comma in PROVIDERS array
CI failed with a SyntaxError because the questrade entry wasn't
comma-terminated before the wise entry.
* chore(wise): re-add pipelock:ignore for pending token param
Lost when the token source moved from session to an encrypted params
field in 0b5dc886, causing the CI secret scanner to flag a false positive.
* fix(test): widen random ticker suffix to avoid rare collision flake
hex(2) only yields 65536 possible tickers, so create_trade's 4 calls per
test run had a small but nonzero chance of colliding on the unique
ticker+exchange index. hex(8) makes collisions practically impossible.
58 lines
1.8 KiB
Ruby
58 lines
1.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class WiseAccount < ApplicationRecord
|
|
include Encryptable
|
|
|
|
if encryption_ready?
|
|
encrypts :raw_payload
|
|
encrypts :raw_transactions_payload
|
|
end
|
|
|
|
belongs_to :wise_item
|
|
|
|
has_one :account_provider, as: :provider, dependent: :destroy
|
|
has_one :account, through: :account_provider
|
|
|
|
validates :balance_id, :currency, presence: true
|
|
validates :balance_id, uniqueness: { scope: :wise_item_id }
|
|
|
|
scope :unlinked, -> { left_joins(:account_provider).where(account_providers: { id: nil }) }
|
|
|
|
def current_account
|
|
account
|
|
end
|
|
|
|
def jar?
|
|
raw_payload&.dig("type") == "SAVINGS"
|
|
end
|
|
|
|
def account_subtype
|
|
jar? ? "savings" : Depository::DEFAULT_SUBTYPE
|
|
end
|
|
|
|
def upsert_wise_snapshot!(balance_data, borderless_account_id: nil, recipient_id: nil)
|
|
data = balance_data.with_indifferent_access
|
|
payload = balance_data.is_a?(Hash) ? balance_data.dup : balance_data
|
|
payload = payload.merge("borderless_account_id" => borderless_account_id) if borderless_account_id
|
|
payload = payload.merge("recipient_id" => recipient_id) if recipient_id
|
|
|
|
currency_code = data.dig(:amount, :currency).presence || data[:currency].presence || currency
|
|
savings = data[:type] == "SAVINGS"
|
|
balance_value = savings ? data.dig(:totalWorth, :value).to_d : data.dig(:amount, :value).to_d
|
|
api_name = data[:name].presence
|
|
default_name = savings ? "Wise JAR #{currency_code}" : "Wise #{currency_code}"
|
|
|
|
update!(
|
|
current_balance: balance_value,
|
|
reserved_balance: data.dig(:reservedAmount, :value).to_d,
|
|
currency: currency_code,
|
|
name: name.presence || api_name || default_name,
|
|
raw_payload: payload
|
|
)
|
|
end
|
|
|
|
def upsert_wise_transactions_snapshot!(transactions)
|
|
update!(raw_transactions_payload: transactions)
|
|
end
|
|
end
|