Files
sure/mobile/lib/screens/main_navigation_screen.dart
ghost 9ea8261919 feat(mobile): migrate all hardcoded UI strings to gen_l10n ARB (Phase 1 + 2) (#2384)
* feat(mobile): add Flutter i18n foundation (gen_l10n Phase 1)

- Wire flutter_localizations + gen_l10n (pubspec.yaml + l10n.yaml)
- Bump intl ^0.18.1 → ^0.20.2 for Flutter 3.32 pin
- Add lib/l10n/app_en.arb with 9 seed keys (appTitle, 3 common*, 4 chatSuggestion*)
- Generate AppLocalizations via flutter gen-l10n
- Replace MaterialApp title: with onGenerateTitle + localizationsDelegates + supportedLocales
- Migrate suggested_questions.dart from const list to BuildContext function
- Update chat_conversation_screen.dart call site (one-line change at pre-designed seam)

* feat(mobile): migrate all hardcoded UI strings to gen_l10n ARB (Phase 2)

Extends the i18n foundation from Phase 1 to cover every remaining
hardcoded user-facing string across the mobile app.

Files changed (21 source files + ARB/generated):
- lib/l10n/app_en.arb: 226 keys (+~80 new keys covering all screens)
- lib/screens/dashboard_screen.dart
- lib/screens/calendar_screen.dart
- lib/screens/transactions_list_screen.dart
- lib/screens/backend_config_screen.dart
- lib/screens/recent_transactions_screen.dart
- lib/screens/biometric_lock_screen.dart
- lib/screens/chat_conversation_screen.dart
- lib/screens/chat_list_screen.dart
- lib/screens/log_viewer_screen.dart
- lib/screens/login_screen.dart
- lib/screens/main_navigation_screen.dart
- lib/screens/more_screen.dart
- lib/screens/settings_screen.dart
- lib/screens/sso_onboarding_screen.dart
- lib/screens/transaction_edit_screen.dart
- lib/screens/transaction_form_screen.dart
- lib/widgets/account_detail_header.dart
- lib/widgets/category_filter.dart
- lib/widgets/connectivity_banner.dart
- lib/widgets/currency_filter.dart
- lib/widgets/custom_proxy_headers_editor.dart

Notable patterns:
- ICU plural for connectivity pending-sync count
- Parameterised keys for greeting (firstName), update dialog
  (version), cash chip (amount), delete confirmation (name),
  show-N menu (count), proxy-headers count, multi-delete count
- AppLocalizations captured before async gaps; dialog builders
  re-obtain from their own BuildContext
- const removed only from Text/InputDecoration/SnackBar/Row
  widgets that directly reference localisation getters; sibling
  const widgets preserved

116/116 unit tests pass; flutter analyze --no-fatal-infos: 0 errors.

* feat(mobile): migrate the remaining secondary UI strings to gen_l10n ARB

Completes the i18n migration by covering the lower-traffic strings the
earlier passes left behind — secondary dialogs, snackbars, settings
rows, validators, helper texts, and tooltips across 11 files.

- settings_screen.dart: reset/delete-account dialogs, clear-data and
  proxy-header snackbars, list-tile titles/subtitles, theme-segment
  tooltips, biometric prompt reason, debug-logs semantics label
- transaction_form_screen.dart: amount validators, session/success/
  failure/generic-error snackbars, More/Less toggle, date/name/category
  fields + helper texts, create button
- transaction_edit_screen.dart: session/update snackbars, validators,
  category/merchant/tag fallbacks, synced-only notice
- login_screen.dart: API-key dialog, demo/sign-up TextSpan, MFA info +
  validator, divider, server-URL heading, API-key + backend tooltip
- chat_list_screen.dart: multi-delete plural, result snackbars, error
  heading, relative-time fallback
- chat_conversation_screen.dart: edit-title dialog, refresh tooltip,
  load-error heading
- connectivity_banner.dart: sign-in / sync-success / sync-failure /
  auth-failure snackbars (also resolves the const removals cleanly)
- main_navigation_screen.dart: enable-AI dialog + failure snackbar
- log_viewer_screen.dart: clear-logs confirmation dialog
- biometric_lock_screen.dart, transactions_list_screen.dart: snackbar
  and edit tooltip

Adds 98 ARB keys (now 324 total), reusing common* and existing
screen keys where text matched. Interpolations use String/int
placeholders; multi-delete uses an ICU plural. AppLocalizations is
captured before async gaps and re-obtained inside dialog builders;
const removed only where a localisation getter is introduced, with
const restored on still-const siblings.

116/116 unit tests pass; flutter analyze --no-fatal-infos: 0 errors
(6 pre-existing infos unchanged). No remaining hardcoded user-facing
strings (verified by grep; only a doc-comment example remains).

* fix(mobile): address i18n review feedback and prune dead ARB keys

Resolves the still-valid CodeRabbit/Codex review findings on the i18n
migration; the majority were already handled by earlier commits.

- pubspec: switch intl to `any` so flutter_localizations selects the
  SDK-pinned version (0.19.x on <3.32, 0.20.x on 3.32+). Pinning
  ^0.20.2 conflicted with the declared `flutter: '>=3.27.0'` floor and
  would break `flutter pub get` on pre-3.32 SDKs.
- sso_onboarding: localize "Signed in as {email}" / "Google account
  verified" / the link- and create-form notes; fix the first/last-name
  validators that wrongly returned the "Email is required" message.
- backend_config: localize _testConnection / _saveAndContinue /
  _validateUrl messages and the headers helper text (validator now
  takes AppLocalizations; async methods capture it before awaits).
- recent_transactions: localize "Unknown Account"; locale-aware
  timestamp.
- account_detail_header: localize the unavailable-details message via a
  render-time flag (avoids touching inherited widgets in the
  initState-driven load path); treat empty/whitespace securityName as
  missing for the holding-name fallback.
- dashboard: wrap syncing/refreshing snackbar text in Expanded to avoid
  overflow with long translations; use the distinct dashboardSyncError
  key on the exception path.
- chat_list: localize relative-time labels (plural keys) and use a
  locale-aware fallback date; calendar: locale-aware displayed dates and
  weekday letters (map-key formats left fixed; Sunday-anchored grid
  preserved).
- connectivity_banner: capture ScaffoldMessenger before the async gap
  (removes use_build_context_synchronously); log_viewer: const Duration.
- Prune 55 unused ARB keys (never-wired scaffolding + superseded
  duplicates). ARB now 298 keys, 0 unused.

116/116 tests pass; flutter analyze --no-fatal-infos: 0 errors, only 3
pre-existing infos in the untouched intro_screen_web.dart.

* fix(mobile): localize the log viewer empty-state string

The 'No logs yet' empty state was the last hardcoded user-facing string
(the logViewerEmpty key had been pruned before this string was migrated).
Re-add the key and route the empty state through AppLocalizations.

Closes the final CodeRabbit i18n-coverage thread. 0 analyze errors,
116 tests pass, ARB at 299 keys with 0 unused.

* fix(mobile): address i18n review feedback

- sso_onboarding: the "Accept Invitation" tab and submit buttons showed
  the Terms-of-Service string (ssoOnboardingAcceptTerms) when a household
  invitation was pending. Add ssoOnboardingAcceptInvitation and use it in
  both spots; drop the now-unused ToS key (no ToS checkbox exists).
- transaction_form: restore the required-field indicator on the amount
  label ("Amount *") that the migration dropped.
- settings: localize the "a newer version" fallback used in the update
  dialog when the store version is unknown.
- ARB plurals: use the CLDR `one{}` category instead of the exact-match
  `=1{}` so future non-English locales pluralize correctly. English output
  is unchanged.

ARB at 300 keys, 0 unused. 116 tests pass; flutter analyze: no new issues.

* fix(mobile): reconcile i18n with design-system primitives after merge

The merge of main into this branch pulled in the design-system primitive
migrations (SureCard/SureChip/SureSegmentedControl/SureTextField/
SureListGroup), which collided with the i18n string migration and left
several files broken (compile errors / un-localized text).

Re-apply the i18n migration on top of the design-system versions:
- more_screen: SureListGroup/SureListRow rows now use l.more* keys
  (was a mangled mix of _buildMenuItem + SureListGroup).
- transaction_form_screen: SureSegmentedControl segments + amount/date/
  name/category labels, helpers, validators, and snackbars localized;
  add transactionFormAmountHelper ("Required") for the amount helper text.
- custom_proxy_headers_editor: SureTextField label/hint params localized.
- currency_filter: the "All" chip is a SureChip again (the merge had left
  it as a Material FilterChip) and uses l.commonAll.
- currency_filter_test / custom_proxy_headers_editor_test: add the
  localization delegates the widgets now require.

ARB at 301 keys, 0 unused. 165 tests pass; flutter analyze: 0 errors.

---------

Signed-off-by: Juan José Mata <juanjo.mata@gmail.com>
Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
2026-06-21 11:53:12 +02:00

252 lines
6.5 KiB
Dart

import 'package:flutter/material.dart';
import 'package:provider/provider.dart';
import '../providers/auth_provider.dart';
import '../widgets/sure_logo.dart';
import 'chat_list_screen.dart';
import 'dashboard_screen.dart';
import 'intro_screen.dart';
import 'more_screen.dart';
import 'settings_screen.dart';
import '../l10n/app_localizations.dart';
class MainNavigationScreen extends StatefulWidget {
const MainNavigationScreen({super.key});
@override
State<MainNavigationScreen> createState() => _MainNavigationScreenState();
}
class _MainNavigationScreenState extends State<MainNavigationScreen> {
int _currentIndex = 0;
final _dashboardKey = GlobalKey<DashboardScreenState>();
List<Widget> _buildScreens(bool introLayout, VoidCallback? onStartChat) {
final screens = <Widget>[];
if (!introLayout) {
screens.add(DashboardScreen(key: _dashboardKey));
}
if (introLayout) {
screens.add(IntroScreen(onStartChat: onStartChat));
}
screens.add(const ChatListScreen());
if (!introLayout) {
screens.add(const MoreScreen());
}
screens.add(const SettingsScreen());
return screens;
}
Future<void> _handleDestinationSelected(
int index,
AuthProvider authProvider,
bool introLayout,
) async {
const chatIndex = 1;
if (index == chatIndex && !authProvider.aiEnabled) {
final enabled = await _showEnableAiPrompt();
if (!enabled) {
return;
}
}
if (mounted) {
setState(() {
_currentIndex = index;
});
if (!introLayout && index == 0) {
_dashboardKey.currentState?.reloadPreferences();
}
}
}
Future<void> _handleSelectSettings(AuthProvider authProvider, bool introLayout) async {
final settingsIndex = introLayout ? 2 : 3;
await _handleDestinationSelected(settingsIndex, authProvider, introLayout);
}
List<NavigationDestination> _buildDestinations(bool introLayout, AppLocalizations l) {
final destinations = <NavigationDestination>[];
if (!introLayout) {
destinations.add(
NavigationDestination(
icon: const Icon(Icons.home_outlined),
selectedIcon: const Icon(Icons.home),
label: l.navHome,
),
);
}
if (introLayout) {
destinations.add(
NavigationDestination(
icon: const Icon(Icons.auto_awesome_outlined),
selectedIcon: const Icon(Icons.auto_awesome),
label: l.navIntro,
),
);
}
destinations.add(
NavigationDestination(
icon: const Icon(Icons.chat_bubble_outline),
selectedIcon: const Icon(Icons.chat_bubble),
label: l.navAssistant,
),
);
if (!introLayout) {
destinations.add(
NavigationDestination(
icon: const Icon(Icons.more_horiz),
selectedIcon: const Icon(Icons.more_horiz),
label: l.navMore,
),
);
}
return destinations;
}
PreferredSizeWidget _buildTopBar(AuthProvider authProvider, bool introLayout) {
return AppBar(
automaticallyImplyLeading: false,
toolbarHeight: 60,
elevation: 0,
titleSpacing: 0,
centerTitle: false,
actionsPadding: EdgeInsets.zero,
title: Container(
width: 60,
height: 60,
alignment: Alignment.topLeft,
child: const Padding(
padding: EdgeInsets.only(top: 12, left: 12),
child: SureLogo(),
),
),
actions: [
Padding(
padding: const EdgeInsets.only(right: 12),
child: Center(
child: InkWell(
onTap: () {
_handleSelectSettings(authProvider, introLayout);
},
child: const SizedBox(
width: 36,
height: 36,
child: Icon(Icons.settings_outlined),
),
),
),
),
],
);
}
Future<bool> _showEnableAiPrompt() async {
final l = AppLocalizations.of(context);
final authProvider = Provider.of<AuthProvider>(context, listen: false);
final shouldEnable = await showDialog<bool>(
context: context,
builder: (context) {
final dl = AppLocalizations.of(context);
return AlertDialog(
title: Text(dl.navEnableAiChatTitle),
content: Text(dl.navEnableAiChatContent),
actions: [
TextButton(
onPressed: () => Navigator.of(context).pop(false),
child: Text(dl.navEnableAiChatNotNow),
),
FilledButton(
onPressed: () => Navigator.of(context).pop(true),
child: Text(dl.navEnableAiChatConfirm),
),
],
);
},
);
if (shouldEnable != true) {
return false;
}
final enabled = await authProvider.enableAi();
if (!enabled && mounted) {
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
content: Text(authProvider.errorMessage ?? l.navEnableAiChatFailed),
backgroundColor: Colors.red,
),
);
}
return enabled;
}
int _resolveBottomSelectedIndex(List<NavigationDestination> destinations) {
if (destinations.isEmpty) {
return 0;
}
if (_currentIndex < 0) {
return 0;
}
if (_currentIndex >= destinations.length) {
return destinations.length - 1;
}
return _currentIndex;
}
@override
Widget build(BuildContext context) {
final l = AppLocalizations.of(context);
return Consumer<AuthProvider>(
builder: (context, authProvider, _) {
final introLayout = authProvider.isIntroLayout;
const chatIndex = 1;
final screens = _buildScreens(
introLayout,
() => _handleDestinationSelected(chatIndex, authProvider, introLayout),
);
final destinations = _buildDestinations(introLayout, l);
final bottomNavIndex = _resolveBottomSelectedIndex(destinations);
if (_currentIndex >= screens.length) {
_currentIndex = 0;
}
return Scaffold(
appBar: _buildTopBar(authProvider, introLayout),
body: IndexedStack(
index: _currentIndex,
children: screens,
),
bottomNavigationBar: NavigationBar(
selectedIndex: bottomNavIndex,
onDestinationSelected: (index) {
_handleDestinationSelected(index, authProvider, introLayout);
},
destinations: destinations,
),
);
},
);
}
}