mirror of
https://github.com/we-promise/sure.git
synced 2026-05-25 21:44:56 +00:00
7e1de420ca
* perf(accounts): kill sidebar/sparkline N+1s and cache the sidebar The dashboard was issuing hundreds of per-account `SELECT 1` and polymorphic `accountable` lookups on every page load. Sidebar render alone hit the DB ~50–100× and ran twice per request (mobile + desktop). Changes: - AccountableSparklinesController: short-circuit `requires_normalized_aggregation?` to Investment/Crypto only and collapse the per-account `linked?` loop into a single `EXISTS`. Kills the N+1 `AccountProvider Exists?` queries on every sparkline endpoint. - BalanceSheet::AccountTotals#visible_accounts: preload `:accountable`, `:plaid_account`, `:simplefin_account`, and `account_providers: :provider` so the sidebar's `account.subtype` / `account.linked?` / `account.provider` calls don't trigger per-row polymorphic loads. - AccountsController#index: same preloads on `@manual_accounts`. - accounts/index/_account_groups.erb: extend the existing `Preloader` call to batch-load accountable + provider associations so the per-provider-item partials (Plaid, SimpleFIN, Coinbase, etc.) stop re-issuing N+1s when rendering account rows on /accounts. - accounts/_account_sidebar_tabs.html.erb: wrap the partial in a `cache` block keyed on the family's data-version, the current user, shares fingerprint, locale, mobile flag, active tab, and a path-derived "current account" component (`sidebar_active_account_id` helper). The sidebar is rendered on every page in the layout (twice — mobile + desktop drawers), so most navigations now serve the cached fragment instead of re-walking accounts/balances. Local impact (DZG family, 23 accounts, 6.1k transactions): - Dashboard `/`: ~6.5s → ~1.95s - /accounts: ~2.7s → ~0.85s on warm cache - /accountable_sparklines/*: per-request N+1s eliminated; remaining cost is request boilerplate which can be addressed by bumping `RAILS_MAX_THREADS` (the dashboard fans out 5 sparkline turbo frames in parallel and Puma's default 3 threads serialize them). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(perf): address PR review on sidebar/sparkline perf changes - AccountableSparklinesController#requires_normalized_aggregation? also matches legacy plaid_account_id / simplefin_account_id links, not just new-style account_providers, so investment/crypto accounts in the legacy linking state still get LinkedInvestmentSeriesNormalizer applied (Codex P1 / CodeRabbit major). - Sidebar share fingerprint includes both `count` and `max(updated_at)` so deleting a non-most-recent AccountShare invalidates the cached fragment for users who lost access (Codex P1). - Move the sidebar cache-key construction (incl. the AccountShare query) from the ERB into a new `account_sidebar_tabs_cache_key` helper, per the project's "no heavy logic in ERB" rule (CodeRabbit). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(perf): address human review on perf PR - Account.linked: new SQL-level scope mirroring `Account#linked?` so the controller and per-instance method share one definition. Removes the duplicated raw SQL string in `AccountableSparklinesController#requires_normalized_aggregation?`, which now reads `accounts.linked.exists?` (jjmata, sure-design). - AccountsHelper: move `sidebar_active_account_id` and `account_sidebar_tabs_cache_key` out of `ApplicationHelper`. The cache-key helper also collapses the AccountShare `count` + `max(updated_at)` fingerprint into a single `pick` query so we don't pay two round-trips on every render (jjmata, sure-design). - test/models/account/linkable_test.rb: pin the `Account.linked` scope against all three link types (account_providers, legacy plaid_account, legacy simplefin_account) so any future schema change that diverges the SQL definition from `linked?` breaks a test instead of silently serving wrong sparkline aggregations (sure-design). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(perf): correct shares cache fingerprint on raw-SQL pick `pick(Arel.sql("count(*), max(updated_at)"))` passes a single comma- separated fragment, which Rails returns as a String (per the documented behavior of `pluck` with SQL fragments). The previous `max_at&.to_i` silently truncated `"2025-05-06 12:34:56.789 UTC"` to `2025`, so the sidebar cache key would not change for share `updated_at` movements within the same calendar year — including share deletions — leaving revoked users with a stale sidebar until the 12h expiry. Pass the aggregates as two separate `Arel.sql` args and just concatenate the raw String values into the cache key. The values only need to be stable for a given DB state, not numerically meaningful. Caught by CodeRabbit on PR #1683. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
93 lines
3.4 KiB
Plaintext
93 lines
3.4 KiB
Plaintext
<%# locals: (family:, active_tab:, mobile: false) %>
|
|
|
|
<% cache account_sidebar_tabs_cache_key(family: family, active_tab: active_tab, mobile: mobile), expires_in: 12.hours do %>
|
|
<div id="account-sidebar-tabs">
|
|
<% if family.missing_data_provider? %>
|
|
<details class="group bg-yellow-tint-10 rounded-lg p-2 text-yellow-600 mb-3 text-xs">
|
|
<summary class="flex items-center justify-between gap-2">
|
|
<div class="flex items-center gap-2">
|
|
<%= icon "triangle-alert", size: "sm", color: "warning" %>
|
|
<p class="font-medium"><%= t("accounts.sidebar.missing_data") %></p>
|
|
</div>
|
|
|
|
<%= icon("chevron-down", color: "warning", class: "group-open:transform group-open:rotate-180") %>
|
|
</summary>
|
|
<div class="text-xs py-2 space-y-2">
|
|
<p><%= t("accounts.sidebar.missing_data_description", product: product_name) %></p>
|
|
<p>
|
|
<%= link_to t("accounts.sidebar.configure_providers"), settings_hosting_path, class: "text-yellow-600 underline" %>
|
|
</p>
|
|
</div>
|
|
</details>
|
|
<% end %>
|
|
|
|
<%= render DS::Tabs.new(active_tab: active_tab, session_key: "account_sidebar_tab", testid: "account-sidebar-tabs") do |tabs| %>
|
|
<% tabs.with_nav do |nav| %>
|
|
<% nav.with_btn(id: "all", label: t("accounts.sidebar.tabs.all")) %>
|
|
<% nav.with_btn(id: "asset", label: t("accounts.sidebar.tabs.assets")) %>
|
|
<% nav.with_btn(id: "liability", label: t("accounts.sidebar.tabs.debts")) %>
|
|
<% end %>
|
|
|
|
<% tabs.with_panel(tab_id: "asset") do %>
|
|
<div class="space-y-2">
|
|
<%= render DS::Link.new(
|
|
text: t("accounts.sidebar.new_asset"),
|
|
variant: "ghost",
|
|
href: new_account_path(step: "method_select", classification: "asset"),
|
|
icon: "plus",
|
|
frame: :modal,
|
|
full_width: true,
|
|
class: "justify-start"
|
|
) %>
|
|
|
|
<div>
|
|
<% family.balance_sheet.assets.account_groups.each do |group| %>
|
|
<%= render "accounts/accountable_group", account_group: group, mobile: mobile %>
|
|
<% end %>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
|
|
<% tabs.with_panel(tab_id: "liability") do %>
|
|
<div class="space-y-2">
|
|
<%= render DS::Link.new(
|
|
text: t("accounts.sidebar.new_debt"),
|
|
variant: "ghost",
|
|
href: new_account_path(step: "method_select", classification: "liability"),
|
|
icon: "plus",
|
|
frame: :modal,
|
|
full_width: true,
|
|
class: "justify-start"
|
|
) %>
|
|
|
|
<div>
|
|
<% family.balance_sheet.liabilities.account_groups.each do |group| %>
|
|
<%= render "accounts/accountable_group", account_group: group, mobile: mobile %>
|
|
<% end %>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
|
|
<% tabs.with_panel(tab_id: "all") do %>
|
|
<div class="space-y-2">
|
|
<%= render DS::Link.new(
|
|
text: t("accounts.sidebar.new_account"),
|
|
variant: "ghost",
|
|
full_width: true,
|
|
href: new_account_path(step: "method_select"),
|
|
icon: "plus",
|
|
frame: :modal,
|
|
class: "justify-start"
|
|
) %>
|
|
|
|
<div>
|
|
<% family.balance_sheet.account_groups.each do |group| %>
|
|
<%= render "accounts/accountable_group", account_group: group, mobile: mobile, all_tab: true %>
|
|
<% end %>
|
|
</div>
|
|
</div>
|
|
<% end %>
|
|
<% end %>
|
|
</div>
|
|
<% end %>
|