mirror of
https://github.com/we-promise/sure.git
synced 2026-06-01 00:39:01 +00:00
* feat(investments): add India investment subtypes and exchange support * fix(yahoo-finance): scope Indian exchange de-duplication per company instead of globally Resolves feedback from Codex and CodeRabbit on #1413. prefer_indian_exchange previously collapsed all Indian securities into a single entry, silently dropping unrelated tickers. Now groups Indian listings by name and only de-duplicates within each group, so distinct companies (e.g. Reliance and Infosys) are preserved while NSE/BSE dual-listings still prefer NSE. - Derive India subtype keys dynamically from Investment::SUBTYPES in tests - Fix missing keyword arguments in Security.new test calls * refactor(yahoo-finance): generalize exchange config and dual-listing de-duplication Replaces hardcoded Indian exchange logic with a declarative EXCHANGE_CONFIG hash that maps ISO MIC codes to Yahoo-specific settings (symbol suffix, default currency, dual-listing group, and preference rank). This makes adding new markets a one-line hash entry instead of scattered conditionals. * fix(yahoo-finance): normalize security names for dual-listing de-duplication * fix(yahoo-finance): skip dual-listing de-duplication when filtering by exchange * fix: address PR review feedback for India market support - fix cache key mismatch in fetch_security_price by normalizing symbol before building cache key - remove dead YAHOO_EXCHANGE_CURRENCY constant - tighten normalize_symbol guard to use end_with?(suffix) instead of include?('.') - remove misleading '# India' comment from Property::SUBTYPES - remove 'rented' property subtype in favor of 'investment_property' - rename 'demat' to 'indian_stocks' for clarity - add INR to CURRENCY_REGION_MAP so India appears first for INR users - add dotted-symbol regression test for normalize_symbol * fix(investments): rename 'demat' subtype to 'indian_stocks' and remove trailing comma
49 lines
1.2 KiB
YAML
49 lines
1.2 KiB
YAML
---
|
|
en:
|
|
properties:
|
|
edit:
|
|
edit: Edit %{account}
|
|
form:
|
|
address_line1: Street address
|
|
address_line1_placeholder: 123 Main St
|
|
area: Living area
|
|
area_placeholder: '2000'
|
|
area_unit: Unit of measurement
|
|
country: Country
|
|
country_placeholder: US
|
|
locality: City
|
|
locality_placeholder: San Francisco
|
|
none: None
|
|
postal_code: ZIP/Postal code
|
|
postal_code_placeholder: '94105'
|
|
region: State/Province
|
|
region_placeholder: CA
|
|
subtype_prompt: Select property type
|
|
year_built: Year built
|
|
year_built_placeholder: '2000'
|
|
new:
|
|
title: Enter property details
|
|
overview:
|
|
living_area: Living Area
|
|
market_value: Market Value
|
|
purchase_price: Purchase Price
|
|
trend: Trend
|
|
unknown: Unknown
|
|
year_built: Year Built
|
|
subtypes:
|
|
apartment:
|
|
short: Apartment
|
|
long: Apartment
|
|
plot:
|
|
short: Plot
|
|
long: Plot / Land
|
|
commercial:
|
|
short: Commercial
|
|
long: Commercial Property
|
|
rented:
|
|
short: Rented
|
|
long: Rented Property
|
|
agri_land:
|
|
short: Agri Land
|
|
long: Agricultural Land
|