mirror of
https://github.com/we-promise/sure.git
synced 2026-04-19 03:54:08 +00:00
fea228d03e
* Fix syncing issues with new connections and accounts.. - Keep SimpleFin institution metadata strictly per account (`simplefin_accounts.org_data`). - Relax `simplefin_items` institution constraints to allow creating items before org data exists. - Remove code that copied the first account’s `org` onto `simplefin_items`. * Improve Simplefin Sync • SimpleFin: family “Sync” includes SimpleFin items; importer does unbounded discovery (with pending=1 fallback) before windowed fetch, for both regular and first syncs. • Stop populating item‑level institution fields; keep institution metadata per account. • Relax NOT NULL on item institution fields. • Post‑sync dashboard broadcasts are now guarded (UI cannot fail the job). • Show a friendly “daily refresh limit” banner on the SimpleFin card when the latest sync is rate‑limited. • Add bin/rails sure:simplefin:debug[ITEM_ID] to print latest sync, snapshot account count, simplefin_accounts count, and unlinked list. * Fixed double‑quoted strings, spacing around array brackets and commas * chore: ignore local .junie files * - Broadcast error logs now include full backtraces - SimpleFin discovery logic deduplicated fixed - app/models/simplefin_item/importer.rb --Added a concise docstring for perform_account_discovery describing purpose, steps, and side‑effects. --Added a docstring for fetch_accounts_data describing params and return value.
33 lines
1.1 KiB
Ruby
33 lines
1.1 KiB
Ruby
class Family::SyncCompleteEvent
|
|
attr_reader :family
|
|
|
|
def initialize(family)
|
|
@family = family
|
|
end
|
|
|
|
def broadcast
|
|
# Dashboard partials can occasionally raise when rendered from background jobs
|
|
# (e.g., if intermediate series values are nil during a sync). Make broadcasts
|
|
# resilient so a post-sync UI refresh never causes the overall sync to report an error.
|
|
begin
|
|
family.broadcast_replace(
|
|
target: "balance-sheet",
|
|
partial: "pages/dashboard/balance_sheet",
|
|
locals: { balance_sheet: family.balance_sheet }
|
|
)
|
|
rescue => e
|
|
Rails.logger.error("Family::SyncCompleteEvent balance_sheet broadcast failed: #{e.message}\n#{e.backtrace&.join("\n")}")
|
|
end
|
|
|
|
begin
|
|
family.broadcast_replace(
|
|
target: "net-worth-chart",
|
|
partial: "pages/dashboard/net_worth_chart",
|
|
locals: { balance_sheet: family.balance_sheet, period: Period.last_30_days }
|
|
)
|
|
rescue => e
|
|
Rails.logger.error("Family::SyncCompleteEvent net_worth_chart broadcast failed: #{e.message}\n#{e.backtrace&.join("\n")}")
|
|
end
|
|
end
|
|
end
|