QT/InvoiceShelf
1
0
Fork 0
mirror of https://github.com/InvoiceShelf/InvoiceShelf.git synced 2026-04-19 03:04:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix infinite request loop on File Disk admin page

Browse Source 
configureMediaDisk() was calling FileDisk::setConfig() which mutates
the global filesystems.default config on every request. This caused
cascading requests on the File Disk admin page.

Now registers the media disk config directly without changing the
global default filesystem.
This commit is contained in:
Darko Gjorgjijoski
2026-04-07 01:05:08 +02:00
parent 67268ac2b7
commit 6dd9ed1232
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/Providers/AppServiceProvider.php
View File

@@ -186,9 +186,21 @@ class AppServiceProvider extends ServiceProvider
: FileDisk::where('set_as_default', true)->first();
if ($disk) {
$disk->setConfig();
// Register the disk config without changing the global default.
// setConfig() mutates filesystems.default which causes side effects.
$prefix = env('DYNAMIC_DISK_PREFIX', 'temp_');
config(['media-library.disk_name' => $prefix.$disk->driver]);
$diskName = $prefix.$disk->driver;
$credentials = collect(json_decode($disk->credentials));
$baseConfig = config('filesystems.disks.'.$disk->driver, []);
foreach ($baseConfig as $key => $value) {
if ($credentials->has($key)) {
$baseConfig[$key] = $credentials[$key];
}
}
config(['filesystems.disks.'.$diskName => $baseConfig]);
config(['media-library.disk_name' => $diskName]);
}
} catch (\Exception $e) {
// DB not yet migrated or settings table missing — use config default