mirror of
https://github.com/InvoiceShelf/InvoiceShelf.git
synced 2026-07-17 06:15:20 +00:00
The app/Services/ directory had grown into 22 flat files at the root plus 7 uneven subdirectories — finding anything required scrolling through an alphabetical mix of small CRUD services, infrastructure drivers, and install-time utilities. This commit groups services by domain, folds Backup into a new Storage namespace, and moves framework-infrastructure and install-time helpers out of Services and into Support where they belong. New Services layout: Documents/ (Invoice, Estimate, RecurringInvoice, Payment, Expense, Transaction, DocumentItem, SerialNumber, Currency — matches the 'Documents' navigation group); Company/ (Company, Member, Invitation); Mail/ (MailConfiguration, CompanyMailConfig); Storage/ (FileDisk, plus Backup folded in). ExchangeRateProviderService moves next to its drivers in ExchangeRate/; FontService moves into Pdf/ where it belongs. CustomerService, ItemService, CustomFieldService stay at the Services root as standalone single-file domains. Moves to Support/: Hashids/ (library wrapper — not business logic); Setup/ (one-shot install-time utilities — stateless helpers); Pdf/ (ImageUtils, PdfTemplateUtils, plus the existing PdfHtmlSanitizer consolidated into the same subdir). These are all framework infrastructure and stateless utilities — the 'service' label never really fit them. Namespace declarations in 29 moved files updated to match new paths. 62 consumer files (controllers, other services, tests, database factories, seeders, routes, bootstrap/providers.php) have their use statements rewritten via a literal-string replacement script — no regex meant no risk of half-matching. Three Documents services needed an explicit 'use App\Services\Mail\CompanyMailConfigService' added because the same-namespace short reference they relied on no longer resolves after the split. Verified: composer dump-autoload, 350 tests pass (850 assertions), vendor/bin/pint clean, npm run build succeeds.
74 lines
1.5 KiB
PHP
74 lines
1.5 KiB
PHP
<?php
|
|
|
|
namespace App\Support\Setup;
|
|
|
|
class FilePermissionChecker
|
|
{
|
|
/**
|
|
* @var array
|
|
*/
|
|
protected $results = [];
|
|
|
|
/**
|
|
* Set the result array permissions and errors.
|
|
*
|
|
* @return mixed
|
|
*/
|
|
public function __construct()
|
|
{
|
|
$this->results['permissions'] = [];
|
|
|
|
$this->results['errors'] = null;
|
|
}
|
|
|
|
/**
|
|
* Check for the folders permissions.
|
|
*
|
|
* @return array
|
|
*/
|
|
public function check(array $folders)
|
|
{
|
|
foreach ($folders as $folder => $permission) {
|
|
if (! ($this->getPermission($folder) >= $permission)) {
|
|
$this->addFileAndSetErrors($folder, $permission, false);
|
|
} else {
|
|
$this->addFile($folder, $permission, true);
|
|
}
|
|
}
|
|
|
|
return $this->results;
|
|
}
|
|
|
|
/**
|
|
* Get a folder permission.
|
|
*
|
|
* @return string
|
|
*/
|
|
private function getPermission($folder)
|
|
{
|
|
return substr(sprintf('%o', fileperms(base_path($folder))), -4);
|
|
}
|
|
|
|
/**
|
|
* Add the file to the list of results.
|
|
*/
|
|
private function addFile($folder, $permission, $isSet)
|
|
{
|
|
array_push($this->results['permissions'], [
|
|
'folder' => $folder,
|
|
'permission' => $permission,
|
|
'isSet' => $isSet,
|
|
]);
|
|
}
|
|
|
|
/**
|
|
* Add the file and set the errors.
|
|
*/
|
|
private function addFileAndSetErrors($folder, $permission, $isSet)
|
|
{
|
|
$this->addFile($folder, $permission, $isSet);
|
|
|
|
$this->results['errors'] = true;
|
|
}
|
|
}
|