mirror of
https://github.com/InvoiceShelf/InvoiceShelf.git
synced 2026-08-04 15:12:12 +00:00
6cb754da60
PdfDriver and ResponseStream existed but nothing implemented them. The factory returned the vendor dompdf wrapper for one driver and a bespoke class for the other, so the two were never held to the same shape. Three things had slipped through that gap. Report PDFs answered 403 for everyone. The five report routes carry no company header, so ScopeBouncer is not in their middleware stack and the ability scope was never set; 'view-financial-reports' is stored scoped to a company, so the check could not pass. They now scope to the company named in the URL. The policy still checks membership, so this grants nothing new. Also firstOrFail() on the hash lookup, so an unknown company is a 404 rather than a 500 on a null. Report downloads were fatal on Gotenberg. GotenbergPdfResponse had no download(), and the report controllers are its only callers. Added, alongside stream() and output(), with the whole set now on the interface. Streamed documents carried an HTTP preamble. GeneratesPdfTrait wrapped $pdf->stream() -- already a Response -- in another response()->make(), which stringified it and prepended "HTTP/1.0 200 OK" plus headers to the file. Readers scan the first kilobyte for %PDF so nobody noticed, but the bytes were malformed. Passing ->output() fixes it, and the render test now asserts the position. Two driver-parity settings, both checked against a real gotenberg:8 rather than inferred: emulateScreenMediaType(), because Chromium defaults to print media while config/dompdf.php renders as screen, so a @media print rule applied on one driver and not the other; and printBackground(), which turns out to affect only the root background, since Chromium paints element backgrounds either way. No stock template sets a body background, so that one changes nothing today and is here to keep custom templates consistent across drivers. Claude-Session: https://claude.ai/code/session_01QmECndmNZwzN65Zz9P87dF
64 lines
2.2 KiB
PHP
64 lines
2.2 KiB
PHP
<?php
|
|
|
|
use App\Models\User;
|
|
use Illuminate\Support\Facades\Artisan;
|
|
use Laravel\Sanctum\Sanctum;
|
|
|
|
use function Pest\Laravel\get;
|
|
|
|
/**
|
|
* The five report controllers are the only callers of ->download(), and
|
|
* GotenbergPdfResponse never had that method. Selecting the Gotenberg driver
|
|
* therefore turned every report download into a fatal undefined-method error,
|
|
* while the same page streamed fine. Nothing caught it because the factory
|
|
* returned the vendor dompdf wrapper for one driver and a bespoke class for the
|
|
* other, with no shared type between them.
|
|
*
|
|
* These run against dompdf so they need no Gotenberg service; the contract that
|
|
* keeps the two in step is asserted in tests/Unit/PdfDriverContractTest.php.
|
|
*/
|
|
beforeEach(function () {
|
|
Artisan::call('db:seed', ['--class' => 'DatabaseSeeder', '--force' => true]);
|
|
Artisan::call('db:seed', ['--class' => 'DemoSeeder', '--force' => true]);
|
|
|
|
$user = User::find(1);
|
|
$this->company = $user->companies()->first();
|
|
|
|
// Bouncer scopes abilities by company, so `view report` only resolves with
|
|
// the company header set.
|
|
$this->withHeaders(['company' => $this->company->id]);
|
|
|
|
Sanctum::actingAs($user, ['*']);
|
|
|
|
config(['pdf.driver' => 'dompdf']);
|
|
});
|
|
|
|
dataset('reports', [
|
|
'sales/customers',
|
|
'sales/items',
|
|
'expenses',
|
|
'tax-summary',
|
|
'profit-loss',
|
|
]);
|
|
|
|
function reportUrl(string $report, string $hash, string $extra = ''): string
|
|
{
|
|
return "/reports/{$report}/{$hash}?from_date=2020-01-01&to_date=2030-12-31{$extra}";
|
|
}
|
|
|
|
test('every report streams a pdf', function (string $report) {
|
|
$response = get(reportUrl($report, $this->company->unique_hash));
|
|
|
|
$response->assertOk();
|
|
expect($response->headers->get('content-type'))->toContain('application/pdf');
|
|
expect($response->getContent())->toStartWith('%PDF-');
|
|
})->with('reports');
|
|
|
|
test('every report can be downloaded as an attachment', function (string $report) {
|
|
$response = get(reportUrl($report, $this->company->unique_hash, '&download=true'));
|
|
|
|
$response->assertOk();
|
|
expect($response->headers->get('content-disposition'))->toContain('attachment');
|
|
expect($response->getContent())->toStartWith('%PDF-');
|
|
})->with('reports');
|