mirror of
https://github.com/InvoiceShelf/InvoiceShelf.git
synced 2026-07-17 14:25:21 +00:00
The app/Services/ directory had grown into 22 flat files at the root plus 7 uneven subdirectories — finding anything required scrolling through an alphabetical mix of small CRUD services, infrastructure drivers, and install-time utilities. This commit groups services by domain, folds Backup into a new Storage namespace, and moves framework-infrastructure and install-time helpers out of Services and into Support where they belong. New Services layout: Documents/ (Invoice, Estimate, RecurringInvoice, Payment, Expense, Transaction, DocumentItem, SerialNumber, Currency — matches the 'Documents' navigation group); Company/ (Company, Member, Invitation); Mail/ (MailConfiguration, CompanyMailConfig); Storage/ (FileDisk, plus Backup folded in). ExchangeRateProviderService moves next to its drivers in ExchangeRate/; FontService moves into Pdf/ where it belongs. CustomerService, ItemService, CustomFieldService stay at the Services root as standalone single-file domains. Moves to Support/: Hashids/ (library wrapper — not business logic); Setup/ (one-shot install-time utilities — stateless helpers); Pdf/ (ImageUtils, PdfTemplateUtils, plus the existing PdfHtmlSanitizer consolidated into the same subdir). These are all framework infrastructure and stateless utilities — the 'service' label never really fit them. Namespace declarations in 29 moved files updated to match new paths. 62 consumer files (controllers, other services, tests, database factories, seeders, routes, bootstrap/providers.php) have their use statements rewritten via a literal-string replacement script — no regex meant no risk of half-matching. Three Documents services needed an explicit 'use App\Services\Mail\CompanyMailConfigService' added because the same-namespace short reference they relied on no longer resolves after the split. Verified: composer dump-autoload, 350 tests pass (850 assertions), vendor/bin/pint clean, npm run build succeeds.
189 lines
5.2 KiB
PHP
189 lines
5.2 KiB
PHP
<?php
|
|
|
|
use App\Http\Requests\InvoicesRequest;
|
|
use App\Models\Invoice;
|
|
use App\Models\InvoiceItem;
|
|
use App\Models\Tax;
|
|
use App\Services\Documents\DocumentItemService;
|
|
use App\Services\Documents\InvoiceService;
|
|
use Illuminate\Support\Facades\Artisan;
|
|
|
|
beforeEach(function () {
|
|
Artisan::call('db:seed', ['--class' => 'DatabaseSeeder', '--force' => true]);
|
|
Artisan::call('db:seed', ['--class' => 'DemoSeeder', '--force' => true]);
|
|
});
|
|
|
|
test('invoice has many invoice items', function () {
|
|
$invoice = Invoice::factory()->hasItems(5)->create();
|
|
|
|
$this->assertCount(5, $invoice->items);
|
|
|
|
$this->assertTrue($invoice->items()->exists());
|
|
});
|
|
|
|
test('invoice has many taxes', function () {
|
|
$invoice = Invoice::factory()->hasTaxes(5)->create();
|
|
|
|
$this->assertCount(5, $invoice->taxes);
|
|
|
|
$this->assertTrue($invoice->taxes()->exists());
|
|
});
|
|
|
|
test('invoice has many payments', function () {
|
|
$invoice = Invoice::factory()->hasPayments(5)->create();
|
|
|
|
$this->assertCount(5, $invoice->payments);
|
|
|
|
$this->assertTrue($invoice->payments()->exists());
|
|
});
|
|
|
|
test('invoice belongs to customer', function () {
|
|
$invoice = Invoice::factory()->forCustomer()->create();
|
|
|
|
$this->assertTrue($invoice->customer()->exists());
|
|
});
|
|
|
|
test('get previous status', function () {
|
|
$invoice = Invoice::factory()->create();
|
|
|
|
$status = $invoice->getPreviousStatus();
|
|
|
|
$this->assertEquals('DRAFT', $status);
|
|
});
|
|
|
|
test('create invoice', function () {
|
|
$invoice = Invoice::factory()->raw();
|
|
|
|
$item = InvoiceItem::factory()->raw();
|
|
|
|
$invoice['items'] = [];
|
|
array_push($invoice['items'], $item);
|
|
|
|
$invoice['taxes'] = [];
|
|
array_push($invoice['taxes'], Tax::factory()->raw());
|
|
|
|
$request = new InvoicesRequest;
|
|
|
|
$request->replace($invoice);
|
|
|
|
$invoice_number = explode('-', $invoice['invoice_number']);
|
|
$number_attributes['invoice_number'] = $invoice_number[0].'-'.sprintf('%06d', intval($invoice_number[1]));
|
|
|
|
$response = app(InvoiceService::class)->create($request);
|
|
|
|
$this->assertDatabaseHas('invoice_items', [
|
|
'invoice_id' => $response->id,
|
|
'name' => $item['name'],
|
|
'description' => $item['description'],
|
|
'total' => $item['total'],
|
|
'quantity' => $item['quantity'],
|
|
'discount' => $item['discount'],
|
|
'price' => $item['price'],
|
|
]);
|
|
|
|
$this->assertDatabaseHas('invoices', [
|
|
'invoice_number' => $invoice['invoice_number'],
|
|
'sub_total' => $invoice['sub_total'],
|
|
'total' => $invoice['total'],
|
|
'tax' => $invoice['tax'],
|
|
'discount' => $invoice['discount'],
|
|
'notes' => $invoice['notes'],
|
|
'customer_id' => $invoice['customer_id'],
|
|
'template_name' => $invoice['template_name'],
|
|
]);
|
|
});
|
|
|
|
test('update invoice', function () {
|
|
$invoice = Invoice::factory()->create();
|
|
|
|
$newInvoice = Invoice::factory()->raw();
|
|
|
|
$item = InvoiceItem::factory()->raw([
|
|
'invoice_id' => $invoice->id,
|
|
]);
|
|
|
|
$tax = Tax::factory()->raw([
|
|
'invoice_id' => $invoice->id,
|
|
]);
|
|
|
|
$newInvoice['items'] = [];
|
|
$newInvoice['taxes'] = [];
|
|
|
|
array_push($newInvoice['items'], $item);
|
|
array_push($newInvoice['taxes'], $tax);
|
|
|
|
$request = new InvoicesRequest;
|
|
|
|
$request->replace($newInvoice);
|
|
|
|
$invoice_number = explode('-', $newInvoice['invoice_number']);
|
|
|
|
$number_attributes['invoice_number'] = $invoice_number[0].'-'.sprintf('%06d', intval($invoice_number[1]));
|
|
|
|
$response = app(InvoiceService::class)->update($invoice, $request);
|
|
|
|
$this->assertDatabaseHas('invoice_items', [
|
|
'invoice_id' => $response->id,
|
|
'name' => $item['name'],
|
|
'description' => $item['description'],
|
|
'total' => $item['total'],
|
|
'quantity' => $item['quantity'],
|
|
'discount' => $item['discount'],
|
|
'price' => $item['price'],
|
|
]);
|
|
|
|
$this->assertDatabaseHas('invoices', [
|
|
'invoice_number' => $newInvoice['invoice_number'],
|
|
'sub_total' => $newInvoice['sub_total'],
|
|
'total' => $newInvoice['total'],
|
|
'tax' => $newInvoice['tax'],
|
|
'discount' => $newInvoice['discount'],
|
|
'notes' => $newInvoice['notes'],
|
|
'customer_id' => $newInvoice['customer_id'],
|
|
'template_name' => $newInvoice['template_name'],
|
|
]);
|
|
});
|
|
|
|
test('create items', function () {
|
|
$invoice = Invoice::factory()->create();
|
|
|
|
$items = [];
|
|
|
|
$item = InvoiceItem::factory()->raw([
|
|
'invoice_id' => $invoice->id,
|
|
]);
|
|
|
|
array_push($items, $item);
|
|
|
|
app(DocumentItemService::class)->createItems($invoice, $items);
|
|
|
|
$this->assertDatabaseHas('invoice_items', [
|
|
'invoice_id' => $invoice->id,
|
|
'description' => $item['description'],
|
|
'price' => $item['price'],
|
|
'tax' => $item['tax'],
|
|
'quantity' => $item['quantity'],
|
|
'total' => $item['total'],
|
|
]);
|
|
});
|
|
|
|
test('create taxes', function () {
|
|
$invoice = Invoice::factory()->create();
|
|
|
|
$taxes = [];
|
|
|
|
$tax = Tax::factory()->raw([
|
|
'invoice_id' => $invoice->id,
|
|
]);
|
|
|
|
array_push($taxes, $tax);
|
|
|
|
app(DocumentItemService::class)->createTaxes($invoice, $taxes);
|
|
|
|
$this->assertDatabaseHas('taxes', [
|
|
'invoice_id' => $invoice->id,
|
|
'name' => $tax['name'],
|
|
'amount' => $tax['amount'],
|
|
]);
|
|
});
|